summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/voicemail
diff options
context:
space:
mode:
authorlinyuh <linyuh@google.com>2018-03-19 20:09:53 -0700
committerCopybara-Service <copybara-piper@google.com>2018-03-19 20:11:52 -0700
commitd6180d452cc6085f64c25d487bfaee3a614dd67a (patch)
tree82dbfdd08c98e6412e36428085639053848373cc /java/com/android/dialer/voicemail
parent67a08ed881afd9b3f7bee630eb58d39ffd8efae2 (diff)
Make the top row of the bottom sheet not clickable.
Test: Existing tests PiperOrigin-RevId: 189683790 Change-Id: I0209e7fa839175041da29e9a6d8a590133121376
Diffstat (limited to 'java/com/android/dialer/voicemail')
-rw-r--r--java/com/android/dialer/voicemail/listui/menu/BottomSheetHeader.java (renamed from java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java)24
-rw-r--r--java/com/android/dialer/voicemail/listui/menu/NewVoicemailMenu.java2
2 files changed, 9 insertions, 17 deletions
diff --git a/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java b/java/com/android/dialer/voicemail/listui/menu/BottomSheetHeader.java
index 14c83563a..bf86278b2 100644
--- a/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java
+++ b/java/com/android/dialer/voicemail/listui/menu/BottomSheetHeader.java
@@ -16,39 +16,31 @@
package com.android.dialer.voicemail.listui.menu;
-import android.content.Context;
import android.text.TextUtils;
import com.android.dialer.calllogutils.NumberAttributesConverter;
-import com.android.dialer.historyitemactions.HistoryItemPrimaryActionInfo;
+import com.android.dialer.historyitemactions.HistoryItemBottomSheetHeaderInfo;
import com.android.dialer.voicemail.model.VoicemailEntry;
-/** Configures the primary action row (top row) for theottom sheet for the Voicemail Tab */
-final class PrimaryAction {
+/** Configures the top row in the bottom sheet for the Voicemail Tab */
+final class BottomSheetHeader {
- // TODO(uabdullah): Need to do the following:
- // setIsVideo - check if is passing in voicemailEntry.features() is required
- // setLookupUri - check if passing in voicemailEntry.lookupUri() is required
- // setIntent - allow video calling
- // setPrimaryText - check in with UX
- // setSecondaryText - check in with UX
- static HistoryItemPrimaryActionInfo fromVoicemailEntry(
- Context context, VoicemailEntry voicemailEntry) {
- return HistoryItemPrimaryActionInfo.builder()
+ static HistoryItemBottomSheetHeaderInfo fromVoicemailEntry(VoicemailEntry voicemailEntry) {
+ return HistoryItemBottomSheetHeaderInfo.newBuilder()
.setNumber(voicemailEntry.getNumber())
.setPhotoInfo(
NumberAttributesConverter.toPhotoInfoBuilder(voicemailEntry.getNumberAttributes())
.setFormattedNumber(voicemailEntry.getFormattedNumber())
.build())
- .setPrimaryText(buildPrimaryVoicemailText(context, voicemailEntry))
+ .setPrimaryText(buildPrimaryVoicemailText(voicemailEntry))
.setSecondaryText(buildSecondaryVoicemailText(voicemailEntry))
.build();
}
- private static CharSequence buildSecondaryVoicemailText(VoicemailEntry voicemailEntry) {
+ private static String buildSecondaryVoicemailText(VoicemailEntry voicemailEntry) {
return voicemailEntry.getGeocodedLocation();
}
- public static String buildPrimaryVoicemailText(Context context, VoicemailEntry data) {
+ private static String buildPrimaryVoicemailText(VoicemailEntry data) {
StringBuilder primaryText = new StringBuilder();
if (!TextUtils.isEmpty(data.getNumberAttributes().getName())) {
primaryText.append(data.getNumberAttributes().getName());
diff --git a/java/com/android/dialer/voicemail/listui/menu/NewVoicemailMenu.java b/java/com/android/dialer/voicemail/listui/menu/NewVoicemailMenu.java
index 7c669e194..7ec86c5b9 100644
--- a/java/com/android/dialer/voicemail/listui/menu/NewVoicemailMenu.java
+++ b/java/com/android/dialer/voicemail/listui/menu/NewVoicemailMenu.java
@@ -31,7 +31,7 @@ public final class NewVoicemailMenu {
return (view) ->
HistoryItemActionBottomSheet.show(
context,
- PrimaryAction.fromVoicemailEntry(context, voicemailEntry),
+ BottomSheetHeader.fromVoicemailEntry(voicemailEntry),
Modules.fromVoicemailEntry(context, voicemailEntry),
glidePhotoManager);
}