summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/voicemail
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2018-01-26 01:13:06 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2018-01-26 01:13:06 +0000
commit2684d0b9a258171cfc35c17bce7f6d23cead3172 (patch)
treebaf93cd9f4a45927d7ed5b4b547b29cf2489582e /java/com/android/dialer/voicemail
parentb9596e65467d9ad33efdfebb5ebc098207fda991 (diff)
parent923e186f97b3aeb67f4ddbb686e7c92336a7a4ef (diff)
Merge changes I5e589b2b,I821a700c
* changes: Prevent VvmNetworkRequestCallback from releasing twice By pass media player strict mode violation
Diffstat (limited to 'java/com/android/dialer/voicemail')
-rw-r--r--java/com/android/dialer/voicemail/listui/NewVoicemailMediaPlayer.java20
1 files changed, 18 insertions, 2 deletions
diff --git a/java/com/android/dialer/voicemail/listui/NewVoicemailMediaPlayer.java b/java/com/android/dialer/voicemail/listui/NewVoicemailMediaPlayer.java
index 48062a87d..519a0dfbd 100644
--- a/java/com/android/dialer/voicemail/listui/NewVoicemailMediaPlayer.java
+++ b/java/com/android/dialer/voicemail/listui/NewVoicemailMediaPlayer.java
@@ -26,6 +26,7 @@ import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
+import com.android.dialer.strictmode.StrictModeUtils;
import java.io.IOException;
/** A wrapper around {@link MediaPlayer} */
@@ -45,6 +46,7 @@ public class NewVoicemailMediaPlayer {
mediaPlayer = Assert.isNotNull(player);
}
+ // TODO(uabdullah): Consider removing the StrictModeUtils.bypass (a bug)
public void prepareMediaPlayerAndPlayVoicemailWhenReady(Context context, Uri uri)
throws IOException {
Assert.checkArgument(uri != null, "Media player cannot play a null uri");
@@ -57,9 +59,23 @@ public class NewVoicemailMediaPlayer {
voicemailUriLastPreparedOrPreparingToPlay = uri;
verifyListenersNotNull();
LogUtil.i("NewVoicemailMediaPlayer", "setData source");
- mediaPlayer.setDataSource(context, uri);
+ StrictModeUtils.bypass(
+ () -> {
+ try {
+ mediaPlayer.setDataSource(context, uri);
+ } catch (IOException e) {
+ LogUtil.i(
+ "NewVoicemailMediaPlayer",
+ "threw an Exception when setting datasource "
+ + e
+ + " for uri: "
+ + uri
+ + "for context : "
+ + context);
+ }
+ });
LogUtil.i("NewVoicemailMediaPlayer", "prepare async");
- mediaPlayer.prepareAsync();
+ StrictModeUtils.bypass(() -> mediaPlayer.prepareAsync());
} catch (IllegalStateException e) {
LogUtil.i(
"NewVoicemailMediaPlayer", "caught an IllegalStateException state exception : \n" + e);