diff options
| author | twyen <twyen@google.com> | 2018-01-24 16:48:49 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-piper@google.com> | 2018-01-24 19:09:39 -0800 |
| commit | 0874af841f7e23357ceb2bb8825180b111d613b4 (patch) | |
| tree | 23982c4a353490aa0a605b0e04b8656def2a3775 /java/com/android/dialer/voicemail | |
| parent | 2a422f719b70f6c292b954fb24f324b7f4ac1858 (diff) | |
Show Icon and label for blocked numbers
CallLogPhoto.getPhotoUri() returns a URI to a drawable so it will be easier to transition into glide. Meanwhile ContactPhotoManager will just show the drawable directly.
Bug: 70989547
Test: Unit tests
PiperOrigin-RevId: 183163818
Change-Id: I4ee4ff98782e35d2be03dfe14f8bf3dfd6ded074
Diffstat (limited to 'java/com/android/dialer/voicemail')
| -rw-r--r-- | java/com/android/dialer/voicemail/listui/NewVoicemailViewHolder.java | 4 | ||||
| -rw-r--r-- | java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/java/com/android/dialer/voicemail/listui/NewVoicemailViewHolder.java b/java/com/android/dialer/voicemail/listui/NewVoicemailViewHolder.java index 46e29956d..71c98031a 100644 --- a/java/com/android/dialer/voicemail/listui/NewVoicemailViewHolder.java +++ b/java/com/android/dialer/voicemail/listui/NewVoicemailViewHolder.java @@ -44,6 +44,7 @@ import com.android.dialer.common.concurrent.DialerExecutor.SuccessListener; import com.android.dialer.common.concurrent.DialerExecutor.Worker; import com.android.dialer.common.concurrent.DialerExecutorComponent; import com.android.dialer.contactphoto.ContactPhotoManager; +import com.android.dialer.contactphoto.NumberAttributeConverter; import com.android.dialer.lettertile.LetterTileDrawable; import com.android.dialer.time.Clock; import com.android.dialer.voicemail.listui.menu.NewVoicemailMenu; @@ -201,14 +202,13 @@ final class NewVoicemailViewHolder extends RecyclerView.ViewHolder implements On } } - // TODO(uabdullah): Consider/Implement TYPE (e.g Spam, TYPE_VOICEMAIL) private void setPhoto(VoicemailEntry voicemailEntry) { ContactPhotoManager.getInstance(context) .loadDialerThumbnailOrPhoto( quickContactBadge, parseUri(voicemailEntry.numberAttributes().getLookupUri()), voicemailEntry.numberAttributes().getPhotoId(), - parseUri(voicemailEntry.numberAttributes().getPhotoUri()), + NumberAttributeConverter.getPhotoUri(context, voicemailEntry.numberAttributes()), VoicemailEntryText.buildPrimaryVoicemailText(context, voicemailEntry), LetterTileDrawable.TYPE_DEFAULT); } diff --git a/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java b/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java index 7b8adfe30..ffc53e779 100644 --- a/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java +++ b/java/com/android/dialer/voicemail/listui/menu/PrimaryAction.java @@ -20,6 +20,7 @@ import android.content.Context; import android.text.TextUtils; import com.android.dialer.contactactions.ContactPrimaryActionInfo; import com.android.dialer.contactactions.ContactPrimaryActionInfo.PhotoInfo; +import com.android.dialer.contactphoto.NumberAttributeConverter; import com.android.dialer.lettertile.LetterTileDrawable; import com.android.dialer.voicemail.model.VoicemailEntry; @@ -39,7 +40,9 @@ final class PrimaryAction { .setPhotoInfo( PhotoInfo.builder() .setPhotoId(voicemailEntry.numberAttributes().getPhotoId()) - .setPhotoUri(voicemailEntry.numberAttributes().getPhotoUri()) + .setPhotoUri( + NumberAttributeConverter.getPhotoUri( + context, voicemailEntry.numberAttributes())) .setIsVideo(false) .setContactType( LetterTileDrawable.TYPE_DEFAULT) // TODO(uabdullah): Use proper type. |