diff options
| author | uabdullah <uabdullah@google.com> | 2017-10-17 17:36:08 -0700 |
|---|---|---|
| committer | Eric Erfanian <erfanian@google.com> | 2017-10-17 20:12:18 -0700 |
| commit | 78cc8ca990f3ce43252c038ad55420bebaeb4180 (patch) | |
| tree | 5cf5e19e868b65abc06f77af98b47aa1e0e835c7 /java/com/android/dialer/voicemail/listui | |
| parent | 70c1eb70ad1f8ba2e933328d2447382e82a8dd32 (diff) | |
Fix top text cropping issue in new voicemail tab
The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name.
Screenshot:
http://screen/uHCPwf5smVX
Bug: 64882313
Test: N/A
PiperOrigin-RevId: 172541833
Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
Diffstat (limited to 'java/com/android/dialer/voicemail/listui')
| -rw-r--r-- | java/com/android/dialer/voicemail/listui/NewVoicemailAdapter.java | 2 | ||||
| -rw-r--r-- | java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_entry.xml (renamed from java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_entry.xml) | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/java/com/android/dialer/voicemail/listui/NewVoicemailAdapter.java b/java/com/android/dialer/voicemail/listui/NewVoicemailAdapter.java index 71178ceba..d50be1ab6 100644 --- a/java/com/android/dialer/voicemail/listui/NewVoicemailAdapter.java +++ b/java/com/android/dialer/voicemail/listui/NewVoicemailAdapter.java @@ -35,7 +35,7 @@ final class NewVoicemailAdapter extends RecyclerView.Adapter<NewVoicemailViewHol @Override public NewVoicemailViewHolder onCreateViewHolder(ViewGroup viewGroup, int viewType) { LayoutInflater inflater = LayoutInflater.from(viewGroup.getContext()); - View view = inflater.inflate(R.layout.new_voicemail_call_log_entry, viewGroup, false); + View view = inflater.inflate(R.layout.new_voicemail_entry, viewGroup, false); NewVoicemailViewHolder newVoicemailViewHolder = new NewVoicemailViewHolder(view); return newVoicemailViewHolder; } diff --git a/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_entry.xml b/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_entry.xml index 82ccf88d2..bc1506751 100644 --- a/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_entry.xml +++ b/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_entry.xml @@ -21,6 +21,7 @@ android:layout_height="wrap_content" android:layout_marginTop="@dimen/call_log_entry_top_margin" android:paddingTop="@dimen/call_log_entry_padding_top_start" + android:paddingBottom="@dimen/call_log_entry_padding_bottom_end" android:paddingStart="@dimen/call_log_entry_padding_top_start" android:paddingEnd="@dimen/call_log_entry_padding_bottom_end" android:gravity="center_vertical"> @@ -29,7 +30,6 @@ android:id="@+id/quick_contact_photo" android:layout_width="@dimen/call_log_entry_photo_size" android:layout_height="@dimen/call_log_entry_photo_size" - android:layout_centerVertical="true" android:padding="@dimen/call_log_entry_photo_padding" android:focusable="true"/> @@ -41,7 +41,6 @@ android:layout_toStartOf="@+id/menu_button" android:orientation="vertical"> - <!--TODO(uabdullah): Resolve text clipping on top of primary text --> <TextView android:id="@+id/primary_text" style="@style/PrimaryText" @@ -78,6 +77,7 @@ style="@style/SecondaryText" android:layout_width="wrap_content" android:layout_height="wrap_content" + android:visibility="gone" android:layout_marginStart="@dimen/call_log_entry_photo_text_margin" android:layout_gravity="center_vertical"/> |