diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2018-06-29 01:14:29 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-06-29 01:14:29 +0000 |
commit | e479c7d417573ac142b336c904ce0643e010f7dd (patch) | |
tree | da969d7848ed5e86dc55858778fa912219c4be74 /java/com/android/dialer/speeddial | |
parent | 2e3e5ff3f2dfd4106b22835c1bf68bf551dcc032 (diff) | |
parent | 70c045940de7ca1270cad559229ae3d5e9273301 (diff) |
Merge changes I40cf6e7d,Iff515ae2,If8ca1f57,I1eec7a73,Iccb4e72c, ...
* changes:
Removed line deemed incompatible with Dialer open source.
Avoid updating system call log cache when the call log is being built
Make sure we have a host for the search fragment before loading data.
Fix scroll for new favorites
UI refresh for bottom nav bar.
UI refresh for FAB.
Use ConcurrentMap to log Contacts Provider metrics in the old call log.
Also ignore IllegalStateException thrown by SQLiteClosable when coalescing fails.
UI refresh for search fragment.
Add voicemail greeting setting screen to voicemail settings.
Diffstat (limited to 'java/com/android/dialer/speeddial')
3 files changed, 16 insertions, 5 deletions
diff --git a/java/com/android/dialer/speeddial/SpeedDialAdapter.java b/java/com/android/dialer/speeddial/SpeedDialAdapter.java index ff52a0745..4a48b6504 100644 --- a/java/com/android/dialer/speeddial/SpeedDialAdapter.java +++ b/java/com/android/dialer/speeddial/SpeedDialAdapter.java @@ -34,6 +34,7 @@ import android.widget.FrameLayout; import com.android.dialer.common.Assert; import com.android.dialer.speeddial.FavoritesViewHolder.FavoriteContactsListener; import com.android.dialer.speeddial.HeaderViewHolder.SpeedDialHeaderListener; +import com.android.dialer.speeddial.SpeedDialFragment.HostInterface; import com.android.dialer.speeddial.SuggestionViewHolder.SuggestedContactsListener; import com.android.dialer.speeddial.draghelper.SpeedDialItemTouchHelperCallback.ItemTouchHelperAdapter; import com.android.dialer.speeddial.loader.SpeedDialUiItem; @@ -81,6 +82,7 @@ public final class SpeedDialAdapter extends RecyclerView.Adapter<RecyclerView.Vi private final FavoriteContactsListener favoritesListener; private final SuggestedContactsListener suggestedListener; private final SpeedDialHeaderListener headerListener; + private final HostInterface hostInterface; private final Map<Integer, Integer> positionToRowTypeMap = new ArrayMap<>(); private List<SpeedDialUiItem> speedDialUiItems; @@ -95,11 +97,13 @@ public final class SpeedDialAdapter extends RecyclerView.Adapter<RecyclerView.Vi Context context, FavoriteContactsListener favoritesListener, SuggestedContactsListener suggestedListener, - SpeedDialHeaderListener headerListener) { + SpeedDialHeaderListener headerListener, + HostInterface hostInterface) { this.context = context; this.favoritesListener = favoritesListener; this.suggestedListener = suggestedListener; this.headerListener = headerListener; + this.hostInterface = hostInterface; } @Override @@ -255,6 +259,7 @@ public final class SpeedDialAdapter extends RecyclerView.Adapter<RecyclerView.Vi if (viewHolder != null) { draggingFavoritesViewHolder = (FavoritesViewHolder) viewHolder; draggingFavoritesViewHolder.onSelectedChanged(true); + hostInterface.dragFavorite(true); removeViewHolder.show(); } break; @@ -263,6 +268,7 @@ public final class SpeedDialAdapter extends RecyclerView.Adapter<RecyclerView.Vi if (draggingFavoritesViewHolder != null) { draggingFavoritesViewHolder.onSelectedChanged(false); draggingFavoritesViewHolder = null; + hostInterface.dragFavorite(false); removeViewHolder.hide(); } break; diff --git a/java/com/android/dialer/speeddial/SpeedDialFragment.java b/java/com/android/dialer/speeddial/SpeedDialFragment.java index a958d443a..d4e7a76fa 100644 --- a/java/com/android/dialer/speeddial/SpeedDialFragment.java +++ b/java/com/android/dialer/speeddial/SpeedDialFragment.java @@ -156,7 +156,12 @@ public class SpeedDialFragment extends Fragment { new UpdateSpeedDialAdapterListener(), speedDialLoaderListener); adapter = - new SpeedDialAdapter(getContext(), favoritesListener, suggestedListener, headerListener); + new SpeedDialAdapter( + getContext(), + favoritesListener, + suggestedListener, + headerListener, + FragmentUtils.getParentUnsafe(this, HostInterface.class)); layoutManager.setSpanSizeLookup(adapter.getSpanSizeLookup()); RecyclerView recyclerView = rootLayout.findViewById(R.id.speed_dial_recycler_view); recyclerView.setLayoutManager(layoutManager); @@ -653,5 +658,7 @@ public class SpeedDialFragment extends Fragment { public interface HostInterface { void setHasFrequents(boolean hasFrequents); + + void dragFavorite(boolean start); } } diff --git a/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml b/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml index 472f9e951..e79bc6b2f 100644 --- a/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml +++ b/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml @@ -17,9 +17,7 @@ <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" android:id="@+id/speed_dial_root" android:layout_width="match_parent" - android:layout_height="match_parent" - android:clipChildren="false" - android:clipToPadding="false"> + android:layout_height="match_parent"> <android.support.v7.widget.RecyclerView android:id="@+id/speed_dial_recycler_view" |