diff options
author | zachh <zachh@google.com> | 2017-10-24 17:10:06 -0700 |
---|---|---|
committer | Eric Erfanian <erfanian@google.com> | 2017-10-25 16:59:31 +0000 |
commit | 6a4cebdb4ccc974d04f125847c03fddec18b2b9f (patch) | |
tree | a1baaedfe7538758e2622ee2746a6487428db1e1 /java/com/android/dialer/simulator | |
parent | 35ec9146f0f44898f2249be3e505ff7bef171e11 (diff) |
Improved dagger support for executor services.
By always creating executor services via dagger, we can now bind special versions during espresso tests that can implement idling resources. We should be using idling resources during espresso tests for threads that we create ourselves, because espresso does not know about them.
Hopefully this reduces some of the flakiness of espresso tests that we have today.
This required converting all existing calls to DialerExecutors to pass a context used to fetch the component, and also required creating new application classes for espresso tests.
Test: temporarily added a task which just slept to DialtactsActivity and verified that its integration test failed due to idling resource timeout
PiperOrigin-RevId: 173334773
Change-Id: I876a93022d235d62cfc377bf5b06687e21a34758
Diffstat (limited to 'java/com/android/dialer/simulator')
-rw-r--r-- | java/com/android/dialer/simulator/impl/SimulatorMainMenu.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/java/com/android/dialer/simulator/impl/SimulatorMainMenu.java b/java/com/android/dialer/simulator/impl/SimulatorMainMenu.java index d663d584d..1a2cae18b 100644 --- a/java/com/android/dialer/simulator/impl/SimulatorMainMenu.java +++ b/java/com/android/dialer/simulator/impl/SimulatorMainMenu.java @@ -48,13 +48,13 @@ final class SimulatorMainMenu { } private static void populateDatabase(@NonNull Context context) { - DialerExecutors.createNonUiTaskBuilder(new PopulateDatabaseWorker()) + DialerExecutors.createNonUiTaskBuilder(context, new PopulateDatabaseWorker()) .build() .executeSerial(context); } private static void cleanDatabase(@NonNull Context context) { - DialerExecutors.createNonUiTaskBuilder(new CleanDatabaseWorker()) + DialerExecutors.createNonUiTaskBuilder(context, new CleanDatabaseWorker()) .build() .executeSerial(context); } @@ -65,7 +65,7 @@ final class SimulatorMainMenu { } private static void sharePersistentLog(@NonNull Context context) { - DialerExecutors.createNonUiTaskBuilder(new ShareLogWorker()) + DialerExecutors.createNonUiTaskBuilder(context, new ShareLogWorker()) .onSuccess( (String log) -> { Intent intent = new Intent(Intent.ACTION_SEND); |