diff options
| author | zachh <zachh@google.com> | 2017-11-09 11:52:13 -0800 |
|---|---|---|
| committer | zachh <zachh@google.com> | 2017-11-12 02:50:54 +0000 |
| commit | 3af5c6b002968a44b964d91cdca26056c3aaf8c3 (patch) | |
| tree | d077d6e5daec7e6b6d4c5c4cad2f12199082b9cc /java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java | |
| parent | 8c47d75d9a128db66faf1e824f628ed5a1a87723 (diff) | |
Filter out contacts with null primary display names in search.
Bug: 68848807
Test: unit
PiperOrigin-RevId: 175190786
Change-Id: I15b525951cb87afb8b48f3bdb2174605c94c99cf
Diffstat (limited to 'java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java')
| -rw-r--r-- | java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java b/java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java index 35518019e..2b7af1131 100644 --- a/java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java +++ b/java/com/android/dialer/searchfragment/cp2/SearchContactsCursorLoader.java @@ -43,9 +43,20 @@ public final class SearchContactsCursorLoader extends CursorLoader { this.query = query; } + /** + * Note: ContactsProvider can make no guarantee that any given field is non-null, and display name + * has been observed to be null in the wild, though it is unclear when that might happen (possibly + * a third-party is inserting such data). See a bug. + * + * <p>We skip showing contacts without a display name because there is no UI treatment for showing + * such results. (Note that even contacts with only a number still have a display name set to the + * number.) + */ private static String whereStatement() { return (Phone.NUMBER + " IS NOT NULL") + " AND " + + (Data.DISPLAY_NAME_PRIMARY + " IS NOT NULL") + + " AND " + Data.MIMETYPE + " IN (\'" + Phone.CONTENT_ITEM_TYPE |