summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/precall
diff options
context:
space:
mode:
authortwyen <twyen@google.com>2017-11-22 15:05:45 -0800
committerCopybara-Service <copybara-piper@google.com>2017-11-22 16:29:18 -0800
commit572a77ed339b5a511f9dc20680939dbb7bf5e085 (patch)
tree864af958509967249c92a2c0196a51ed66482574 /java/com/android/dialer/precall
parente30d7d2e533f830ee638b1a727e537880b18bf66 (diff)
Automated rollback of changelist 176587256
Bug: 69570769 Test: CallingAccountSelectorTest PiperOrigin-RevId: 176706378 Change-Id: I50da0d2dd40a83ae6c1189fed2693368369849d3
Diffstat (limited to 'java/com/android/dialer/precall')
-rw-r--r--java/com/android/dialer/precall/impl/AndroidManifest.xml1
-rw-r--r--java/com/android/dialer/precall/impl/CallingAccountSelector.java24
-rw-r--r--java/com/android/dialer/precall/impl/PreCallActivity.java2
-rw-r--r--java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java2
4 files changed, 11 insertions, 18 deletions
diff --git a/java/com/android/dialer/precall/impl/AndroidManifest.xml b/java/com/android/dialer/precall/impl/AndroidManifest.xml
index b960f6bad..d3d0f538d 100644
--- a/java/com/android/dialer/precall/impl/AndroidManifest.xml
+++ b/java/com/android/dialer/precall/impl/AndroidManifest.xml
@@ -23,7 +23,6 @@
android:name="com.android.dialer.precall.impl.PreCallActivity"
android:excludeFromRecents="true"
android:noHistory="true"
- android:showWhenLocked="true"
android:theme="@style/Theme.PreCall.DialogHolder">
</activity>
</application>
diff --git a/java/com/android/dialer/precall/impl/CallingAccountSelector.java b/java/com/android/dialer/precall/impl/CallingAccountSelector.java
index 8d3df2360..4308df73a 100644
--- a/java/com/android/dialer/precall/impl/CallingAccountSelector.java
+++ b/java/com/android/dialer/precall/impl/CallingAccountSelector.java
@@ -127,12 +127,12 @@ public class CallingAccountSelector implements PreCallAction {
PendingAction pendingAction = coordinator.startPendingAction();
DialerExecutorComponent.get(coordinator.getActivity())
.dialerExecutorFactory()
- .createNonUiTaskBuilder(new PreferredAccountWorker(phoneNumber))
+ .createUiTaskBuilder(
+ activity.getFragmentManager(),
+ "PreferredAccountWorker",
+ new PreferredAccountWorker(phoneNumber))
.onSuccess(
(result -> {
- if (isDiscarding) {
- return;
- }
if (result.phoneAccountHandle.isPresent()) {
coordinator.getBuilder().setPhoneAccountHandle(result.phoneAccountHandle.get());
pendingAction.finish();
@@ -221,9 +221,7 @@ public class CallingAccountSelector implements PreCallAction {
@Override
public void onDiscard() {
isDiscarding = true;
- if (selectPhoneAccountDialogFragment != null) {
- selectPhoneAccountDialogFragment.dismiss();
- }
+ selectPhoneAccountDialogFragment.dismiss();
}
private static class PreferredAccountWorkerResult {
@@ -366,13 +364,11 @@ public class CallingAccountSelector implements PreCallAction {
new WritePreferredAccountWorkerInput(
coordinator.getActivity(), dataId, selectedAccountHandle));
}
- if (number != null) {
- DialerExecutorComponent.get(coordinator.getActivity())
- .dialerExecutorFactory()
- .createNonUiTaskBuilder(new UserSelectionReporter(selectedAccountHandle, number))
- .build()
- .executeParallel(coordinator.getActivity());
- }
+ DialerExecutorComponent.get(coordinator.getActivity())
+ .dialerExecutorFactory()
+ .createNonUiTaskBuilder(new UserSelectionReporter(selectedAccountHandle, number))
+ .build()
+ .executeParallel(coordinator.getActivity());
listener.finish();
}
diff --git a/java/com/android/dialer/precall/impl/PreCallActivity.java b/java/com/android/dialer/precall/impl/PreCallActivity.java
index eadba2b11..938d31d5f 100644
--- a/java/com/android/dialer/precall/impl/PreCallActivity.java
+++ b/java/com/android/dialer/precall/impl/PreCallActivity.java
@@ -19,7 +19,6 @@ package com.android.dialer.precall.impl;
import android.app.Activity;
import android.os.Bundle;
import android.support.annotation.Nullable;
-import android.view.WindowManager.LayoutParams;
/** A transparent activity to host dialogs for {@link PreCallCoordinatorImpl} */
public class PreCallActivity extends Activity {
@@ -31,7 +30,6 @@ public class PreCallActivity extends Activity {
super.onCreate(savedInstanceState);
preCallCoordinator = new PreCallCoordinatorImpl(this);
preCallCoordinator.onCreate(getIntent(), savedInstanceState);
- getWindow().addFlags(LayoutParams.FLAG_SHOW_WHEN_LOCKED);
}
@Override
diff --git a/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java b/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
index 94ba90d75..de32cc2ae 100644
--- a/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
+++ b/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
@@ -59,6 +59,7 @@ public class PreCallCoordinatorImpl implements PreCallCoordinator {
} else {
builder = Assert.isNotNull(intent.getParcelableExtra(EXTRA_CALL_INTENT_BUILDER));
}
+ actions = PreCallComponent.get(activity).getPreCall().getActions();
}
void onRestoreInstanceState(Bundle savedInstanceState) {
@@ -67,7 +68,6 @@ public class PreCallCoordinatorImpl implements PreCallCoordinator {
}
void onResume() {
- actions = PreCallComponent.get(activity).getPreCall().getActions();
runNextAction();
}