summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/precall
diff options
context:
space:
mode:
authortwyen <twyen@google.com>2017-11-07 15:39:15 -0800
committerzachh <zachh@google.com>2017-11-11 23:15:49 +0000
commit0efc840171da8739359b326249978d0a44df540b (patch)
tree238f87ae39ac404331e96a8cbf138e333cb73afa /java/com/android/dialer/precall
parent73d995ff88b3a8894c7463a21a24dcec3f8d68e4 (diff)
Hook up pre-call actions
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction. Bug: 64216442 Test: manual PiperOrigin-RevId: 174924323 Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
Diffstat (limited to 'java/com/android/dialer/precall')
-rw-r--r--java/com/android/dialer/precall/PreCall.java9
-rw-r--r--java/com/android/dialer/precall/PreCallCoordinator.java3
-rw-r--r--java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java2
-rw-r--r--java/com/android/dialer/precall/impl/PreCallImpl.java3
4 files changed, 14 insertions, 3 deletions
diff --git a/java/com/android/dialer/precall/PreCall.java b/java/com/android/dialer/precall/PreCall.java
index 93fd8e9b6..4f021f142 100644
--- a/java/com/android/dialer/precall/PreCall.java
+++ b/java/com/android/dialer/precall/PreCall.java
@@ -21,6 +21,7 @@ import android.content.Intent;
import android.support.annotation.MainThread;
import android.support.annotation.NonNull;
import com.android.dialer.callintent.CallIntentBuilder;
+import com.android.dialer.util.DialerUtils;
import com.google.common.collect.ImmutableList;
/** Interface to prepare a {@link CallIntentBuilder} before placing the call with telecom. */
@@ -41,4 +42,12 @@ public interface PreCall {
@NonNull
@MainThread
Intent buildIntent(Context context, CallIntentBuilder builder);
+
+ static Intent getIntent(Context context, CallIntentBuilder builder) {
+ return PreCallComponent.get(context).getPreCall().buildIntent(context, builder);
+ }
+
+ static void start(Context context, CallIntentBuilder builder) {
+ DialerUtils.startActivityWithErrorToast(context, getIntent(context, builder));
+ }
}
diff --git a/java/com/android/dialer/precall/PreCallCoordinator.java b/java/com/android/dialer/precall/PreCallCoordinator.java
index b5e9e8594..40b909a51 100644
--- a/java/com/android/dialer/precall/PreCallCoordinator.java
+++ b/java/com/android/dialer/precall/PreCallCoordinator.java
@@ -19,6 +19,7 @@ package com.android.dialer.precall;
import android.app.Activity;
import android.support.annotation.MainThread;
import android.support.annotation.NonNull;
+import android.support.annotation.VisibleForTesting;
import com.android.dialer.callintent.CallIntentBuilder;
/**
@@ -27,6 +28,8 @@ import com.android.dialer.callintent.CallIntentBuilder;
*/
public interface PreCallCoordinator {
+ @VisibleForTesting public String EXTRA_CALL_INTENT_BUILDER = "extra_call_intent_builder";
+
@NonNull
CallIntentBuilder getBuilder();
diff --git a/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java b/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
index 25083ef0b..6302a2395 100644
--- a/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
+++ b/java/com/android/dialer/precall/impl/PreCallCoordinatorImpl.java
@@ -38,8 +38,6 @@ public class PreCallCoordinatorImpl implements PreCallCoordinator {
private static final String SAVED_STATE_CURRENT_ACTION = "current_action";
- static final String EXTRA_CALL_INTENT_BUILDER = "extra_call_intent_builder";
-
@NonNull private final Activity activity;
private CallIntentBuilder builder;
diff --git a/java/com/android/dialer/precall/impl/PreCallImpl.java b/java/com/android/dialer/precall/impl/PreCallImpl.java
index fc2eff8b1..21c5dc9e2 100644
--- a/java/com/android/dialer/precall/impl/PreCallImpl.java
+++ b/java/com/android/dialer/precall/impl/PreCallImpl.java
@@ -22,6 +22,7 @@ import android.support.annotation.NonNull;
import com.android.dialer.callintent.CallIntentBuilder;
import com.android.dialer.precall.PreCall;
import com.android.dialer.precall.PreCallAction;
+import com.android.dialer.precall.PreCallCoordinator;
import com.google.common.collect.ImmutableList;
import javax.inject.Inject;
@@ -40,7 +41,7 @@ public class PreCallImpl implements PreCall {
@Override
public Intent buildIntent(Context context, CallIntentBuilder builder) {
Intent intent = new Intent(context, PreCallActivity.class);
- intent.putExtra(PreCallCoordinatorImpl.EXTRA_CALL_INTENT_BUILDER, builder);
+ intent.putExtra(PreCallCoordinator.EXTRA_CALL_INTENT_BUILDER, builder);
return intent;
}
}