diff options
author | twyen <twyen@google.com> | 2018-05-15 11:01:52 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-05-15 11:18:35 -0700 |
commit | c97a895e19d09707f54533f8985542caf2b0a17b (patch) | |
tree | 0f02b80ae68104a54e64ca8a443611606e2e7ec8 /java/com/android/dialer/precall/PreCallAction.java | |
parent | 3e2c6b8c22b238c3f3b1d9786a045f0a20615fa0 (diff) |
Use new instances of PreCallAction on activity resume
Previously the same action instance is used every time the PreCallActivity is resumed. This causes some state to be retain, for example the isDiscarding state on CallingAccountSelector prevents canceling the next dialog to abort the call.
Actions should not retain state between activity life cycles.
TEST=TAP
Bug: 79692264
Test: TAP
PiperOrigin-RevId: 196696224
Change-Id: Ifa604f431563dd1fb123a42e2a64b34c001e897d
Diffstat (limited to 'java/com/android/dialer/precall/PreCallAction.java')
-rw-r--r-- | java/com/android/dialer/precall/PreCallAction.java | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/java/com/android/dialer/precall/PreCallAction.java b/java/com/android/dialer/precall/PreCallAction.java index 9ddc6f205..298af08ee 100644 --- a/java/com/android/dialer/precall/PreCallAction.java +++ b/java/com/android/dialer/precall/PreCallAction.java @@ -25,6 +25,9 @@ import com.android.dialer.callintent.CallIntentBuilder; * CallIntentBuilder} to generate full information for the call. For example, showing a dialog to * select the phone account on a multi-SIM device, ask if RTT should be enabled, or rewrite the * number for roaming calls. + * + * <p>UI actions are discarded when the hosting activity is paused. A new instance of the action + * will be created once the activity is resumed again. */ public interface PreCallAction { |