summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/phonenumberproto/PartitionedNumbers.java
diff options
context:
space:
mode:
authorzachh <zachh@google.com>2018-01-26 16:28:44 -0800
committerCopybara-Service <copybara-piper@google.com>2018-01-26 16:30:20 -0800
commit26f520249eccdcf2352806ba8d6a54bb8e5045a6 (patch)
treeb49fe3352268663ae05c447f0f088ccdc9df585b /java/com/android/dialer/phonenumberproto/PartitionedNumbers.java
parent29be3926b41f09a7f8fab9845ce3d0d7bd216620 (diff)
Reworked the internals of DialerPhoneNumber.
It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code. Bug: 72563861 Test: existing PiperOrigin-RevId: 183463907 Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3
Diffstat (limited to 'java/com/android/dialer/phonenumberproto/PartitionedNumbers.java')
-rw-r--r--java/com/android/dialer/phonenumberproto/PartitionedNumbers.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/java/com/android/dialer/phonenumberproto/PartitionedNumbers.java b/java/com/android/dialer/phonenumberproto/PartitionedNumbers.java
index 0a4aafaf7..dbf99365c 100644
--- a/java/com/android/dialer/phonenumberproto/PartitionedNumbers.java
+++ b/java/com/android/dialer/phonenumberproto/PartitionedNumbers.java
@@ -70,7 +70,7 @@ public final class PartitionedNumbers {
}
currentNumbers.add(dialerPhoneNumber);
} else {
- String invalidNumber = dialerPhoneNumber.getRawInput().getNumber();
+ String invalidNumber = dialerPhoneNumber.getNormalizedNumber();
Set<DialerPhoneNumber> currentNumbers = invalidMapBuilder.get(invalidNumber);
if (currentNumbers == null) {
currentNumbers = new ArraySet<>();
@@ -85,7 +85,7 @@ public final class PartitionedNumbers {
}
private boolean hasPostDialDigits(DialerPhoneNumber dialerPhoneNumber) {
- return !PhoneNumberUtils.extractPostDialPortion(dialerPhoneNumber.getRawInput().getNumber())
+ return !PhoneNumberUtils.extractPostDialPortion(dialerPhoneNumber.getNormalizedNumber())
.isEmpty();
}