summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/phonenumbercache
diff options
context:
space:
mode:
authorlinyuh <linyuh@google.com>2017-12-12 14:30:08 -0800
committerCopybara-Service <copybara-piper@google.com>2017-12-12 16:15:08 -0800
commitbdef88bb0c16889e7403c117ce90825f7ed7b9e4 (patch)
tree6723a7f9ef8d08b6e8f51db6d7a49b8b0f608538 /java/com/android/dialer/phonenumbercache
parent888e6b1499f7be68f2d33f870a57cd7e2a58dd93 (diff)
BEGIN_PUBLIC
Automated rollback of changelist 172505648 Bug: 30225112 Test: None PiperOrigin-RevId: 178815682 Change-Id: I1fe1eef49d587314d32e7125f5106769b3099ad3
Diffstat (limited to 'java/com/android/dialer/phonenumbercache')
-rw-r--r--java/com/android/dialer/phonenumbercache/ContactInfoHelper.java36
1 files changed, 18 insertions, 18 deletions
diff --git a/java/com/android/dialer/phonenumbercache/ContactInfoHelper.java b/java/com/android/dialer/phonenumbercache/ContactInfoHelper.java
index 8e08fb20d..c3f5b692f 100644
--- a/java/com/android/dialer/phonenumbercache/ContactInfoHelper.java
+++ b/java/com/android/dialer/phonenumbercache/ContactInfoHelper.java
@@ -337,30 +337,30 @@ public class ContactInfoHelper {
return ContactInfo.EMPTY;
}
- try (Cursor phoneLookupCursor =
- mContext
- .getContentResolver()
- .query(uri, PhoneQuery.getPhoneLookupProjection(uri), null, null, null)) {
- if (phoneLookupCursor == null) {
- LogUtil.d("ContactInfoHelper.lookupContactFromUri", "phoneLookupCursor is null");
- return null;
- }
+ Cursor phoneLookupCursor = null;
+ try {
+ String[] projection = PhoneQuery.getPhoneLookupProjection(uri);
+ phoneLookupCursor = mContext.getContentResolver().query(uri, projection, null, null, null);
+ } catch (NullPointerException e) {
+ LogUtil.e("ContactInfoHelper.lookupContactFromUri", "phone lookup", e);
+ // Trap NPE from pre-N CP2
+ return null;
+ }
+ if (phoneLookupCursor == null) {
+ LogUtil.d("ContactInfoHelper.lookupContactFromUri", "phoneLookupCursor is null");
+ return null;
+ }
+ try {
if (!phoneLookupCursor.moveToFirst()) {
return ContactInfo.EMPTY;
}
-
- Cursor matchedCursor =
- PhoneNumberHelper.getCursorMatchForContactLookupUri(
- phoneLookupCursor, PhoneQuery.MATCHED_NUMBER, uri);
- if (matchedCursor == null) {
- return ContactInfo.EMPTY;
- }
-
- String lookupKey = matchedCursor.getString(PhoneQuery.LOOKUP_KEY);
- ContactInfo contactInfo = createPhoneLookupContactInfo(matchedCursor, lookupKey);
+ String lookupKey = phoneLookupCursor.getString(PhoneQuery.LOOKUP_KEY);
+ ContactInfo contactInfo = createPhoneLookupContactInfo(phoneLookupCursor, lookupKey);
fillAdditionalContactInfo(mContext, contactInfo);
return contactInfo;
+ } finally {
+ phoneLookupCursor.close();
}
}