summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/logging
diff options
context:
space:
mode:
authoruabdullah <uabdullah@google.com>2018-03-16 17:32:54 -0700
committerCopybara-Service <copybara-piper@google.com>2018-03-16 17:39:34 -0700
commita7530f84656f1060957b14a4c946fd02cf88f7cd (patch)
tree6131ce961e48b0c971abb8c9ef5977cbb0d588f0 /java/com/android/dialer/logging
parentfce3a793a925791b6ed22d8132db55cd6d7d3f15 (diff)
Refactor VM Settings and add support for voicemail transcription
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following: - ensuring that when the VVM toggle is turned off, transcription and donations are gone. - when transcription is off, donation preference is gone. - donation is only available when transcription is available and enabled - as part of the refactor, fixes existing logging bugs - breaks preferences and its associated methods into helper methods when possible - groups relevant preferences together when possible Bug: 74033229 Test: Unit tests PiperOrigin-RevId: 189418217 Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
Diffstat (limited to 'java/com/android/dialer/logging')
-rw-r--r--java/com/android/dialer/logging/dialer_impression.proto16
1 files changed, 10 insertions, 6 deletions
diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto
index c657768df..96ca9c6be 100644
--- a/java/com/android/dialer/logging/dialer_impression.proto
+++ b/java/com/android/dialer/logging/dialer_impression.proto
@@ -12,7 +12,7 @@ message DialerImpression {
// Event enums to be used for Impression Logging in Dialer.
// It's perfectly acceptable for this enum to be large
// Values should be from 1000 to 100000.
- // Next Tag: 1361
+ // Next Tag: 1366
enum Type {
UNKNOWN_AOSP_EVENT_TYPE = 1000;
@@ -372,7 +372,7 @@ message DialerImpression {
VVM_SETTINGS_VIEWED = 1148;
VVM_CHANGE_PIN_CLICKED = 1149;
VVM_CHANGE_PIN_COMPLETED = 1150;
- VVM_CHANGE_RINGTONE_CLICKED = 1151;
+ VVM_CHANGE_RINGTONE_CLICKED = 1151 [deprecated = true];
VVM_CHANGE_VIBRATION_CLICKED = 1152;
VVM_USER_ENABLED_IN_SETTINGS = 1153;
VVM_USER_DISABLED_IN_SETTINGS = 1154;
@@ -594,14 +594,12 @@ message DialerImpression {
ASSISTED_DIALING_FEATURE_DISABLED_BY_USER = 1292;
// User reports a same prefix call as spam from call history
- REPORT_SAME_PREFIX_CALL_AS_SPAM_VIA_CALL_HISTORY =
- 1290
+ REPORT_SAME_PREFIX_CALL_AS_SPAM_VIA_CALL_HISTORY = 1290
;
// User reports a same prefix call as not spam from call history
- REPORT_SAME_PREFIX_CALL_AS_NOT_SPAM_VIA_CALL_HISTORY =
- 1291
+ REPORT_SAME_PREFIX_CALL_AS_NOT_SPAM_VIA_CALL_HISTORY = 1291
;
@@ -715,5 +713,11 @@ message DialerImpression {
SPAM_BLOCKING_DISABLED_THROUGH_SETTING = 1359;
// Failure happened while modifying spam blocking setting.
SPAM_BLOCKING_MODIFY_FAILURE_THROUGH_SETTING = 1360;
+
+ VVM_NOTIFICATIONS_SETTING_CLICKED = 1361;
+ VVM_USER_TURNED_TRANSCRIBE_ON_FROM_SETTINGS = 1362;
+ VVM_USER_TURNED_TRANSCRIBE_OFF_FROM_SETTINGS = 1363;
+ VVM_USER_TURNED_DONATION_ON_FROM_SETTINGS = 1364;
+ VVM_USER_TURNED_DONATION_OFF_FROM_SETTINGS = 1365;
}
}