diff options
| author | mdooley <mdooley@google.com> | 2017-09-05 12:48:03 -0700 |
|---|---|---|
| committer | Eric Erfanian <erfanian@google.com> | 2017-09-11 10:57:47 -0700 |
| commit | 9abbf7ff9b31dd3420fd2b304b63703b87d843f6 (patch) | |
| tree | e69118e3b35ea6407d96ad4db3e6686efcc64ca8 /java/com/android/dialer/logging | |
| parent | 2928203107c971ff8129f57addddb6b8fa19e065 (diff) | |
Fixing transcription crashes caused by job stoppage
Apparently, scheduling a new job when one is already running (even using the enqueue api) causes the running job to be stopped. We weren't handling that case correctly. This cl makes sure no more work is attempted after a job is stopped by cancelling any
active transcription task. We request that stopped task be rescheduled by the job scheduler, so it will get run eventually.
I was able to verify this fix by sending a new voicemail while backfill old transcription tasks were running.
Bug: 64908823,63524274,65129734,63803709
Test: manual and unit tests
PiperOrigin-RevId: 167617191
Change-Id: Icc92997c2687e61bef9b3b7f9ff572da2cb4ed2e
Diffstat (limited to 'java/com/android/dialer/logging')
| -rw-r--r-- | java/com/android/dialer/logging/dialer_impression.proto | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto index ef249c262..94af6c3fd 100644 --- a/java/com/android/dialer/logging/dialer_impression.proto +++ b/java/com/android/dialer/logging/dialer_impression.proto @@ -530,5 +530,9 @@ message DialerImpression { IN_CALL_DIALPAD_NUMBER_BUTTON_PRESSED = 1265; IN_CALL_DIALPAD_HANG_UP_BUTTON_PRESSED = 1266; IN_CALL_DIALPAD_CLOSE_BUTTON_PRESSED = 1267; + + // More voicemail transcription impressions + VVM_TRANSCRIPTION_JOB_STOPPED = 1268; + VVM_TRANSCRIPTION_TASK_CANCELLED = 1269; } } |