diff options
| author | yueg <yueg@google.com> | 2017-07-27 16:12:55 -0700 |
|---|---|---|
| committer | Eric Erfanian <erfanian@google.com> | 2017-07-28 07:00:22 -0700 |
| commit | a48f3c4bd2581c884e4668d3f4a47b7b374900ee (patch) | |
| tree | 8b6a40bb7bf53a1ea29d1ec66f62cdcfb70b4448 /java/com/android/dialer/logging/LoggingBindings.java | |
| parent | a3cf088f9c1a8be5737472efe2966bca23ef4394 (diff) | |
Fix NPE and ClassCastException in logging People API lookup error.
Logger.get() returns a LoggingBindingsStub object instead of a
LoggingBindingsImpl object under strict mode, and we should not log when it
happens.
WANT_LGTM=kedars
LOG_STORAGE_INCREASE(GB/week): 0
Test: manual
PiperOrigin-RevId: 163404058
Change-Id: Ibd466a811126c45eb26bc033367cc86a77066b3f
Diffstat (limited to 'java/com/android/dialer/logging/LoggingBindings.java')
| -rw-r--r-- | java/com/android/dialer/logging/LoggingBindings.java | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/java/com/android/dialer/logging/LoggingBindings.java b/java/com/android/dialer/logging/LoggingBindings.java index 85ccfdfa1..ca9a0533e 100644 --- a/java/com/android/dialer/logging/LoggingBindings.java +++ b/java/com/android/dialer/logging/LoggingBindings.java @@ -80,4 +80,11 @@ public interface LoggingBindings { QuickContactBadge quickContact, InteractionEvent.Type interactionEvent, boolean shouldPerformClick); + + /** Logs People Api lookup result with error */ + void logPeopleApiLookupReportWithError( + long latency, int httpResponseCode, PeopleApiLookupError.Type errorType); + + /** Logs successful People Api lookup result */ + void logSuccessfulPeopleApiLookupReport(long latency, int httpResponseCode); } |