diff options
| author | zachh <zachh@google.com> | 2018-01-26 16:28:44 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-piper@google.com> | 2018-01-26 16:30:20 -0800 |
| commit | 26f520249eccdcf2352806ba8d6a54bb8e5045a6 (patch) | |
| tree | b49fe3352268663ae05c447f0f088ccdc9df585b /java/com/android/dialer/calllogutils | |
| parent | 29be3926b41f09a7f8fab9845ce3d0d7bd216620 (diff) | |
Reworked the internals of DialerPhoneNumber.
It turns out the storing the libphonenumber representation of the number is not particularly useful because even formatting these objects cannot be done on the main thread. Rather than propagate the requirement of using PhoneNumberUtil (and background threads by extension) in the call log UI, we now just store a dialer-normalized version of the number which contains all information required by the UI in a way that allows us to avoid any background work in the UI code.
Bug: 72563861
Test: existing
PiperOrigin-RevId: 183463907
Change-Id: I4bdadaccb7a84033b3c72c54fe3833064f587ee3
Diffstat (limited to 'java/com/android/dialer/calllogutils')
| -rw-r--r-- | java/com/android/dialer/calllogutils/CallLogIntents.java | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/java/com/android/dialer/calllogutils/CallLogIntents.java b/java/com/android/dialer/calllogutils/CallLogIntents.java index 227b15eed..64fb33d13 100644 --- a/java/com/android/dialer/calllogutils/CallLogIntents.java +++ b/java/com/android/dialer/calllogutils/CallLogIntents.java @@ -39,8 +39,7 @@ public final class CallLogIntents { */ @Nullable public static Intent getCallBackIntent(Context context, CoalescedRow row) { - // TODO(zachh): Don't use raw input. - String normalizedNumber = row.number().getRawInput().getNumber(); + String normalizedNumber = row.number().getNormalizedNumber(); if (!PhoneNumberHelper.canPlaceCallsTo(normalizedNumber, row.numberPresentation())) { return null; } |