diff options
| author | uabdullah <uabdullah@google.com> | 2017-08-09 12:10:24 -0700 |
|---|---|---|
| committer | Eric Erfanian <erfanian@google.com> | 2017-08-09 17:35:13 -0700 |
| commit | fe82fb8da514f490a785d836cd61f2b7d5622e3e (patch) | |
| tree | 8f3e807466ca7eac10f2f2221cc15870fe77d1dd /java/com/android/dialer/backup | |
| parent | ddf3b1f450279cba46d690ebd78617cc6c62d308 (diff) | |
Add logging to Dialer Key/Value backup implemenation.
For Dolly our logging proved to be immensely valuable tool to identify the the framework bug. We were able to co-relate the issue with the backup and restore logging. We are adding this again for Key Value backup and restore.
Bug: 64363054
Test: DialerPersistentBackupAgentTest
PiperOrigin-RevId: 164754911
Change-Id: I15f97e1a2301703ced85df8f808cf20aae59c25e
Diffstat (limited to 'java/com/android/dialer/backup')
| -rw-r--r-- | java/com/android/dialer/backup/DialerPersistentBackupAgent.java | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/java/com/android/dialer/backup/DialerPersistentBackupAgent.java b/java/com/android/dialer/backup/DialerPersistentBackupAgent.java index dfe4ea301..085c3433e 100644 --- a/java/com/android/dialer/backup/DialerPersistentBackupAgent.java +++ b/java/com/android/dialer/backup/DialerPersistentBackupAgent.java @@ -23,6 +23,8 @@ import android.support.annotation.VisibleForTesting; import android.util.ArrayMap; import com.android.dialer.common.Assert; import com.android.dialer.common.LogUtil; +import com.android.dialer.logging.DialerImpression; +import com.android.dialer.logging.Logger; import com.google.android.libraries.backup.BackupKeyPredicate; import com.google.android.libraries.backup.BackupKeyPredicates; import com.google.android.libraries.backup.PersistentBackupAgentHelper; @@ -39,6 +41,7 @@ public class DialerPersistentBackupAgent extends PersistentBackupAgentHelper { @VisibleForTesting(otherwise = VisibleForTesting.NONE) DialerPersistentBackupAgent(@NonNull String sharedPreferenceName) { this.sharedPrefsName = Assert.isNotNull(sharedPreferenceName); + Logger.get(this).logImpression(DialerImpression.Type.BACKUP_KEY_VALUE_BACKUP_AGENT_CONSTRUCTOR); } public DialerPersistentBackupAgent() { @@ -48,6 +51,7 @@ public class DialerPersistentBackupAgent extends PersistentBackupAgentHelper { @Override public void onRestore(BackupDataInput data, int appVersionCode, ParcelFileDescriptor stateFile) throws IOException { + Logger.get(this).logImpression(DialerImpression.Type.BACKUP_KEY_VALUE_ON_RESTORE); LogUtil.i("DialerPersistentBackupAgent.onRestore", "restore from version: " + appVersionCode); super.onRestore(data, appVersionCode, stateFile); } @@ -56,12 +60,14 @@ public class DialerPersistentBackupAgent extends PersistentBackupAgentHelper { public void onBackup( ParcelFileDescriptor oldState, BackupDataOutput data, ParcelFileDescriptor newState) throws IOException { + Logger.get(this).logImpression(DialerImpression.Type.BACKUP_KEY_VALUE_ON_BACKUP); LogUtil.i("DialerPersistentBackupAgent.onBackup", "onBackup being performed"); super.onBackup(oldState, data, newState); } @Override public Map<String, BackupKeyPredicate> getBackupSpecification() { + Logger.get(this).logImpression(DialerImpression.Type.BACKUP_KEY_VALUE_GET_BACKUP_SPECIFICATION); LogUtil.i( "DialerPersistentBackupAgent.getBackupSpecification", "file being backed up: " + sharedPrefsName); @@ -69,4 +75,10 @@ public class DialerPersistentBackupAgent extends PersistentBackupAgentHelper { backupSpecification.put(sharedPrefsName, BackupKeyPredicates.alwaysTrue()); return backupSpecification; } + + @Override + public void onRestoreFinished() { + Logger.get(this).logImpression(DialerImpression.Type.BACKUP_KEY_VALUE_ON_RESTORE_FINISHED); + super.onRestoreFinished(); + } } |