summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/app
diff options
context:
space:
mode:
authorcalderwoodra <calderwoodra@google.com>2018-04-06 12:30:47 -0700
committerCopybara-Service <copybara-piper@google.com>2018-04-06 16:35:34 -0700
commit7c4d9bb81e738698ff5fd2392c62b547190fc7d9 (patch)
treed610853faa402cbd3d6f0ce514ea0ed8b794c513 /java/com/android/dialer/app
parent23ef36ff6dfd2fdb47f6ec8bb6928e4e40e11fa5 (diff)
Convert new speed dial to support fragment and add it to new peer.
Bug: 36841782 Test: MainActivityNewPeerTest PiperOrigin-RevId: 191924314 Change-Id: I5e4a4adadd5477115d6b4daf8afb8c6f819496c8
Diffstat (limited to 'java/com/android/dialer/app')
-rw-r--r--java/com/android/dialer/app/list/DialtactsPagerAdapter.java24
-rw-r--r--java/com/android/dialer/app/list/ListsFragment.java11
2 files changed, 8 insertions, 27 deletions
diff --git a/java/com/android/dialer/app/list/DialtactsPagerAdapter.java b/java/com/android/dialer/app/list/DialtactsPagerAdapter.java
index 364ae6fad..317f24fef 100644
--- a/java/com/android/dialer/app/list/DialtactsPagerAdapter.java
+++ b/java/com/android/dialer/app/list/DialtactsPagerAdapter.java
@@ -18,7 +18,6 @@ package com.android.dialer.app.list;
import android.app.Fragment;
import android.app.FragmentManager;
-import android.content.Context;
import android.support.annotation.IntDef;
import android.support.v13.app.FragmentPagerAdapter;
import android.view.ViewGroup;
@@ -26,11 +25,9 @@ import com.android.dialer.app.calllog.CallLogFragment;
import com.android.dialer.app.calllog.VisualVoicemailCallLogFragment;
import com.android.dialer.common.Assert;
import com.android.dialer.common.LogUtil;
-import com.android.dialer.configprovider.ConfigProviderBindings;
import com.android.dialer.contactsfragment.ContactsFragment;
import com.android.dialer.contactsfragment.ContactsFragment.Header;
import com.android.dialer.database.CallLogQueryHandler;
-import com.android.dialer.speeddial.SpeedDialFragment;
import com.android.dialer.util.ViewUtil;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -55,9 +52,7 @@ public class DialtactsPagerAdapter extends FragmentPagerAdapter {
private final List<Fragment> fragments = new ArrayList<>();
private final String[] tabTitles;
- private final boolean useNewSpeedDialTab;
private OldSpeedDialFragment oldSpeedDialFragment;
- private SpeedDialFragment speedDialFragment;
private CallLogFragment callLogFragment;
private ContactsFragment contactsFragment;
private CallLogFragment voicemailFragment;
@@ -65,10 +60,8 @@ public class DialtactsPagerAdapter extends FragmentPagerAdapter {
private boolean hasActiveVoicemailProvider;
public DialtactsPagerAdapter(
- Context context, FragmentManager fm, String[] tabTitles, boolean hasVoicemailProvider) {
+ FragmentManager fm, String[] tabTitles, boolean hasVoicemailProvider) {
super(fm);
- useNewSpeedDialTab =
- ConfigProviderBindings.get(context).getBoolean("enable_new_favorites_tab", false);
this.tabTitles = tabTitles;
hasActiveVoicemailProvider = hasVoicemailProvider;
fragments.addAll(Collections.nCopies(TAB_COUNT_WITH_VOICEMAIL, null));
@@ -84,17 +77,10 @@ public class DialtactsPagerAdapter extends FragmentPagerAdapter {
LogUtil.d("ViewPagerAdapter.getItem", "position: %d", position);
switch (getRtlPosition(position)) {
case TAB_INDEX_SPEED_DIAL:
- if (useNewSpeedDialTab) {
- if (speedDialFragment == null) {
- speedDialFragment = SpeedDialFragment.newInstance();
- }
- return speedDialFragment;
- } else {
- if (oldSpeedDialFragment == null) {
- oldSpeedDialFragment = new OldSpeedDialFragment();
- }
- return oldSpeedDialFragment;
+ if (oldSpeedDialFragment == null) {
+ oldSpeedDialFragment = new OldSpeedDialFragment();
}
+ return oldSpeedDialFragment;
case TAB_INDEX_HISTORY:
if (callLogFragment == null) {
callLogFragment = new CallLogFragment(CallLogQueryHandler.CALL_TYPE_ALL);
@@ -128,8 +114,6 @@ public class DialtactsPagerAdapter extends FragmentPagerAdapter {
final Fragment fragment = (Fragment) super.instantiateItem(container, position);
if (fragment instanceof OldSpeedDialFragment) {
oldSpeedDialFragment = (OldSpeedDialFragment) fragment;
- } else if (fragment instanceof SpeedDialFragment) {
- speedDialFragment = (SpeedDialFragment) fragment;
} else if (fragment instanceof CallLogFragment && position == TAB_INDEX_HISTORY) {
callLogFragment = (CallLogFragment) fragment;
} else if (fragment instanceof ContactsFragment) {
diff --git a/java/com/android/dialer/app/list/ListsFragment.java b/java/com/android/dialer/app/list/ListsFragment.java
index d314917ef..93e89230b 100644
--- a/java/com/android/dialer/app/list/ListsFragment.java
+++ b/java/com/android/dialer/app/list/ListsFragment.java
@@ -45,7 +45,6 @@ import com.android.dialer.logging.Logger;
import com.android.dialer.logging.ScreenEvent;
import com.android.dialer.logging.UiAction;
import com.android.dialer.performancereport.PerformanceReport;
-import com.android.dialer.speeddial.SpeedDialFragment;
import com.android.dialer.util.PermissionsUtil;
import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler;
import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler.Source;
@@ -199,7 +198,6 @@ public class ListsFragment extends Fragment
viewPager = (DialerViewPager) parentView.findViewById(R.id.lists_pager);
adapter =
new DialtactsPagerAdapter(
- getContext(),
getChildFragmentManager(),
tabTitles,
prefs.getBoolean(
@@ -456,11 +454,10 @@ public class ListsFragment extends Fragment
}
public boolean hasFrequents() {
- Fragment page =
- adapter.getItem(adapter.getRtlPosition(DialtactsPagerAdapter.TAB_INDEX_SPEED_DIAL));
- return page instanceof OldSpeedDialFragment
- ? ((OldSpeedDialFragment) page).hasFrequents()
- : ((SpeedDialFragment) page).hasFrequents();
+ OldSpeedDialFragment page =
+ (OldSpeedDialFragment)
+ adapter.getItem(adapter.getRtlPosition(DialtactsPagerAdapter.TAB_INDEX_SPEED_DIAL));
+ return page.hasFrequents();
}
public RemoveView getRemoveView() {