diff options
| author | uabdullah <uabdullah@google.com> | 2018-03-08 18:24:33 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-piper@google.com> | 2018-03-08 18:26:58 -0800 |
| commit | 362350a54359c22e94c25edc008978645c8e6ee9 (patch) | |
| tree | ca2ca0fee43786bbcfb157317778c86d99d2acbc /java/com/android/dialer/app | |
| parent | fd4c9f75aa2eba3e6a896d107f05ff370c2ad2b1 (diff) | |
Implement non-ui logic for delete/undo delete voicemails
When a voicemail is deleted we have to allow the user the option of cancelling the deleting of voicemail. This is done by showing the user a snack bar which when a user taps will prevent the voicemail from being deleted.
This CL only adds the underlying logic for the delete/undelete to take place via a ScheduledFuture, it does not fix all the UI issues that come with it, which will be sent in a follow up CL, issues such as:
-Updating the group label when a delete/undo happens
-Updating the entries above and below when a delete/undo happens
-Showing the empty view immediately when a user deletes a single voicemail
-Removing the empty view immediately when a user taps undo
-Updating tests
Bug: 69858266
Test: Manual
PiperOrigin-RevId: 188424489
Change-Id: Iecf5cb7be5b80fa5e91acaad3a7cc4a6c8702521
Diffstat (limited to 'java/com/android/dialer/app')
| -rw-r--r-- | java/com/android/dialer/app/res/values/strings.xml | 3 | ||||
| -rw-r--r-- | java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/java/com/android/dialer/app/res/values/strings.xml b/java/com/android/dialer/app/res/values/strings.xml index e8377ecff..047f9e375 100644 --- a/java/com/android/dialer/app/res/values/strings.xml +++ b/java/com/android/dialer/app/res/values/strings.xml @@ -51,9 +51,6 @@ <!-- Text for snackbar to undo a voicemail delete. [CHAR LIMIT=30] --> <string name="snackbar_voicemail_deleted">Voicemail deleted</string> - <!-- Text for undo button in snackbar for voicemail deletion. [CHAR LIMIT=10] --> - <string name="snackbar_voicemail_deleted_undo">UNDO</string> - <!-- Title of the confirmation dialog for clearing the call log. [CHAR LIMIT=37] --> <string name="clearCallLogConfirmation_title">Clear call history?</string> diff --git a/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java b/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java index 010f55fa8..05da8e752 100644 --- a/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java +++ b/java/com/android/dialer/app/voicemail/VoicemailPlaybackLayout.java @@ -114,7 +114,7 @@ public class VoicemailPlaybackLayout extends LinearLayout Snackbar.LENGTH_LONG) .setDuration(VOICEMAIL_DELETE_DELAY_MS) .setAction( - R.string.snackbar_voicemail_deleted_undo, + R.string.snackbar_undo, new View.OnClickListener() { @Override public void onClick(View view) { |