summaryrefslogtreecommitdiff
path: root/java/com/android/dialer/app/list/ListsFragment.java
diff options
context:
space:
mode:
authortwyen <twyen@google.com>2017-09-25 17:06:53 -0700
committerEric Erfanian <erfanian@google.com>2017-09-26 08:39:56 -0700
commitd033dead22b83cdf61a53d48c99653c28cb8db61 (patch)
treebde9ee3eb2b8b789a8de4bce793b47424857933c /java/com/android/dialer/app/list/ListsFragment.java
parent66f4ea01f37641def4b82a55e3e751014663525e (diff)
Fix onVisible/onNotVisible called on CallLogFragment without being attahced after rotation
mCurrentPage is set onResume before the fragment is attached. In this CL, mCurrentPage is still used for page change, but for resume and pause, it is detected directly in CallLogFragment using getUserVisibleHint() Bug: 65161134 Test: manual - change call volume after rotation, check ToS FAB not visible after rotation. CallLogFragment is not testable. PiperOrigin-RevId: 169984576 Change-Id: I870cbe3b83e38ac2cb505193309ab4f8e75a859f
Diffstat (limited to 'java/com/android/dialer/app/list/ListsFragment.java')
-rw-r--r--java/com/android/dialer/app/list/ListsFragment.java12
1 files changed, 3 insertions, 9 deletions
diff --git a/java/com/android/dialer/app/list/ListsFragment.java b/java/com/android/dialer/app/list/ListsFragment.java
index 8dbe18cee..a94f9c137 100644
--- a/java/com/android/dialer/app/list/ListsFragment.java
+++ b/java/com/android/dialer/app/list/ListsFragment.java
@@ -107,7 +107,7 @@ public class ListsFragment extends Fragment implements OnPageChangeListener, Lis
@Override
public void onResume() {
- LogUtil.d("ListsFragment.onResume", null);
+ LogUtil.enterBlock("ListsFragment.onResume");
Trace.beginSection(TAG + " onResume");
super.onResume();
@@ -124,17 +124,11 @@ public class ListsFragment extends Fragment implements OnPageChangeListener, Lis
mCallLogQueryHandler.fetchMissedCallsUnreadCount();
Trace.endSection();
mCurrentPage = mAdapter.getItem(mViewPager.getCurrentItem());
- if (mCurrentPage instanceof CallLogFragment) {
- ((CallLogFragment) mCurrentPage).onVisible();
- }
}
@Override
public void onPause() {
- LogUtil.d("ListsFragment.onPause", null);
- if (mCurrentPage instanceof CallLogFragment) {
- ((CallLogFragment) mCurrentPage).onNotVisible();
- }
+ LogUtil.enterBlock("ListsFragment.onPause");
super.onPause();
mPaused = true;
@@ -149,7 +143,7 @@ public class ListsFragment extends Fragment implements OnPageChangeListener, Lis
@Override
public View onCreateView(
LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
- LogUtil.d("ListsFragment.onCreateView", null);
+ LogUtil.enterBlock("ListsFragment.onCreateView");
Trace.beginSection(TAG + " onCreateView");
Trace.beginSection(TAG + " inflate view");
final View parentView = inflater.inflate(R.layout.lists_fragment, container, false);