diff options
author | Christine Chen <christinech@google.com> | 2013-09-17 18:29:32 -0700 |
---|---|---|
committer | Christine Chen <christinech@google.com> | 2013-09-17 18:29:32 -0700 |
commit | 1a495815c3c3fb3ca4fad29feb7ffb5000c1b264 (patch) | |
tree | b1a026451d4005e6c4422c95eba8a292c5cf2dc0 /InCallUI | |
parent | c925e87be05fa88888b135bf9f663332e7875200 (diff) |
Removing finished TODO(klp)
Bug: 10605909
Change-Id: Ia4bfcc385d4bf36cbc3b401521714958fd829c7e
Diffstat (limited to 'InCallUI')
4 files changed, 1 insertions, 8 deletions
diff --git a/InCallUI/src/com/android/incallui/CallButtonPresenter.java b/InCallUI/src/com/android/incallui/CallButtonPresenter.java index 78cc084fa..4de129d14 100644 --- a/InCallUI/src/com/android/incallui/CallButtonPresenter.java +++ b/InCallUI/src/com/android/incallui/CallButtonPresenter.java @@ -153,7 +153,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto return; } - // TODO(klp): hook up call id. CallCommandClient.getInstance().disconnectCall(mCall.getCallId()); } @@ -173,7 +172,6 @@ public class CallButtonPresenter extends Presenter<CallButtonPresenter.CallButto Log.d(this, "holding: " + mCall.getCallId()); - // TODO(klp): use appropriate hold callId. CallCommandClient.getInstance().hold(mCall.getCallId(), checked); getUi().setHold(checked); } diff --git a/InCallUI/src/com/android/incallui/ContactInfoCache.java b/InCallUI/src/com/android/incallui/ContactInfoCache.java index e005942b2..6c05650b9 100644 --- a/InCallUI/src/com/android/incallui/ContactInfoCache.java +++ b/InCallUI/src/com/android/incallui/ContactInfoCache.java @@ -266,8 +266,6 @@ public class ContactInfoCache implements ContactsAsyncHelper.OnImageLoadComplete Log.d(this, "Image load complete with context: ", mContext); // TODO: may be nice to update the image view again once the newer one // is available on contacts database. - // TODO (klp): What is this, and why does it need the write_contacts permission? - // CallerInfoUtils.sendViewNotificationAsync(mContext, mLoadingPersonUri); final int callId = (Integer) cookie; final ContactCacheEntry entry = mInfoMap.get(callId); @@ -279,7 +277,7 @@ public class ContactInfoCache implements ContactsAsyncHelper.OnImageLoadComplete } Log.d(this, "setting photo for entry: ", entry); - // TODO (klp): Handle conference calls + // Conference call icons are being handled in CallCardPresenter. if (photo != null) { Log.v(this, "direct drawable: ", photo); entry.photo = photo; diff --git a/InCallUI/src/com/android/incallui/DialpadPresenter.java b/InCallUI/src/com/android/incallui/DialpadPresenter.java index cee80d2d8..8640f8acc 100644 --- a/InCallUI/src/com/android/incallui/DialpadPresenter.java +++ b/InCallUI/src/com/android/incallui/DialpadPresenter.java @@ -50,7 +50,6 @@ public class DialpadPresenter extends Presenter<DialpadPresenter.DialpadUi> * DTMF tone (or short tone if requested), and appending the digit to the * EditText field that displays the DTMF digits sent so far. */ - // TODO(klp) Add timedShortTone==true handling for accessibility cases. public final void processDtmf(char c, boolean timedShortTone) { Log.d(this, "Processing dtmf key " + c); // if it is a valid key, then update the display and send the dtmf tone. diff --git a/InCallUI/src/com/android/incallui/InCallActivity.java b/InCallUI/src/com/android/incallui/InCallActivity.java index feb3ec137..f4ddf62d0 100644 --- a/InCallUI/src/com/android/incallui/InCallActivity.java +++ b/InCallUI/src/com/android/incallui/InCallActivity.java @@ -279,8 +279,6 @@ public class InCallActivity extends Activity { } private void initializeInCall() { - // TODO(klp): Make sure that this doesn't need to move back to onResume() since they are - // statically added fragments. if (mCallButtonFragment == null) { mCallButtonFragment = (CallButtonFragment) getFragmentManager() .findFragmentById(R.id.callButtonFragment); |