diff options
| author | zachh <zachh@google.com> | 2018-04-19 16:47:59 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-piper@google.com> | 2018-04-19 16:49:34 -0700 |
| commit | 5f1d084c67e20296e5d2372c59c837ab1d701409 (patch) | |
| tree | 44ccdbc094775020e29f39d6f39b3ce314d01bc3 /CONTRIBUTING | |
| parent | ac069a79d2f0701d1ce0371a11e3d2ed63afc4de (diff) | |
Use PreCall.start instead of context.startActivity when starting calls from call log.
For some reason not understood, startActivity with the call intent causes the current activity (MainActivity) to be paused, resumed, and paused again. This results in an opportunity to double-tap the row which causes the InCallUi to open in bubble mode (this is also not well understood).
In any event, PreCall.start eventually uses TelecomManager to place the call rather than startActivity, which is presumably the thing that fixes the problem.
Also refactored TestPreCallModule to remove the many test implementations of PreCall and remove the static field in the module which could cause test interference.
TEST=manual
Bug: 78187587
Test: manual
PiperOrigin-RevId: 193596093
Change-Id: I933020d33db1c158628f14b30c2681c59c86201b
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions