summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorerfanian <erfanian@google.com>2017-11-20 16:57:06 -0800
committerCopybara-Service <copybara-piper@google.com>2017-11-20 17:45:06 -0800
commitd2f29974f3e0a9c54a341996a90d39342be07ca3 (patch)
tree89c9c82cede57f550f8578cc6886c89b5be71255
parent7ef551e512ea6cc80a393f52902f1450e3a1d9d4 (diff)
Add impression to track when users explicitly disable assisted dialing.
Test: new unit tests PiperOrigin-RevId: 176438950 Change-Id: Ic0747302170593b91da4148029396c36ab070c6e
-rw-r--r--java/com/android/dialer/assisteddialing/ui/AssistedDialingSettingFragment.java17
-rw-r--r--java/com/android/dialer/logging/dialer_impression.proto3
2 files changed, 20 insertions, 0 deletions
diff --git a/java/com/android/dialer/assisteddialing/ui/AssistedDialingSettingFragment.java b/java/com/android/dialer/assisteddialing/ui/AssistedDialingSettingFragment.java
index a70844fbd..05ca6d912 100644
--- a/java/com/android/dialer/assisteddialing/ui/AssistedDialingSettingFragment.java
+++ b/java/com/android/dialer/assisteddialing/ui/AssistedDialingSettingFragment.java
@@ -19,7 +19,10 @@ import android.os.Bundle;
import android.preference.ListPreference;
import android.preference.Preference;
import android.preference.PreferenceFragment;
+import android.preference.SwitchPreference;
import android.text.TextUtils;
+import com.android.dialer.logging.DialerImpression;
+import com.android.dialer.logging.Logger;
/** The setting for Assisted Dialing */
public class AssistedDialingSettingFragment extends PreferenceFragment {
@@ -30,6 +33,10 @@ public class AssistedDialingSettingFragment extends PreferenceFragment {
// Load the preferences from an XML resource
addPreferencesFromResource(R.xml.assisted_dialing_setting);
+ SwitchPreference switchPref =
+ (SwitchPreference)
+ findPreference(getContext().getString(R.string.assisted_dialing_setting_toggle_key));
+
ListPreference countryChooserPref =
(ListPreference)
findPreference(getContext().getString(R.string.assisted_dialing_setting_cc_key));
@@ -38,6 +45,7 @@ public class AssistedDialingSettingFragment extends PreferenceFragment {
countryChooserPref.setSummary(countryChooserPref.getEntry());
}
countryChooserPref.setOnPreferenceChangeListener(this::updateListSummary);
+ switchPref.setOnPreferenceChangeListener(this::logIfUserDisabledFeature);
}
boolean updateListSummary(Preference pref, Object newValue) {
@@ -46,4 +54,13 @@ public class AssistedDialingSettingFragment extends PreferenceFragment {
listPref.setSummary(entries[listPref.findIndexOfValue(newValue.toString())]);
return true;
}
+
+ boolean logIfUserDisabledFeature(Preference pref, Object newValue) {
+ if (!((boolean) newValue)) {
+ Logger.get(getActivity().getApplicationContext())
+ .logImpression(DialerImpression.Type.ASSISTED_DIALING_FEATURE_DISABLED_BY_USER);
+ }
+
+ return true;
+ }
}
diff --git a/java/com/android/dialer/logging/dialer_impression.proto b/java/com/android/dialer/logging/dialer_impression.proto
index 3dd645e65..c2456d8ac 100644
--- a/java/com/android/dialer/logging/dialer_impression.proto
+++ b/java/com/android/dialer/logging/dialer_impression.proto
@@ -12,6 +12,7 @@ message DialerImpression {
// Event enums to be used for Impression Logging in Dialer.
// It's perfectly acceptable for this enum to be large
// Values should be from 1000 to 100000.
+ // Next Tag: 1293
enum Type {
UNKNOWN_AOSP_EVENT_TYPE = 1000;
@@ -589,6 +590,8 @@ message DialerImpression {
// Indicates that the number attempting to be assisted dialed had an
// extension.
ASSISTED_DIALING_CONSTRAINT_NUMBER_HAS_EXTENSION = 1289;
+ // Indicates that the user disabled the feature.
+ ASSISTED_DIALING_FEATURE_DISABLED_BY_USER = 1292;
// User reports a same prefix call as spam from call history
REPORT_SAME_PREFIX_CALL_AS_SPAM_VIA_CALL_HISTORY =