summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorke Lee <yorkelee@google.com>2013-07-29 08:51:35 -0700
committerYorke Lee <yorkelee@google.com>2013-07-29 09:32:25 -0700
commitc59a4b5df9f21a6ec47bcf6c2bb67ecdc9fbe58a (patch)
tree00711c3ba6a6c8d64072745aab6b742e69e739a9
parentfca42086a510778d951fe1d5d80f35223f9d7a0d (diff)
Redlines for phone number list fragments
* Add and remove padding for regular search and smart dialing search fragments. * Move background colors to individual fragment views instead of the app, so that they can define their own background colors without causing overdraw. * Remove unused imports in SearchFragment Change-Id: Id1523c5760ea3cf5e675df8f89e5bd299a95eb18
-rw-r--r--res/layout/new_phone_favorites_fragment.xml3
-rw-r--r--res/values/styles.xml7
-rw-r--r--src/com/android/dialer/NewSearchFragment.java4
3 files changed, 5 insertions, 9 deletions
diff --git a/res/layout/new_phone_favorites_fragment.xml b/res/layout/new_phone_favorites_fragment.xml
index 9974adf65..cc11ea164 100644
--- a/res/layout/new_phone_favorites_fragment.xml
+++ b/res/layout/new_phone_favorites_fragment.xml
@@ -22,7 +22,8 @@
android:orientation="vertical"
android:divider="?android:attr/dividerHorizontal"
android:showDividers="end"
- android:clipChildren="false">
+ android:clipChildren="false"
+ android:background="@color/background_dialer_light">
<FrameLayout
android:layout_width="match_parent"
android:layout_height="0dp"
diff --git a/res/values/styles.xml b/res/values/styles.xml
index 0cdf223e3..86df4ae7f 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -73,7 +73,6 @@
<item name="android:actionBarStyle">@style/DialtactsActionBarStyleNew</item>
<item name="android:actionBarTabStyle">@style/DialtactsActionBarTabStyle</item>
<item name="android:windowContentOverlay">@null</item>
- <item name="android:windowBackground">@color/background_dialer_light</item>
<!-- Searchbox Style -->
<item name="android:editTextStyle">@style/DialtactsSearchboxStyle</item>
<item name="android:listViewStyle">@style/ListViewStyle</item>
@@ -81,9 +80,9 @@
<item name="section_header_background">@drawable/list_title_holo</item>
<item name="list_section_header_height">32dip</item>
<item name="list_item_divider">?android:attr/listDivider</item>
- <item name="list_item_padding_top">0dip</item>
+ <item name="list_item_padding_top">8dip</item>
<item name="list_item_padding_right">0dip</item>
- <item name="list_item_padding_bottom">0dip</item>
+ <item name="list_item_padding_bottom">8dip</item>
<item name="list_item_padding_left">0dip</item>
<item name="list_item_gap_between_image_and_text">8dip</item>
<item name="list_item_gap_between_label_and_data">5dip</item>
@@ -100,7 +99,7 @@
<item name="list_item_header_underline_color">@color/people_app_theme_color</item>
<item name="list_item_data_width_weight">5</item>
<item name="list_item_label_width_weight">3</item>
- <item name="contact_browser_list_padding_left">16dip</item>
+ <item name="contact_browser_list_padding_left">8dip</item>
<item name="contact_browser_list_padding_right">0dip</item>
<item name="contact_browser_background">@android:color/transparent</item>
<item name="list_item_text_indent">@dimen/contact_browser_list_item_text_indent</item>
diff --git a/src/com/android/dialer/NewSearchFragment.java b/src/com/android/dialer/NewSearchFragment.java
index c428db239..0ddee4207 100644
--- a/src/com/android/dialer/NewSearchFragment.java
+++ b/src/com/android/dialer/NewSearchFragment.java
@@ -16,16 +16,12 @@
package com.android.dialer;
import android.app.Activity;
-import android.os.Bundle;
import android.view.LayoutInflater;
-import android.view.View;
import android.view.ViewGroup;
import android.widget.AbsListView;
import android.widget.AbsListView.OnScrollListener;
-import android.widget.ListView;
import com.android.contacts.common.list.ContactListItemView;
-import com.android.contacts.common.list.PhoneNumberListAdapter;
import com.android.contacts.common.list.PhoneNumberPickerFragment;
import com.android.dialer.list.OnListFragmentScrolledListener;