diff options
author | zachh <zachh@google.com> | 2018-01-29 15:35:05 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-01-29 20:49:58 -0800 |
commit | c377217d3ebd503fb91c55ac871c981f99ec649c (patch) | |
tree | d36ab22603eb32f173c5ed6ac8666c4f65b2aeba | |
parent | f27f1bd028abfcac714cf5aed6bbbab8d21077a6 (diff) |
Use application context when fetching shared prefs.
Using non-application contexts incurs extra disk access because shared prefs are cached per context.
Test: manually ejected sim and observed no strict mode violations
PiperOrigin-RevId: 183739285
Change-Id: I9337e226ae1e060478219cf495752ceccf5a31e6
-rw-r--r-- | java/com/android/voicemail/impl/OmtpService.java | 4 | ||||
-rw-r--r-- | java/com/android/voicemail/impl/VisualVoicemailPreferences.java | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/java/com/android/voicemail/impl/OmtpService.java b/java/com/android/voicemail/impl/OmtpService.java index 4e8860c02..e10a27571 100644 --- a/java/com/android/voicemail/impl/OmtpService.java +++ b/java/com/android/voicemail/impl/OmtpService.java @@ -197,14 +197,14 @@ public class OmtpService extends VisualVoicemailService { } private static void setShuttingDown(Context context, boolean value) { - PreferenceManager.getDefaultSharedPreferences(context) + PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext()) .edit() .putBoolean(IS_SHUTTING_DOWN, value) .apply(); } private static boolean isShuttingDown(Context context) { - return PreferenceManager.getDefaultSharedPreferences(context) + return PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext()) .getBoolean(IS_SHUTTING_DOWN, false); } } diff --git a/java/com/android/voicemail/impl/VisualVoicemailPreferences.java b/java/com/android/voicemail/impl/VisualVoicemailPreferences.java index 72506eb93..1d7204e94 100644 --- a/java/com/android/voicemail/impl/VisualVoicemailPreferences.java +++ b/java/com/android/voicemail/impl/VisualVoicemailPreferences.java @@ -31,7 +31,7 @@ public class VisualVoicemailPreferences extends PerAccountSharedPreferences { super( context, phoneAccountHandle, - PreferenceManager.getDefaultSharedPreferences(context), + PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext()), "visual_voicemail_"); } } |