diff options
author | Garik Badalyan <garikb@quicinc.com> | 2015-03-24 10:46:01 -0700 |
---|---|---|
committer | Garik Badalyan <garikb@quicinc.com> | 2015-03-24 10:47:46 -0700 |
commit | b1dff5e869abe3fa558f639ca24c1a856d515306 (patch) | |
tree | 4fb538821f544782619cd6cf5ab7f80b9043760f | |
parent | 7f768367db3394324234ac807f10f99ad505dbd9 (diff) |
Fix the dial string to include the + sign added by user for VT call
- The smart dial search normalizes the dial string and removes
anything other than digits
- Add a fix to add the + sign back to the normalized string
if original typed number had a + sign
- Add a check for prohibited numbers before making a call
and display an error dialog
Change-Id: Ib36462be573ce4fecc8821980226ae2920041cd2
-rw-r--r-- | src/com/android/dialer/list/SearchFragment.java | 40 |
1 files changed, 36 insertions, 4 deletions
diff --git a/src/com/android/dialer/list/SearchFragment.java b/src/com/android/dialer/list/SearchFragment.java index e50d0d89e..9abd7b048 100644 --- a/src/com/android/dialer/list/SearchFragment.java +++ b/src/com/android/dialer/list/SearchFragment.java @@ -16,10 +16,12 @@ package com.android.dialer.list; import android.app.Activity; +import android.app.DialogFragment; import android.content.Intent; import android.content.res.Resources; import android.os.Bundle; import android.text.TextUtils; +import android.util.Log; import android.view.View; import android.view.animation.Interpolator; import android.widget.AbsListView; @@ -32,12 +34,14 @@ import com.android.contacts.common.list.OnPhoneNumberPickerActionListener; import com.android.contacts.common.list.PhoneNumberPickerFragment; import com.android.contacts.common.util.ViewUtil; import com.android.contacts.commonbind.analytics.AnalyticsUtil; +import com.android.dialer.dialpad.DialpadFragment.ErrorDialogFragment; import com.android.dialer.DialtactsActivity; import com.android.dialer.R; import com.android.dialer.util.DialerUtils; import com.android.phone.common.animation.AnimUtils; public class SearchFragment extends PhoneNumberPickerFragment { + private static final String TAG = "SearchFragment"; private OnListFragmentScrolledListener mActivityScrollListener; @@ -137,6 +141,32 @@ public class SearchFragment extends PhoneNumberPickerFragment { mAddToContactNumber = addToContactNumber; } + /** + * Return true if phone number is prohibited by a value - + * (R.string.config_prohibited_phone_number_regexp) in the config files. False otherwise. + */ + public boolean checkForProhibitedPhoneNumber(String number) { + // Regular expression prohibiting manual phone call. Can be empty i.e. "no rule". + String prohibitedPhoneNumberRegexp = getResources().getString( + R.string.config_prohibited_phone_number_regexp); + + // "persist.radio.otaspdial" is a temporary hack needed for one carrier's automated + // test equipment. + if (number != null + && !TextUtils.isEmpty(prohibitedPhoneNumberRegexp) + && number.matches(prohibitedPhoneNumberRegexp)) { + Log.d(TAG, "The phone number is prohibited explicitly by a rule."); + if (getActivity() != null) { + DialogFragment dialogFragment = ErrorDialogFragment.newInstance( + R.string.dialog_phone_call_prohibited_message); + dialogFragment.show(getFragmentManager(), "phone_prohibited_dialog"); + } + + return true; + } + return false; + } + @Override protected ContactEntryListAdapter createListAdapter() { DialerPhoneNumberListAdapter adapter = new DialerPhoneNumberListAdapter(getActivity()); @@ -151,14 +181,16 @@ public class SearchFragment extends PhoneNumberPickerFragment { final int shortcutType = adapter.getShortcutTypeFromPosition(position); final OnPhoneNumberPickerActionListener listener; + boolean ret = checkForProhibitedPhoneNumber(mAddToContactNumber); + switch (shortcutType) { case DialerPhoneNumberListAdapter.SHORTCUT_INVALID: super.onItemClick(position, id); break; case DialerPhoneNumberListAdapter.SHORTCUT_DIRECT_CALL: listener = getOnPhoneNumberPickerListener(); - if (listener != null) { - listener.onCallNumberDirectly(getQueryString()); + if (listener != null && !ret) { + listener.onCallNumberDirectly(mAddToContactNumber); } break; case DialerPhoneNumberListAdapter.SHORTCUT_ADD_NUMBER_TO_CONTACTS: @@ -170,8 +202,8 @@ public class SearchFragment extends PhoneNumberPickerFragment { break; case DialerPhoneNumberListAdapter.SHORTCUT_MAKE_VIDEO_CALL: listener = getOnPhoneNumberPickerListener(); - if (listener != null) { - listener.onCallNumberDirectly(getQueryString(), true /* isVideoCall */); + if (listener != null && !ret) { + listener.onCallNumberDirectly(mAddToContactNumber, true /* isVideoCall */); } break; } |