diff options
author | linyuh <linyuh@google.com> | 2018-01-22 15:42:00 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-01-22 16:11:50 -0800 |
commit | a2c2d5c65ec2aad3ba198ab645e01f51331c8e83 (patch) | |
tree | de2f2c82b68181a8817d1b341d35f23c32012922 | |
parent | 05838b54c2ba81e74e205141c436ad8e9900b933 (diff) |
Don't let the FAB obscure the last item of speed dial/call log/voicemail.
Bug: 72235391
Test: Manual
PiperOrigin-RevId: 182848699
Change-Id: I587f5f4dd770278747114da17581c8fc253651c0
5 files changed, 12 insertions, 7 deletions
diff --git a/java/com/android/contacts/common/res/values/dimens.xml b/java/com/android/contacts/common/res/values/dimens.xml index 1ad9b30b0..df3e53c77 100644 --- a/java/com/android/contacts/common/res/values/dimens.xml +++ b/java/com/android/contacts/common/res/values/dimens.xml @@ -49,9 +49,6 @@ <dimen name="floating_action_button_width">56dp</dimen> <!-- Z translation of the floating action button --> <dimen name="floating_action_button_translation_z">8dp</dimen> - <!-- Padding to be applied to the bottom of lists to make space for the floating action - button --> - <dimen name="floating_action_button_list_bottom_padding">88dp</dimen> <!-- Right margin of the floating action button --> <dimen name="floating_action_button_margin_right">16dp</dimen> <!-- Bottom margin of the floating action button --> diff --git a/java/com/android/dialer/calllog/ui/res/layout/new_call_log_fragment.xml b/java/com/android/dialer/calllog/ui/res/layout/new_call_log_fragment.xml index e1d8410b6..1a3a08b9d 100644 --- a/java/com/android/dialer/calllog/ui/res/layout/new_call_log_fragment.xml +++ b/java/com/android/dialer/calllog/ui/res/layout/new_call_log_fragment.xml @@ -20,4 +20,6 @@ android:id="@+id/new_call_log_recycler_view" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="@color/background_dialer_light"/> + android:background="@color/background_dialer_light" + android:paddingBottom="@dimen/floating_action_button_list_bottom_padding" + android:clipToPadding="false"/> diff --git a/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml b/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml index ecbb95193..9f2dec931 100644 --- a/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml +++ b/java/com/android/dialer/speeddial/res/layout/fragment_speed_dial.xml @@ -22,4 +22,5 @@ android:paddingStart="16dp" android:paddingEnd="16dp" android:clipToPadding="false" - android:background="@color/background_dialer_light"/> + android:background="@color/background_dialer_light" + android:paddingBottom="@dimen/floating_action_button_list_bottom_padding"/> diff --git a/java/com/android/dialer/theme/res/values/dimens.xml b/java/com/android/dialer/theme/res/values/dimens.xml index 2b5243ebd..88b8a0423 100644 --- a/java/com/android/dialer/theme/res/values/dimens.xml +++ b/java/com/android/dialer/theme/res/values/dimens.xml @@ -50,4 +50,8 @@ <!-- Minimum width for material compliant buttons. --> <dimen name="dialer_button_min_width">72dp</dimen> + + <!-- Padding to be applied to the bottom of lists to make space for the floating action + button --> + <dimen name="floating_action_button_list_bottom_padding">88dp</dimen> </resources> diff --git a/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_fragment.xml b/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_fragment.xml index c3d885968..9daa3e114 100644 --- a/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_fragment.xml +++ b/java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_call_log_fragment.xml @@ -17,7 +17,6 @@ <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" - xmlns:fab="http://schemas.android.com/apk/res-auto" android:id="@+id/fragment_my_frame_layout" android:layout_width="wrap_content" android:layout_height="wrap_content" @@ -29,6 +28,8 @@ android:id="@+id/new_voicemail_call_log_recycler_view" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="@color/background_dialer_light"/> + android:background="@color/background_dialer_light" + android:paddingBottom="@dimen/floating_action_button_list_bottom_padding" + android:clipToPadding="false"/> </FrameLayout> |