summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNancy Chen <nancychen@google.com>2015-01-16 16:29:00 -0800
committerNancy Chen <nancychen@google.com>2015-01-16 16:29:00 -0800
commit68bea2f82c3425ffbb894d315e913fba4aaa5795 (patch)
treed633ade63f178d0229ea85ca76a0cf4bda419a74
parent87f98d75fa021f00911fad13773d8972e7ebeb55 (diff)
Remove padding from call buttons to fix undesired cropping.
Padding was added to the sides of the call button row in order to prevent false touches. However, this additional padding causes cropping of the background on the two buttons on the far left and far right when all 5 buttons are present on low resolution devices. Since on high resolution devices there is more than enough extra space on the left and right, this padding is being removed to eliminate cropping. Bug: 18122087 Change-Id: Ie948d9cbe4ef7025702ae1f4666354ab1be76bbc
-rw-r--r--InCallUI/res/layout/call_button_fragment.xml2
-rw-r--r--InCallUI/res/values/dimens.xml7
2 files changed, 0 insertions, 9 deletions
diff --git a/InCallUI/res/layout/call_button_fragment.xml b/InCallUI/res/layout/call_button_fragment.xml
index 24101feac..e8feca68a 100644
--- a/InCallUI/res/layout/call_button_fragment.xml
+++ b/InCallUI/res/layout/call_button_fragment.xml
@@ -45,8 +45,6 @@
android:orientation="horizontal"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:paddingStart="@dimen/button_cluster_horizontal_padding"
- android:paddingEnd="@dimen/button_cluster_horizontal_padding"
android:gravity="bottom|center_horizontal"
android:baselineAligned="false">
diff --git a/InCallUI/res/values/dimens.xml b/InCallUI/res/values/dimens.xml
index f390f38ec..43307e8db 100644
--- a/InCallUI/res/values/dimens.xml
+++ b/InCallUI/res/values/dimens.xml
@@ -69,13 +69,6 @@
<dimen name="floating_action_bar_vertical_offset">-24dp</dimen>
- <!-- Padding at the left and right edges of the incall_touch_ui button
- cluster. This padding is necessary because we can't allow the
- buttons to be very close to the edges of the screen, due to the
- risk of false touches (from your finger wrapping around while
- holding the phone, *before* moving it up to your face and having
- the prox sensor kick in.) -->
- <dimen name="button_cluster_horizontal_padding">20dp</dimen>
<dimen name="call_button_margin_vertical">8dp</dimen>
<dimen name="call_button_margin_horizontal">6dp</dimen>