summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorke Lee <yorkelee@google.com>2014-05-23 16:25:30 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2014-05-23 16:25:30 +0000
commit1a6938873a21aa464f5735e7592da5b868aae96b (patch)
tree6f8f406a81edb6cbe4d55d2cac51821080a46618
parent89e59d6059c9f547ac1351efe89360af862dbe1f (diff)
parent85d992d7b92ad68714408aa1b307cc63064d9751 (diff)
am 85d992d7: Merge "Add padding to bottom of listviews" into lmp-preview-dev
* commit '85d992d7b92ad68714408aa1b307cc63064d9751': Add padding to bottom of listviews
-rw-r--r--res/layout/speeddial_fragment.xml2
-rw-r--r--res/values/dimens.xml4
-rw-r--r--src/com/android/dialer/calllog/CallLogFragment.java3
-rw-r--r--src/com/android/dialer/list/AllContactsFragment.java9
-rw-r--r--src/com/android/dialer/list/SearchFragment.java8
5 files changed, 22 insertions, 4 deletions
diff --git a/res/layout/speeddial_fragment.xml b/res/layout/speeddial_fragment.xml
index e8587faeb..f025e6179 100644
--- a/res/layout/speeddial_fragment.xml
+++ b/res/layout/speeddial_fragment.xml
@@ -40,7 +40,7 @@
android:clipToPadding="false"
android:fadingEdge="none"
android:divider="@null"
- android:paddingBottom="@dimen/floating_action_button_height"
+ android:paddingBottom="@dimen/floating_action_button_list_bottom_padding"
android:nestedScrollingEnabled="true" />
</FrameLayout>
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index 433300db3..78d91c247 100644
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -42,9 +42,9 @@
<dimen name="call_button_height">74dp</dimen>
<!-- Right margin of the floating action button -->
- <dimen name="floating_action_button_margin_right">10dp</dimen>
+ <dimen name="floating_action_button_margin_right">16dp</dimen>
<!-- Bottom margin of the floating action button -->
- <dimen name="floating_action_button_margin_bottom">10dp</dimen>
+ <dimen name="floating_action_button_margin_bottom">16dp</dimen>
<!-- Dimensions for speed dial tiles -->
<dimen name="contact_tile_divider_width">1dp</dimen>
diff --git a/src/com/android/dialer/calllog/CallLogFragment.java b/src/com/android/dialer/calllog/CallLogFragment.java
index 240de8531..6cf6e4579 100644
--- a/src/com/android/dialer/calllog/CallLogFragment.java
+++ b/src/com/android/dialer/calllog/CallLogFragment.java
@@ -47,6 +47,7 @@ import com.android.common.io.MoreCloseables;
import com.android.contacts.common.CallUtil;
import com.android.contacts.common.GeoUtil;
import com.android.contacts.common.util.PhoneNumberHelper;
+import com.android.contacts.common.util.ViewUtil;
import com.android.dialer.R;
import com.android.dialer.list.ListsFragment.HostInterface;
import com.android.dialer.util.EmptyLoader;
@@ -563,6 +564,8 @@ public class CallLogFragment extends ListFragment
final ListView listView = getListView();
listView.removeFooterView(mFooterView);
listView.addFooterView(mFooterView);
+
+ ViewUtil.addBottomPaddingToListViewForFab(listView, getResources());
}
@Override
diff --git a/src/com/android/dialer/list/AllContactsFragment.java b/src/com/android/dialer/list/AllContactsFragment.java
index d05f66d4a..816869ffb 100644
--- a/src/com/android/dialer/list/AllContactsFragment.java
+++ b/src/com/android/dialer/list/AllContactsFragment.java
@@ -23,13 +23,14 @@ import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.AdapterView;
+import android.widget.ListView;
import android.widget.QuickContactBadge;
import com.android.contacts.common.list.ContactEntryListAdapter;
import com.android.contacts.common.list.ContactEntryListFragment;
import com.android.contacts.common.list.ContactListFilter;
-import com.android.contacts.common.list.ContactListItemView;
import com.android.contacts.common.list.DefaultContactListAdapter;
+import com.android.contacts.common.util.ViewUtil;
import com.android.dialer.R;
/**
@@ -46,6 +47,12 @@ public class AllContactsFragment extends ContactEntryListFragment<ContactEntryLi
}
@Override
+ public void onViewCreated(View view, android.os.Bundle savedInstanceState) {
+ super.onViewCreated(view, savedInstanceState);
+ ViewUtil.addBottomPaddingToListViewForFab(getListView(), getResources());
+ }
+
+ @Override
protected ContactEntryListAdapter createListAdapter() {
final DefaultContactListAdapter adapter = new DefaultContactListAdapter(getActivity()) {
@Override
diff --git a/src/com/android/dialer/list/SearchFragment.java b/src/com/android/dialer/list/SearchFragment.java
index ab76fdc28..f863d90ae 100644
--- a/src/com/android/dialer/list/SearchFragment.java
+++ b/src/com/android/dialer/list/SearchFragment.java
@@ -17,6 +17,7 @@ package com.android.dialer.list;
import android.app.Activity;
import android.content.Intent;
+import android.os.Bundle;
import android.text.TextUtils;
import android.view.View;
import android.widget.AbsListView;
@@ -27,6 +28,7 @@ import com.android.contacts.common.list.ContactEntryListAdapter;
import com.android.contacts.common.list.ContactListItemView;
import com.android.contacts.common.list.OnPhoneNumberPickerActionListener;
import com.android.contacts.common.list.PhoneNumberPickerFragment;
+import com.android.contacts.common.util.ViewUtil;
import com.android.dialer.DialtactsActivity;
import com.android.dialer.R;
import com.android.dialer.list.OnListFragmentScrolledListener;
@@ -96,6 +98,12 @@ public class SearchFragment extends PhoneNumberPickerFragment {
}
@Override
+ public void onViewCreated(View view, Bundle savedInstanceState) {
+ super.onViewCreated(view, savedInstanceState);
+ ViewUtil.addBottomPaddingToListViewForFab(getListView(), getResources());
+ }
+
+ @Override
protected void setSearchMode(boolean flag) {
super.setSearchMode(flag);
// This hides the "All contacts with phone numbers" header in the search fragment