diff options
author | Brandon Maxwell <maxwelb@google.com> | 2016-09-27 02:06:43 +0000 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2016-09-27 02:06:43 +0000 |
commit | 11bdbcaeb4127de9d9c0ca780acc1afb316a767d (patch) | |
tree | 473d99337c80901b42315542bbfbc2c46d970eec | |
parent | 7f91cbaac97167aee337d84aba214c9b5ff8cdd2 (diff) | |
parent | 151b3ae6ada8c2f49ea191a0dfaee5b990afd890 (diff) |
Fixing display option for KO, JA, ZH
am: 151b3ae6ad
Change-Id: I811b80ad4e97a0d9f4119f210aa447093172511d
-rw-r--r-- | src/com/android/dialer/settings/DialerSettingsActivity.java | 22 |
1 files changed, 18 insertions, 4 deletions
diff --git a/src/com/android/dialer/settings/DialerSettingsActivity.java b/src/com/android/dialer/settings/DialerSettingsActivity.java index fbdb4f9f5..dc1e21457 100644 --- a/src/com/android/dialer/settings/DialerSettingsActivity.java +++ b/src/com/android/dialer/settings/DialerSettingsActivity.java @@ -61,10 +61,12 @@ public class DialerSettingsActivity extends AppCompatPreferenceActivity { @Override public void onBuildHeaders(List<Header> target) { - Header displayOptionsHeader = new Header(); - displayOptionsHeader.titleRes = R.string.display_options_title; - displayOptionsHeader.fragment = DisplayOptionsSettingsFragment.class.getName(); - target.add(displayOptionsHeader); + if (showDisplayOptions()) { + Header displayOptionsHeader = new Header(); + displayOptionsHeader.titleRes = R.string.display_options_title; + displayOptionsHeader.fragment = DisplayOptionsSettingsFragment.class.getName(); + target.add(displayOptionsHeader); + } Header soundSettingsHeader = new Header(); soundSettingsHeader.titleRes = R.string.sounds_and_vibration_title; @@ -127,6 +129,18 @@ public class DialerSettingsActivity extends AppCompatPreferenceActivity { } } + /** + * Returns {@code true} or {@code false} based on whether the display options setting should be + * shown. For languages such as Chinese, Japanese, or Korean, display options aren't useful + * since contacts are sorted and displayed family name first by default. + * + * @return {@code true} if the display options should be shown, {@code false} otherwise. + */ + private boolean showDisplayOptions() { + return getResources().getBoolean(R.bool.config_display_order_user_changeable) + && getResources().getBoolean(R.bool.config_sort_order_user_changeable); + } + @Override public void onHeaderClick(Header header, int position) { if (header.id == R.id.settings_header_sounds_and_vibration) { |