diff options
author | mukesh agrawal <quiche@google.com> | 2017-03-27 17:19:17 -0700 |
---|---|---|
committer | mukesh agrawal <quiche@google.com> | 2017-04-05 17:24:04 -0700 |
commit | 9a89f4f412a0bac946ad842b437ab9e5e3b59828 (patch) | |
tree | 6d5ddb191c5fafda82442b27ae9eb9ccc02de946 /service | |
parent | e08dd98aa0f94d479f2b81120e76ef8c0ec779db (diff) |
WifiStateMachine: exclude CMD_RSSI_POLL for LogRecs
Due to the frequency with which we execute CMD_RSSI_POLL
(every 3 seconds, when the screen is on), the CMD_RSSI_POLL
LogRecs often crowd out more useful information.
To resolve this problem: don't include CMD_RSSI_POLL
in the log records maintained by StateMachine. But, to
facilitate debugging of CMD_RSSI_POLL issues, _do_
include CMD_RSSI_POLL when verbose logging is enabled.
Ideally, we'd solve this in some other way, so that the
LogRecs include all commands processed by the WifiStateMachine.
My hope is that we don't lose too much relevant information with
this change, because the consumers of the RSSI data do their
own logging.
Bug: 26960649
Test: unit tests
Change-Id: Icea22f9fe23c29cb5d2ad97b10955b74977d5e1a
Diffstat (limited to 'service')
-rw-r--r-- | service/java/com/android/server/wifi/WifiStateMachine.java | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/service/java/com/android/server/wifi/WifiStateMachine.java b/service/java/com/android/server/wifi/WifiStateMachine.java index fbe92ed88..fb807b7a0 100644 --- a/service/java/com/android/server/wifi/WifiStateMachine.java +++ b/service/java/com/android/server/wifi/WifiStateMachine.java @@ -2192,6 +2192,16 @@ public class WifiStateMachine extends StateMachine implements WifiNative.WifiRss } } + @Override + protected boolean recordLogRec(Message msg) { + switch (msg.what) { + case CMD_RSSI_POLL: + return mVerboseLoggingEnabled; + default: + return true; + } + } + /** * Return the additional string to be logged by LogRec, default * |