summaryrefslogtreecommitdiff
path: root/service
diff options
context:
space:
mode:
authorDavid Su <dysu@google.com>2020-02-14 18:27:15 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2020-02-14 18:27:15 +0000
commit60ee22d264305e31377e36847710e38d7f7d6282 (patch)
tree1be228acf92e342e98578ad1cf9eccb1722680d9 /service
parent234db4a3f2d5000bfe45b6fbaaef7ee1df6c20df (diff)
parentaf0cc2f59e313dddd0a57249c49872114f5d2705 (diff)
Merge "Rename requirePMF to requirePmf"
Diffstat (limited to 'service')
-rw-r--r--service/java/com/android/server/wifi/SupplicantStaIfaceCallbackV1_2Impl.java2
-rw-r--r--service/java/com/android/server/wifi/SupplicantStaNetworkHal.java8
-rw-r--r--service/java/com/android/server/wifi/WifiBackupDataV1Parser.java2
-rw-r--r--service/java/com/android/server/wifi/WifiConfigManager.java4
-rw-r--r--service/java/com/android/server/wifi/WifiConfigurationUtil.java14
-rw-r--r--service/java/com/android/server/wifi/util/XmlUtil.java4
6 files changed, 17 insertions, 17 deletions
diff --git a/service/java/com/android/server/wifi/SupplicantStaIfaceCallbackV1_2Impl.java b/service/java/com/android/server/wifi/SupplicantStaIfaceCallbackV1_2Impl.java
index 2c3dc61b8..89e66d22c 100644
--- a/service/java/com/android/server/wifi/SupplicantStaIfaceCallbackV1_2Impl.java
+++ b/service/java/com/android/server/wifi/SupplicantStaIfaceCallbackV1_2Impl.java
@@ -173,7 +173,7 @@ abstract class SupplicantStaIfaceCallbackV1_2Impl extends
// Set up key management: SAE or PSK
if (securityAkm == DppAkm.SAE || securityAkm == DppAkm.PSK_SAE) {
newWifiConfiguration.allowedKeyManagement.set(WifiConfiguration.KeyMgmt.SAE);
- newWifiConfiguration.requirePMF = true;
+ newWifiConfiguration.requirePmf = true;
} else if (securityAkm == DppAkm.PSK) {
newWifiConfiguration.allowedKeyManagement.set(WifiConfiguration.KeyMgmt.WPA_PSK);
} else {
diff --git a/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java b/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java
index 604641533..02bda7e0f 100644
--- a/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java
+++ b/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java
@@ -192,9 +192,9 @@ public class SupplicantStaNetworkHal {
config.hiddenSSID = mScanSsid;
}
/** Require PMF*/
- config.requirePMF = false;
+ config.requirePmf = false;
if (getRequirePmf()) {
- config.requirePMF = mRequirePmf;
+ config.requirePmf = mRequirePmf;
}
/** WEP keys **/
config.wepTxKeyIndex = -1;
@@ -370,8 +370,8 @@ public class SupplicantStaNetworkHal {
}
/** RequirePMF */
- if (!setRequirePmf(config.requirePMF)) {
- Log.e(TAG, config.SSID + ": failed to set requirePMF: " + config.requirePMF);
+ if (!setRequirePmf(config.requirePmf)) {
+ Log.e(TAG, config.SSID + ": failed to set requirePMF: " + config.requirePmf);
return false;
}
/** Key Management Scheme */
diff --git a/service/java/com/android/server/wifi/WifiBackupDataV1Parser.java b/service/java/com/android/server/wifi/WifiBackupDataV1Parser.java
index b7b0ff9e2..b787df2c2 100644
--- a/service/java/com/android/server/wifi/WifiBackupDataV1Parser.java
+++ b/service/java/com/android/server/wifi/WifiBackupDataV1Parser.java
@@ -321,7 +321,7 @@ class WifiBackupDataV1Parser implements WifiBackupDataParser {
configuration.hiddenSSID = (boolean) value;
break;
case WifiConfigurationXmlUtil.XML_TAG_REQUIRE_PMF:
- configuration.requirePMF = (boolean) value;
+ configuration.requirePmf = (boolean) value;
break;
case WifiConfigurationXmlUtil.XML_TAG_ALLOWED_KEY_MGMT:
byte[] allowedKeyMgmt = (byte[]) value;
diff --git a/service/java/com/android/server/wifi/WifiConfigManager.java b/service/java/com/android/server/wifi/WifiConfigManager.java
index bea3602d5..32f300815 100644
--- a/service/java/com/android/server/wifi/WifiConfigManager.java
+++ b/service/java/com/android/server/wifi/WifiConfigManager.java
@@ -954,7 +954,7 @@ public class WifiConfigManager {
internalConfig.BSSID = externalConfig.BSSID.toLowerCase();
}
internalConfig.hiddenSSID = externalConfig.hiddenSSID;
- internalConfig.requirePMF = externalConfig.requirePMF;
+ internalConfig.requirePmf = externalConfig.requirePmf;
if (externalConfig.preSharedKey != null
&& !externalConfig.preSharedKey.equals(PASSWORD_MASK)) {
@@ -1112,7 +1112,7 @@ public class WifiConfigManager {
// Copy over the hidden configuration parameters. These are the only parameters used by
// system apps to indicate some property about the network being added.
// These are only copied over for network additions and ignored for network updates.
- newInternalConfig.requirePMF = externalConfig.requirePMF;
+ newInternalConfig.requirePmf = externalConfig.requirePmf;
newInternalConfig.noInternetAccessExpected = externalConfig.noInternetAccessExpected;
newInternalConfig.ephemeral = externalConfig.ephemeral;
newInternalConfig.osu = externalConfig.osu;
diff --git a/service/java/com/android/server/wifi/WifiConfigurationUtil.java b/service/java/com/android/server/wifi/WifiConfigurationUtil.java
index 21d7af44e..72d8db21c 100644
--- a/service/java/com/android/server/wifi/WifiConfigurationUtil.java
+++ b/service/java/com/android/server/wifi/WifiConfigurationUtil.java
@@ -304,7 +304,7 @@ public class WifiConfigurationUtil {
if (existingConfig.hiddenSSID != newConfig.hiddenSSID) {
return true;
}
- if (existingConfig.requirePMF != newConfig.requirePMF) {
+ if (existingConfig.requirePmf != newConfig.requirePmf) {
return true;
}
if (hasEnterpriseConfigChanged(existingConfig.enterpriseConfig,
@@ -583,14 +583,14 @@ public class WifiConfigurationUtil {
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.OWE)) {
// PMF mandatory for OWE networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
Log.e(TAG, "PMF must be enabled for OWE networks");
return false;
}
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SAE)) {
// PMF mandatory for WPA3-Personal networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
Log.e(TAG, "PMF must be enabled for SAE networks");
return false;
}
@@ -600,7 +600,7 @@ public class WifiConfigurationUtil {
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SUITE_B_192)) {
// PMF mandatory for WPA3-Enterprise networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
Log.e(TAG, "PMF must be enabled for Suite-B 192-bit networks");
return false;
}
@@ -738,13 +738,13 @@ public class WifiConfigurationUtil {
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.OWE)) {
// PMF mandatory for OWE networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
return false;
}
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SAE)) {
// PMF mandatory for WPA3-Personal networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
return false;
}
if (!validatePassword(config.preSharedKey, true, true)) {
@@ -753,7 +753,7 @@ public class WifiConfigurationUtil {
}
if (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.SUITE_B_192)) {
// PMF mandatory for WPA3-Enterprise networks
- if (!config.requirePMF) {
+ if (!config.requirePmf) {
return false;
}
}
diff --git a/service/java/com/android/server/wifi/util/XmlUtil.java b/service/java/com/android/server/wifi/util/XmlUtil.java
index 79a6f1c69..06f8c4967 100644
--- a/service/java/com/android/server/wifi/util/XmlUtil.java
+++ b/service/java/com/android/server/wifi/util/XmlUtil.java
@@ -432,7 +432,7 @@ public class XmlUtil {
writeWepKeysToXml(out, configuration.wepKeys);
XmlUtil.writeNextValue(out, XML_TAG_WEP_TX_KEY_INDEX, configuration.wepTxKeyIndex);
XmlUtil.writeNextValue(out, XML_TAG_HIDDEN_SSID, configuration.hiddenSSID);
- XmlUtil.writeNextValue(out, XML_TAG_REQUIRE_PMF, configuration.requirePMF);
+ XmlUtil.writeNextValue(out, XML_TAG_REQUIRE_PMF, configuration.requirePmf);
XmlUtil.writeNextValue(
out, XML_TAG_ALLOWED_KEY_MGMT,
configuration.allowedKeyManagement.toByteArray());
@@ -601,7 +601,7 @@ public class XmlUtil {
configuration.hiddenSSID = (boolean) value;
break;
case XML_TAG_REQUIRE_PMF:
- configuration.requirePMF = (boolean) value;
+ configuration.requirePmf = (boolean) value;
break;
case XML_TAG_ALLOWED_KEY_MGMT:
byte[] allowedKeyMgmt = (byte[]) value;