diff options
author | David Su <dysu@google.com> | 2020-04-28 22:07:35 -0700 |
---|---|---|
committer | David Su <dysu@google.com> | 2020-04-28 22:07:35 -0700 |
commit | 5ecd7c29ee23e426e7715be27494e1689b47fa75 (patch) | |
tree | 60f7213964bae91c4366deb3c3a13232962c985c /service | |
parent | 8ad8c284ca31abac1a538f06205441937a4d6ded (diff) |
Remove WPS metrics
WPS metrics are no longer being populated.
Remove them completely.
Bug: 140938762
Test: atest FrameworksWifiTests
Test: device boots up and connects to Wifi
Change-Id: Ie398bd94ffeb8bf3d885846ee7eb59730e4d5989
Diffstat (limited to 'service')
-rw-r--r-- | service/java/com/android/server/wifi/WifiMetrics.java | 93 | ||||
-rw-r--r-- | service/proto/src/metrics.proto | 33 |
2 files changed, 3 insertions, 123 deletions
diff --git a/service/java/com/android/server/wifi/WifiMetrics.java b/service/java/com/android/server/wifi/WifiMetrics.java index 7257bc224..736b6c8a6 100644 --- a/service/java/com/android/server/wifi/WifiMetrics.java +++ b/service/java/com/android/server/wifi/WifiMetrics.java @@ -87,7 +87,6 @@ import com.android.server.wifi.proto.nano.WifiMetricsProto.WifiNetworkSuggestion import com.android.server.wifi.proto.nano.WifiMetricsProto.WifiToggleStats; import com.android.server.wifi.proto.nano.WifiMetricsProto.WifiUsabilityStats; import com.android.server.wifi.proto.nano.WifiMetricsProto.WifiUsabilityStatsEntry; -import com.android.server.wifi.proto.nano.WifiMetricsProto.WpsMetrics; import com.android.server.wifi.rtt.RttMetrics; import com.android.server.wifi.scanner.KnownBandsChannelHelper; import com.android.server.wifi.util.ExternalCallbackTracker; @@ -194,7 +193,6 @@ public class WifiMetrics { private RttMetrics mRttMetrics; private final PnoScanMetrics mPnoScanMetrics = new PnoScanMetrics(); private final WifiLinkLayerUsageStats mWifiLinkLayerUsageStats = new WifiLinkLayerUsageStats(); - private final WpsMetrics mWpsMetrics = new WpsMetrics(); private final ExperimentValues mExperimentValues = new ExperimentValues(); private Handler mHandler; private ScoringParams mScoringParams; @@ -1315,78 +1313,6 @@ public class WifiMetrics { } } - /** - * Increment total number of wps connection attempts - */ - public void incrementWpsAttemptCount() { - synchronized (mLock) { - mWpsMetrics.numWpsAttempts++; - } - } - - /** - * Increment total number of wps connection success - */ - public void incrementWpsSuccessCount() { - synchronized (mLock) { - mWpsMetrics.numWpsSuccess++; - } - } - - /** - * Increment total number of wps failure on start - */ - public void incrementWpsStartFailureCount() { - synchronized (mLock) { - mWpsMetrics.numWpsStartFailure++; - } - } - - /** - * Increment total number of wps overlap failure - */ - public void incrementWpsOverlapFailureCount() { - synchronized (mLock) { - mWpsMetrics.numWpsOverlapFailure++; - } - } - - /** - * Increment total number of wps timeout failure - */ - public void incrementWpsTimeoutFailureCount() { - synchronized (mLock) { - mWpsMetrics.numWpsTimeoutFailure++; - } - } - - /** - * Increment total number of other wps failure during connection - */ - public void incrementWpsOtherConnectionFailureCount() { - synchronized (mLock) { - mWpsMetrics.numWpsOtherConnectionFailure++; - } - } - - /** - * Increment total number of supplicant failure after wps - */ - public void incrementWpsSupplicantFailureCount() { - synchronized (mLock) { - mWpsMetrics.numWpsSupplicantFailure++; - } - } - - /** - * Increment total number of wps cancellation - */ - public void incrementWpsCancellationCount() { - synchronized (mLock) { - mWpsMetrics.numWpsCancellation++; - } - } - // Values used for indexing SystemStateEntries private static final int SCREEN_ON = 1; private static final int SCREEN_OFF = 0; @@ -3518,23 +3444,6 @@ public class WifiMetrics { pw.println(eventLine.toString()); } - pw.println("mWpsMetrics.numWpsAttempts=" - + mWpsMetrics.numWpsAttempts); - pw.println("mWpsMetrics.numWpsSuccess=" - + mWpsMetrics.numWpsSuccess); - pw.println("mWpsMetrics.numWpsStartFailure=" - + mWpsMetrics.numWpsStartFailure); - pw.println("mWpsMetrics.numWpsOverlapFailure=" - + mWpsMetrics.numWpsOverlapFailure); - pw.println("mWpsMetrics.numWpsTimeoutFailure=" - + mWpsMetrics.numWpsTimeoutFailure); - pw.println("mWpsMetrics.numWpsOtherConnectionFailure=" - + mWpsMetrics.numWpsOtherConnectionFailure); - pw.println("mWpsMetrics.numWpsSupplicantFailure=" - + mWpsMetrics.numWpsSupplicantFailure); - pw.println("mWpsMetrics.numWpsCancellation=" - + mWpsMetrics.numWpsCancellation); - mWifiPowerMetrics.dump(pw); mWifiWakeMetrics.dump(pw); @@ -4155,7 +4064,6 @@ public class WifiMetrics { mWifiLogProto.softApConnectedClientsEventsLocalOnly); } - mWifiLogProto.wpsMetrics = mWpsMetrics; mWifiLogProto.wifiPowerStats = mWifiPowerMetrics.buildProto(); mWifiLogProto.wifiRadioUsage = mWifiPowerMetrics.buildWifiRadioUsageProto(); mWifiLogProto.wifiWakeStats = mWifiWakeMetrics.buildProto(); @@ -4476,7 +4384,6 @@ public class WifiMetrics { mObservedHotspotR3ApsPerEssInScanHistogram.clear(); mSoftApEventListTethered.clear(); mSoftApEventListLocalOnly.clear(); - mWpsMetrics.clear(); mWifiWakeMetrics.clear(); mObserved80211mcApInScanHistogram.clear(); mWifiIsUnusableList.clear(); diff --git a/service/proto/src/metrics.proto b/service/proto/src/metrics.proto index 627c24529..0202ac14e 100644 --- a/service/proto/src/metrics.proto +++ b/service/proto/src/metrics.proto @@ -372,8 +372,9 @@ message WifiLog { // SoftAP event list tracking sessions and client counts in local only mode repeated SoftApConnectedClientsEvent soft_ap_connected_clients_events_local_only = 90; - // Wps connection metrics - optional WpsMetrics wps_metrics = 91; + // WPS connection metrics - removed + reserved 91; + reserved "wps_metrics"; // Wifi power statistics optional WifiPowerStats wifi_power_stats = 92; @@ -1793,34 +1794,6 @@ message SoftApConnectedClientsEvent { optional bool client_control_is_enabled = 10; } -// Wps connection metrics -// Keeps track of Wi-Fi Protected Setup usage -message WpsMetrics { - // Total number of wps connection attempts - optional int32 num_wps_attempts = 1; - - // Total number of wps connection successes - optional int32 num_wps_success = 2; - - // Total number of wps failures on start - optional int32 num_wps_start_failure = 3; - - // Total number of wps overlap failure - optional int32 num_wps_overlap_failure = 4; - - // Total number of wps timeout failure - optional int32 num_wps_timeout_failure = 5; - - // Total number of other wps failure during connection - optional int32 num_wps_other_connection_failure = 6; - - // Total number of supplicant failure after wps - optional int32 num_wps_supplicant_failure = 7; - - // Total number of wps cancellation - optional int32 num_wps_cancellation = 8; -} - // Power stats for Wifi message WifiPowerStats { |