diff options
author | Quang Luong <qal@google.com> | 2020-02-12 00:01:38 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2020-02-12 00:01:38 +0000 |
commit | 7a68e9ad1b9418a5a8486f9ad7ac701a1d6c3877 (patch) | |
tree | 29946515df7d3b9c43ffadb6ef297c4e7a4d2bc2 /libs | |
parent | 2e72c0836e85caede556216fbe91daea25923e4b (diff) | |
parent | cab4ea618e7025cda04880e3aaff6a1f08960a79 (diff) |
Merge "[WifiTrackerLib] Fix "Saved by xxx" summary in 'Saved networks'"
Diffstat (limited to 'libs')
12 files changed, 73 insertions, 54 deletions
diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/OsuWifiEntry.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/OsuWifiEntry.java index 4e0f373ec..244dd7949 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/OsuWifiEntry.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/OsuWifiEntry.java @@ -56,8 +56,9 @@ class OsuWifiEntry extends WifiEntry { */ OsuWifiEntry(@NonNull Context context, @NonNull Handler callbackHandler, @NonNull OsuProvider osuProvider, - @NonNull WifiManager wifiManager) throws IllegalArgumentException { - super(callbackHandler, wifiManager, false /* forSavedNetworksPage */); + @NonNull WifiManager wifiManager, + boolean forSavedNetworksPage) throws IllegalArgumentException { + super(callbackHandler, wifiManager, forSavedNetworksPage); checkNotNull(osuProvider, "Cannot construct with null osuProvider!"); diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointNetworkDetailsTracker.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointNetworkDetailsTracker.java index c5a949e15..bdfacca9e 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointNetworkDetailsTracker.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointNetworkDetailsTracker.java @@ -76,7 +76,7 @@ class PasspointNetworkDetailsTracker extends NetworkDetailsTracker { checkNotNull(passpointConfig, "Cannot find PasspointConfiguration with matching FQDN!"); mChosenEntry = new PasspointWifiEntry(mContext, mMainHandler, passpointConfig, - mWifiManager); + mWifiManager, false /* forSavedNetworksPage */); cacheNewScanResults(); conditionallyUpdateScanResults(true /* lastScanSucceeded */); conditionallyUpdateConfig(); diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointWifiEntry.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointWifiEntry.java index 3e3ec00cd..db773ea64 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointWifiEntry.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/PasspointWifiEntry.java @@ -76,8 +76,9 @@ public class PasspointWifiEntry extends WifiEntry { */ PasspointWifiEntry(@NonNull Context context, @NonNull Handler callbackHandler, @NonNull PasspointConfiguration passpointConfig, - @NonNull WifiManager wifiManager) throws IllegalArgumentException { - super(callbackHandler, wifiManager, false /* forSavedNetworksPage */); + @NonNull WifiManager wifiManager, + boolean forSavedNetworksPage) throws IllegalArgumentException { + super(callbackHandler, wifiManager, forSavedNetworksPage); checkNotNull(passpointConfig, "Cannot construct with null PasspointConfiguration!"); diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/SavedNetworkTracker.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/SavedNetworkTracker.java index 3f604933e..7bab36a0a 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/SavedNetworkTracker.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/SavedNetworkTracker.java @@ -286,7 +286,8 @@ public class SavedNetworkTracker extends BaseWifiTracker { } else { if (changeReason != WifiManager.CHANGE_REASON_REMOVED) { mStandardWifiEntryCache.put(key, - new StandardWifiEntry(mContext, mMainHandler, key, config, mWifiManager)); + new StandardWifiEntry(mContext, mMainHandler, key, config, mWifiManager, + true /* forSavedNetworksPage */)); } } } @@ -314,7 +315,7 @@ public class SavedNetworkTracker extends BaseWifiTracker { for (String key : wifiConfigsByKey.keySet()) { mStandardWifiEntryCache.put(key, new StandardWifiEntry(mContext, mMainHandler, key, wifiConfigsByKey.get(key), - mWifiManager)); + mWifiManager, true /* forSavedNetworksPage */)); } } @@ -345,7 +346,7 @@ public class SavedNetworkTracker extends BaseWifiTracker { for (String key : passpointConfigsByKey.keySet()) { mPasspointWifiEntryCache.put(key, new PasspointWifiEntry(mContext, mMainHandler, passpointConfigsByKey.get(key), - mWifiManager)); + mWifiManager, true /* forSavedNetworksPage */)); } } diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardNetworkDetailsTracker.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardNetworkDetailsTracker.java index 7ca4e20d0..5a95eb9b2 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardNetworkDetailsTracker.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardNetworkDetailsTracker.java @@ -66,7 +66,8 @@ class StandardNetworkDetailsTracker extends NetworkDetailsTracker { String key) { super(lifecycle, context, wifiManager, connectivityManager, networkScoreManager, mainHandler, workerHandler, clock, maxScanAgeMillis, scanIntervalMillis, TAG); - mChosenEntry = new StandardWifiEntry(mContext, mMainHandler, key, mWifiManager, false); + mChosenEntry = new StandardWifiEntry(mContext, mMainHandler, key, mWifiManager, + false /* forSavedNetworksPage */); cacheNewScanResults(); conditionallyUpdateScanResults(true /* lastScanSucceeded */); conditionallyUpdateConfig(); diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardWifiEntry.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardWifiEntry.java index 7b5ca8aac..78141b64c 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardWifiEntry.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/StandardWifiEntry.java @@ -112,8 +112,9 @@ public class StandardWifiEntry extends WifiEntry { StandardWifiEntry(@NonNull Context context, @NonNull Handler callbackHandler, @NonNull String key, @NonNull List<ScanResult> scanResults, - @NonNull WifiManager wifiManager) throws IllegalArgumentException { - this(context, callbackHandler, key, wifiManager, false /* forSavedNetworksPage */); + @NonNull WifiManager wifiManager, + boolean forSavedNetworksPage) throws IllegalArgumentException { + this(context, callbackHandler, key, wifiManager, forSavedNetworksPage); checkNotNull(scanResults, "Cannot construct with null ScanResult list!"); if (scanResults.isEmpty()) { @@ -125,8 +126,9 @@ public class StandardWifiEntry extends WifiEntry { StandardWifiEntry(@NonNull Context context, @NonNull Handler callbackHandler, @NonNull String key, @NonNull WifiConfiguration config, - @NonNull WifiManager wifiManager) throws IllegalArgumentException { - this(context, callbackHandler, key, wifiManager, false /* forSavedNetworksPage */); + @NonNull WifiManager wifiManager, + boolean forSavedNetworksPage) throws IllegalArgumentException { + this(context, callbackHandler, key, wifiManager, forSavedNetworksPage); checkNotNull(config, "Cannot construct with null config!"); checkNotNull(config.SSID, "Supplied config must have an SSID!"); diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiEntry.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiEntry.java index 7ac305fc7..4753cf3c3 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiEntry.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiEntry.java @@ -35,6 +35,7 @@ import androidx.annotation.IntDef; import androidx.annotation.MainThread; import androidx.annotation.NonNull; import androidx.annotation.Nullable; +import androidx.annotation.VisibleForTesting; import androidx.annotation.WorkerThread; import java.lang.annotation.Retention; @@ -177,7 +178,9 @@ public abstract class WifiEntry implements Comparable<WifiEntry> { */ protected static final int MAX_VERBOSE_LOG_DISPLAY_SCANRESULT_COUNT = 4; - protected final boolean mForSavedNetworksPage; + @VisibleForTesting(otherwise = VisibleForTesting.PROTECTED) + final boolean mForSavedNetworksPage; + protected final WifiManager mWifiManager; // Callback associated with this WifiEntry. Subclasses should call its methods appropriately. diff --git a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiPickerTracker.java b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiPickerTracker.java index ad386d223..13ea43d2a 100644 --- a/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiPickerTracker.java +++ b/libs/WifiTrackerLib/src/com/android/wifitrackerlib/WifiPickerTracker.java @@ -314,7 +314,7 @@ public class WifiPickerTracker extends BaseWifiTracker { // Create new StandardWifiEntry objects for each leftover group of scan results. for (Map.Entry<String, List<ScanResult>> e: scanResultsByKey.entrySet()) { final StandardWifiEntry newEntry = new StandardWifiEntry(mContext, mMainHandler, - e.getKey(), e.getValue(), mWifiManager); + e.getKey(), e.getValue(), mWifiManager, false /* forSavedNetworksPage */); // Populate with a saved config, if available newEntry.updateConfig(mWifiConfigCache.get(newEntry.getKey())); mStandardWifiEntryCache.put(newEntry.getKey(), newEntry); @@ -342,7 +342,8 @@ public class WifiPickerTracker extends BaseWifiTracker { // Create PasspointWifiEntry if one doesn't exist for the seen key yet. if (!mPasspointWifiEntryCache.containsKey(key)) { mPasspointWifiEntryCache.put(key, new PasspointWifiEntry(mContext, - mMainHandler, mPasspointConfigCache.get(key), mWifiManager)); + mMainHandler, mPasspointConfigCache.get(key), mWifiManager, + false /* forSavedNetworksPage */)); } mPasspointWifiEntryCache.get(key).updateScanResultInfo(wifiConfig, homeScans, roamingScans); @@ -363,7 +364,7 @@ public class WifiPickerTracker extends BaseWifiTracker { final String key = osuProviderToOsuWifiEntryKey(osuProvider); if (!mOsuWifiEntryCache.containsKey(key)) { mOsuWifiEntryCache.put(key, new OsuWifiEntry(mContext, - mMainHandler, osuProvider, mWifiManager)); + mMainHandler, osuProvider, mWifiManager, false /* forSavedNetworksPage */)); } mOsuWifiEntryCache.get(key).updateScanResultInfo(osuProviderToScans.get(osuProvider)); } @@ -509,7 +510,8 @@ public class WifiPickerTracker extends BaseWifiTracker { .findAny().ifPresent(config -> { final StandardWifiEntry connectedEntry = new StandardWifiEntry(mContext, mMainHandler, - wifiConfigToStandardWifiEntryKey(config), config, mWifiManager); + wifiConfigToStandardWifiEntryKey(config), config, mWifiManager, + false /* forSavedNetworksPage */); connectedEntry.updateConnectionInfo(wifiInfo, networkInfo); mStandardWifiEntryCache.put(connectedEntry.getKey(), connectedEntry); }); @@ -536,7 +538,8 @@ public class WifiPickerTracker extends BaseWifiTracker { fqdnToPasspointWifiEntryKey(connectedFqdn))) .findAny().ifPresent(config -> { final PasspointWifiEntry connectedEntry = - new PasspointWifiEntry(mContext, mMainHandler, config, mWifiManager); + new PasspointWifiEntry(mContext, mMainHandler, config, mWifiManager, + false /* forSavedNetworksPage */); connectedEntry.updateConnectionInfo(wifiInfo, networkInfo); mPasspointWifiEntryCache.put(connectedEntry.getKey(), connectedEntry); }); diff --git a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/PasspointWifiEntryTest.java b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/PasspointWifiEntryTest.java index 2c00d32aa..0a1870e58 100644 --- a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/PasspointWifiEntryTest.java +++ b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/PasspointWifiEntryTest.java @@ -60,7 +60,7 @@ public class PasspointWifiEntryTest { when(mMockResources.getString(R.string.wifi_passpoint_expired)).thenReturn(expired); PasspointWifiEntry passpointWifiEntry = new PasspointWifiEntry(mMockContext, mTestHandler, - passpointConfiguration, mMockWifiManager); + passpointConfiguration, mMockWifiManager, false /* forSavedNetworksPage */); assertThat(passpointWifiEntry.getSummary()).isNotEqualTo(expired); } @@ -71,7 +71,7 @@ public class PasspointWifiEntryTest { String expired = "Expired"; when(mMockResources.getString(R.string.wifi_passpoint_expired)).thenReturn(expired); PasspointWifiEntry passpointWifiEntry = new PasspointWifiEntry(mMockContext, mTestHandler, - passpointConfiguration, mMockWifiManager); + passpointConfiguration, mMockWifiManager, false /* forSavedNetworksPage */); PasspointWifiEntry spyEntry = spy(passpointWifiEntry); when(spyEntry.isExpired()).thenReturn(true); @@ -89,7 +89,7 @@ public class PasspointWifiEntryTest { @Test public void testGetMeteredChoice_afterSetMeteredChoice_getCorrectValue() { PasspointWifiEntry entry = new PasspointWifiEntry(mMockContext, mTestHandler, - getPasspointConfiguration(), mMockWifiManager); + getPasspointConfiguration(), mMockWifiManager, false /* forSavedNetworksPage */); entry.setMeteredChoice(WifiEntry.METERED_CHOICE_UNMETERED); diff --git a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/SavedNetworkTrackerTest.java b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/SavedNetworkTrackerTest.java index 9dd2f6ad9..ae4d671ba 100644 --- a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/SavedNetworkTrackerTest.java +++ b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/SavedNetworkTrackerTest.java @@ -205,7 +205,9 @@ public class SavedNetworkTrackerTest { any(), any(), any()); mTestLooper.dispatchAll(); - assertThat(savedNetworkTracker.getSavedWifiEntries().stream().map(WifiEntry::getTitle) + assertThat(savedNetworkTracker.getSavedWifiEntries().stream() + .filter(entry -> entry.mForSavedNetworksPage) + .map(WifiEntry::getTitle) .collect(Collectors.toSet())) .containsExactly("ssid0", "ssid1", "ssid2"); } @@ -231,7 +233,10 @@ public class SavedNetworkTrackerTest { .putExtra(WifiManager.EXTRA_CHANGE_REASON, WifiManager.CHANGE_REASON_ADDED)); - assertThat(savedNetworkTracker.getSavedWifiEntries()).hasSize(1); + assertThat(savedNetworkTracker.getSavedWifiEntries().stream() + .filter(entry -> entry.mForSavedNetworksPage) + .collect(Collectors.toSet())) + .hasSize(1); } /** diff --git a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java index 09dfb033c..e4e6d49f6 100644 --- a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java +++ b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java @@ -109,7 +109,7 @@ public class StandardWifiEntryTest { try { new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - new ArrayList<>(), mMockWifiManager); + new ArrayList<>(), mMockWifiManager, false /* forSavedNetworksPage */); fail("Empty scan list should have thrown exception"); } catch (IllegalArgumentException e) { // Test succeeded @@ -126,7 +126,8 @@ public class StandardWifiEntryTest { ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), Arrays.asList( buildScanResult("ssid0", "bssid0", 0, GOOD_RSSI), - buildScanResult("ssid1", "bssid1", 0, GOOD_RSSI)), mMockWifiManager); + buildScanResult("ssid1", "bssid1", 0, GOOD_RSSI)), + mMockWifiManager, false /* forSavedNetworksPage */); fail("Scan list with different SSIDs should have thrown exception"); } catch (IllegalArgumentException e) { // Test succeeded @@ -143,7 +144,8 @@ public class StandardWifiEntryTest { Arrays.asList( buildScanResult("ssid", "bssid0", 0, GOOD_RSSI), buildScanResult("ssid", "bssid1", 0, OKAY_RSSI), - buildScanResult("ssid", "bssid2", 0, BAD_RSSI)), mMockWifiManager); + buildScanResult("ssid", "bssid2", 0, BAD_RSSI)), + mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.getLevel()).isEqualTo(GOOD_LEVEL); } @@ -159,10 +161,10 @@ public class StandardWifiEntryTest { final StandardWifiEntry unsecureEntry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - Arrays.asList(unsecureScan), mMockWifiManager); + Arrays.asList(unsecureScan), mMockWifiManager, false /* forSavedNetworksPage */); final StandardWifiEntry secureEntry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - Arrays.asList(secureScan), mMockWifiManager); + Arrays.asList(secureScan), mMockWifiManager, false /* forSavedNetworksPage */); assertThat(unsecureEntry.getSecurity()).isEqualTo(WifiEntry.SECURITY_NONE); assertThat(secureEntry.getSecurity()).isEqualTo(WifiEntry.SECURITY_EAP); @@ -175,8 +177,8 @@ public class StandardWifiEntryTest { public void testUpdateScanResultInfo_mismatchedSsids_throwsException() { final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid0", SECURITY_EAP), - Arrays.asList( - buildScanResult("ssid0", "bssid0", 0, GOOD_RSSI)), mMockWifiManager); + Arrays.asList(buildScanResult("ssid0", "bssid0", 0, GOOD_RSSI)), + mMockWifiManager, false /* forSavedNetworksPage */); try { entry.updateScanResultInfo(Arrays.asList( @@ -194,8 +196,8 @@ public class StandardWifiEntryTest { public void testUpdateScanResultInfo_notifiesListener() { final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - Arrays.asList( - buildScanResult("ssid", "bssid", 0)), mMockWifiManager); + Arrays.asList(buildScanResult("ssid", "bssid", 0)), + mMockWifiManager, false /* forSavedNetworksPage */); entry.setListener(mMockListener); entry.updateScanResultInfo(Arrays.asList(buildScanResult("ssid", "bssid", 1))); @@ -211,8 +213,8 @@ public class StandardWifiEntryTest { public void testUpdateScanResultInfo_updatesLevel() { final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - Arrays.asList( - buildScanResult("ssid", "bssid", 0, BAD_RSSI)), mMockWifiManager); + Arrays.asList(buildScanResult("ssid", "bssid", 0, BAD_RSSI)), + mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.getLevel()).isEqualTo(BAD_LEVEL); @@ -228,7 +230,7 @@ public class StandardWifiEntryTest { config.setSecurityParams(WifiConfiguration.SECURITY_TYPE_EAP); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.getTitle()).isEqualTo("ssid"); } @@ -240,7 +242,7 @@ public class StandardWifiEntryTest { config.setSecurityParams(WifiConfiguration.SECURITY_TYPE_EAP); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.getSecurity()).isEqualTo(WifiEntry.SECURITY_EAP); } @@ -252,7 +254,7 @@ public class StandardWifiEntryTest { config.setSecurityParams(WifiConfiguration.SECURITY_TYPE_EAP); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); final WifiConfiguration config2 = new WifiConfiguration(config); config2.SSID = "\"ssid2\""; @@ -271,7 +273,7 @@ public class StandardWifiEntryTest { config.setSecurityParams(WifiConfiguration.SECURITY_TYPE_WEP); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_WEP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); final WifiConfiguration config2 = new WifiConfiguration(config); config2.setSecurityParams(WifiConfiguration.SECURITY_TYPE_EAP); @@ -289,7 +291,7 @@ public class StandardWifiEntryTest { scan.capabilities = "EAP"; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - Arrays.asList(scan), mMockWifiManager); + Arrays.asList(scan), mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.isSaved()).isFalse(); @@ -310,7 +312,7 @@ public class StandardWifiEntryTest { config.networkId = 1; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); assertThat(entry.isSaved()).isTrue(); @@ -327,7 +329,7 @@ public class StandardWifiEntryTest { config.networkId = 1; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); when(mMockWifiInfo.getNetworkId()).thenReturn(1); when(mMockWifiInfo.getRssi()).thenReturn(GOOD_RSSI); when(mMockNetworkInfo.getDetailedState()).thenReturn(NetworkInfo.DetailedState.CONNECTED); @@ -346,7 +348,7 @@ public class StandardWifiEntryTest { config.networkId = 1; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); when(mMockWifiInfo.getNetworkId()).thenReturn(2); when(mMockWifiInfo.getRssi()).thenReturn(-50); when(mMockNetworkInfo.getDetailedState()).thenReturn(NetworkInfo.DetailedState.CONNECTED); @@ -362,7 +364,7 @@ public class StandardWifiEntryTest { final ScanResult scan = buildScanResult("ssid", "bssid", 0, GOOD_RSSI); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - Arrays.asList(scan), mMockWifiManager); + Arrays.asList(scan), mMockWifiManager, false /* forSavedNetworksPage */); final WifiConfiguration config = new WifiConfiguration(); config.SSID = "\"ssid\""; config.networkId = 1; @@ -377,8 +379,8 @@ public class StandardWifiEntryTest { public void testConnect_openNetwork_callsConnect() { final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), - Arrays.asList( - buildScanResult("ssid", "bssid0", 0, GOOD_RSSI)), mMockWifiManager); + Arrays.asList(buildScanResult("ssid", "bssid0", 0, GOOD_RSSI)), + mMockWifiManager, false /* forSavedNetworksPage */); entry.connect(null /* ConnectCallback */); @@ -391,7 +393,7 @@ public class StandardWifiEntryTest { secureScan.capabilities = "PSK"; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_PSK), - Arrays.asList(secureScan), mMockWifiManager); + Arrays.asList(secureScan), mMockWifiManager, false /* forSavedNetworksPage */); entry.setListener(mMockListener); entry.connect(mMockConnectCallback); @@ -415,7 +417,7 @@ public class StandardWifiEntryTest { final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - spyConfig, mMockWifiManager); + spyConfig, mMockWifiManager, false /* forSavedNetworksPage */); final String macAddress = entry.getMacAddress(); @@ -433,7 +435,7 @@ public class StandardWifiEntryTest { when(mMockWifiManager.getFactoryMacAddresses()).thenReturn(new String[]{factoryMac}); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); final String macAddress = entry.getMacAddress(); @@ -479,7 +481,7 @@ public class StandardWifiEntryTest { final StandardWifiEntry pskWifiEntry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey(pskScanResult.SSID, SECURITY_PSK), - Arrays.asList(pskScanResult), mMockWifiManager); + Arrays.asList(pskScanResult), mMockWifiManager, false /* forSavedNetworksPage */); assertThat(pskWifiEntry.canEasyConnect()).isFalse(); } @@ -525,7 +527,7 @@ public class StandardWifiEntryTest { config.networkId = 1; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_EAP), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); when(mMockWifiInfo.getNetworkId()).thenReturn(1); when(mMockWifiInfo.getRssi()).thenReturn(GOOD_RSSI); when(mMockNetworkInfo.getDetailedState()).thenReturn(NetworkInfo.DetailedState.CONNECTED); @@ -542,7 +544,7 @@ public class StandardWifiEntryTest { config.setSecurityParams(wifiConfigurationSecureType); return new StandardWifiEntry(mMockContext, mTestHandler, wifiConfigToStandardWifiEntryKey(config), - config, mMockWifiManager); + config, mMockWifiManager, false /* forSavedNetworksPage */); } @Test @@ -570,7 +572,7 @@ public class StandardWifiEntryTest { config.networkId = networkId; final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_NONE), config, - mMockWifiManager); + mMockWifiManager, false /* forSavedNetworksPage */); entry.updateConnectionInfo(wifiInfo, networkInfo); diff --git a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/UtilsTest.java b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/UtilsTest.java index c88ca2343..7ed2d1ac6 100644 --- a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/UtilsTest.java +++ b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/UtilsTest.java @@ -366,7 +366,7 @@ public class UtilsTest { final WifiManager mockWifiManager = mock(WifiManager.class); final StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, wifiConfigToStandardWifiEntryKey(config), config, - mockWifiManager); + mockWifiManager, false /* forSavedNetworksPage */); final WifiInfo mockWifiInfo = mock(WifiInfo.class); final NetworkInfo mockNetworkInfo = mock(NetworkInfo.class); |