diff options
author | android-build-team Robot <android-build-team-robot@google.com> | 2020-09-17 23:05:45 +0000 |
---|---|---|
committer | android-build-team Robot <android-build-team-robot@google.com> | 2020-09-17 23:05:45 +0000 |
commit | 802b2b79f0521f5de6b777e634e54710b7b67ca9 (patch) | |
tree | 1baa3fe6b2382d8ac29fa0ee3b9baa0505305d65 | |
parent | c15d5fa3860b99f51c39a3a0572668faff43212c (diff) | |
parent | 5c4bf8901180740a1af479677bf3417ffe9812fe (diff) |
Snap for 6844997 from 5c4bf8901180740a1af479677bf3417ffe9812fe to rvc-qpr1-release
Change-Id: I1040c2b4de0d6a00b36f7f43989f6c6e525ebcca
4 files changed, 3 insertions, 22 deletions
diff --git a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java index 24449fb3a..e9194f315 100644 --- a/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java +++ b/libs/WifiTrackerLib/tests/src/com/android/wifitrackerlib/StandardWifiEntryTest.java @@ -804,27 +804,6 @@ public class StandardWifiEntryTest { } @Test - public void testShouldEditBeforeConnect_securedNetwork_returnTrueIfNeverConnected() { - // Test never connected. - WifiConfiguration wifiConfig = spy(new WifiConfiguration()); - wifiConfig.SSID = "\"ssid\""; - wifiConfig.setSecurityParams(WifiConfiguration.SECURITY_TYPE_PSK); - StandardWifiEntry entry = new StandardWifiEntry(mMockContext, mTestHandler, - ssidAndSecurityToStandardWifiEntryKey("ssid", SECURITY_PSK), - wifiConfig, mMockWifiManager, mMockScoreCache, false /* forSavedNetworksPage */); - NetworkSelectionStatus networkSelectionStatus = - spy(new NetworkSelectionStatus.Builder().build()); - doReturn(networkSelectionStatus).when(wifiConfig).getNetworkSelectionStatus(); - - assertThat(entry.shouldEditBeforeConnect()).isTrue(); - - // Test ever connected. - doReturn(true).when(networkSelectionStatus).hasEverConnected(); - - assertThat(entry.shouldEditBeforeConnect()).isFalse(); - } - - @Test public void testShouldEditBeforeConnect_authenticationFailure_returnTrue() { // Test DISABLED_AUTHENTICATION_FAILURE. WifiConfiguration wifiConfig = spy(new WifiConfiguration()); diff --git a/service/java/com/android/server/wifi/NetworkSuggestionNominator.java b/service/java/com/android/server/wifi/NetworkSuggestionNominator.java index b174be5e0..8c901cff9 100644 --- a/service/java/com/android/server/wifi/NetworkSuggestionNominator.java +++ b/service/java/com/android/server/wifi/NetworkSuggestionNominator.java @@ -246,6 +246,7 @@ public class NetworkSuggestionNominator implements WifiNetworkSelector.NetworkNo mLocalLog.log("Failed to add network suggestion"); continue; } + mWifiConfigManager.allowAutojoin(result.getNetworkId(), config.allowAutojoin); WifiConfiguration currentWCmConfiguredNetwork = mWifiConfigManager.getConfiguredNetwork(result.netId); // Try to enable network selection @@ -276,6 +277,7 @@ public class NetworkSuggestionNominator implements WifiNetworkSelector.NetworkNo mLocalLog.log("Failed to add network suggestion"); return null; } + mWifiConfigManager.allowAutojoin(result.getNetworkId(), wifiConfiguration.allowAutojoin); if (!mWifiConfigManager.updateNetworkSelectionStatus(result.getNetworkId(), WifiConfiguration.NetworkSelectionStatus.DISABLED_NONE)) { mLocalLog.log("Failed to make network suggestion selectable"); diff --git a/service/java/com/android/server/wifi/WifiConfigManager.java b/service/java/com/android/server/wifi/WifiConfigManager.java index 45a5d90b9..83cabf756 100644 --- a/service/java/com/android/server/wifi/WifiConfigManager.java +++ b/service/java/com/android/server/wifi/WifiConfigManager.java @@ -1132,7 +1132,6 @@ public class WifiConfigManager { newInternalConfig.noInternetAccessExpected = externalConfig.noInternetAccessExpected; newInternalConfig.ephemeral = externalConfig.ephemeral; newInternalConfig.osu = externalConfig.osu; - newInternalConfig.trusted = externalConfig.trusted; newInternalConfig.fromWifiNetworkSuggestion = externalConfig.fromWifiNetworkSuggestion; newInternalConfig.fromWifiNetworkSpecifier = externalConfig.fromWifiNetworkSpecifier; newInternalConfig.useExternalScores = externalConfig.useExternalScores; diff --git a/tests/wifitests/src/com/android/server/wifi/NetworkSuggestionNominatorTest.java b/tests/wifitests/src/com/android/server/wifi/NetworkSuggestionNominatorTest.java index 9c5631882..1e0677316 100644 --- a/tests/wifitests/src/com/android/server/wifi/NetworkSuggestionNominatorTest.java +++ b/tests/wifitests/src/com/android/server/wifi/NetworkSuggestionNominatorTest.java @@ -1046,6 +1046,7 @@ public class NetworkSuggestionNominatorTest extends WifiBaseTest { ArgumentCaptor.forClass(WifiConfiguration.class); verify(mWifiConfigManager, times(candidates.length)).addOrUpdateNetwork( wifiConfigurationCaptor.capture(), anyInt(), anyString()); + verify(mWifiConfigManager, times(candidates.length)).allowAutojoin(anyInt(), anyBoolean()); for (int i = 0; i < candidates.length; i++) { WifiConfiguration addedWifiConfiguration = null; for (WifiConfiguration configuration : wifiConfigurationCaptor.getAllValues()) { |