WifiService: Add API for scan always available toggle

We still use the Settings.Global value to persist state. Will migrate to
SharedPreferences in a follow up CL.

Bug: 148514485
Test: atest com.android.server.wifi
Test: Verified wifi wifi scan toggle in location settings.
Change-Id: Id81c775f0ab252b1d41a7b66308502d71efee3e0

5 files changed, 64 insertions, 33 deletions

diff --git a/service/java/com/android/server/wifi/BaseWifiService.java b/service/java/com/android/server/wifi/BaseWifiService.java
index 08a7a9e7f..16e8eb5ee 100644
--- a/service/java/com/android/server/wifi/BaseWifiService.java
+++ b/service/java/com/android/server/wifi/BaseWifiService.java
@@ -279,6 +279,11 @@ public class BaseWifiService extends IWifiManager.Stub {
     }
 
     @Override
+    public void setScanAlwaysAvailable(boolean isAvailable) {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
     public boolean isScanAlwaysAvailable() {
         throw new UnsupportedOperationException();
     }
diff --git a/service/java/com/android/server/wifi/WifiServiceImpl.java b/service/java/com/android/server/wifi/WifiServiceImpl.java
index 9f3532312..4199e6ffe 100644
--- a/service/java/com/android/server/wifi/WifiServiceImpl.java
+++ b/service/java/com/android/server/wifi/WifiServiceImpl.java
@@ -41,7 +41,6 @@ import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageManager;
 import android.content.pm.ParceledListSlice;
 import android.content.pm.ResolveInfo;
-import android.database.ContentObserver;
 import android.net.DhcpInfo;
 import android.net.DhcpResultsParcelable;
 import android.net.InetAddresses;
@@ -344,7 +343,6 @@ public class WifiServiceImpl extends BaseWifiService {
             Log.i(TAG,
                     "WifiService starting up with Wi-Fi " + (wifiEnabled ? "enabled" : "disabled"));
 
-            registerForScanModeChange();
             mContext.registerReceiver(
                     new BroadcastReceiver() {
                         @Override
@@ -1886,6 +1884,17 @@ public class WifiServiceImpl extends BaseWifiService {
     }
 
     /**
+     * see {@link android.net.wifi.WifiManager#setScanAlwaysAvailable(boolean)}
+     */
+    @Override
+    public void setScanAlwaysAvailable(boolean isAvailable) {
+        enforceNetworkSettingsPermission();
+        mLog.info("setScanAlwaysAvailable uid=%").c(Binder.getCallingUid()).flush();
+        mSettingsStore.handleWifiScanAlwaysAvailableToggled(isAvailable);
+        mActiveModeWarden.scanAlwaysModeChanged();
+    }
+
+    /**
      * see {@link android.net.wifi.WifiManager#isScanAlwaysAvailable()}
      */
     @Override
@@ -3021,23 +3030,6 @@ public class WifiServiceImpl extends BaseWifiService {
         }
     };
 
-    /**
-     * Observes settings changes to scan always mode.
-     */
-    private void registerForScanModeChange() {
-        ContentObserver contentObserver = new ContentObserver(null) {
-            @Override
-            public void onChange(boolean selfChange) {
-                mSettingsStore.handleWifiScanAlwaysAvailableToggled();
-                mActiveModeWarden.scanAlwaysModeChanged();
-            }
-        };
-        mFrameworkFacade.registerContentObserver(mContext,
-                Settings.Global.getUriFor(Settings.Global.WIFI_SCAN_ALWAYS_AVAILABLE),
-                false, contentObserver);
-
-    }
-
     private void registerForBroadcasts() {
         IntentFilter intentFilter = new IntentFilter();
         intentFilter.addAction(Intent.ACTION_PACKAGE_FULLY_REMOVED);
diff --git a/service/java/com/android/server/wifi/WifiSettingsStore.java b/service/java/com/android/server/wifi/WifiSettingsStore.java
index a2f962f62..94690fb13 100644
--- a/service/java/com/android/server/wifi/WifiSettingsStore.java
+++ b/service/java/com/android/server/wifi/WifiSettingsStore.java
@@ -116,8 +116,8 @@ public class WifiSettingsStore {
         return true;
     }
 
-    synchronized void handleWifiScanAlwaysAvailableToggled() {
-        mScanAlwaysAvailable = getPersistedScanAlwaysAvailable();
+    synchronized void handleWifiScanAlwaysAvailableToggled(boolean isAvailable) {
+        persistScanAlwaysAvailableState(isAvailable);
     }
 
     void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
@@ -131,6 +131,12 @@ public class WifiSettingsStore {
         Settings.Global.putInt(cr, Settings.Global.WIFI_ON, state);
     }
 
+    private void persistScanAlwaysAvailableState(boolean isAvailable) {
+        final ContentResolver cr = mContext.getContentResolver();
+        mScanAlwaysAvailable = isAvailable;
+        Settings.Global.putInt(cr, Settings.Global.WIFI_SCAN_ALWAYS_AVAILABLE, isAvailable ? 1 : 0);
+    }
+
     /* Does Wi-Fi need to be disabled when airplane mode is on ? */
     private boolean isAirplaneSensitive() {
         String airplaneModeRadios = Settings.Global.getString(mContext.getContentResolver(),
diff --git a/tests/wifitests/src/com/android/server/wifi/SoftApStoreDataTest.java b/tests/wifitests/src/com/android/server/wifi/SoftApStoreDataTest.java
index 4275518a9..f3317fdd6 100644
--- a/tests/wifitests/src/com/android/server/wifi/SoftApStoreDataTest.java
+++ b/tests/wifitests/src/com/android/server/wifi/SoftApStoreDataTest.java
@@ -23,6 +23,7 @@ import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 import static org.mockito.Mockito.withSettings;
@@ -140,11 +141,21 @@ public class SoftApStoreDataTest extends WifiBaseTest {
     @Mock private Context mContext;
     @Mock SoftApStoreData.DataSource mDataSource;
     @Mock WifiOemConfigStoreMigrationDataHolder mWifiOemConfigStoreMigrationDataHolder;
+    @Mock private WifiOemMigrationHook.SettingsMigrationData mOemMigrationData;
+    MockitoSession mSession;
     SoftApStoreData mSoftApStoreData;
 
     @Before
     public void setUp() throws Exception {
         MockitoAnnotations.initMocks(this);
+        mSession = ExtendedMockito.mockitoSession()
+                .mockStatic(WifiOemMigrationHook.class, withSettings().lenient())
+                .strictness(Strictness.LENIENT)
+                .startMocking();
+        when(WifiOemMigrationHook.loadFromSettings(any(Context.class)))
+                .thenReturn(mOemMigrationData);
+        when(mOemMigrationData.isSoftApTimeoutEnabled()).thenReturn(true);
+
         mSoftApStoreData =
                 new SoftApStoreData(mContext, mDataSource, mWifiOemConfigStoreMigrationDataHolder);
         TEST_BLOCKEDLIST.add(MacAddress.fromString(TEST_BLOCKED_CLIENT));
@@ -158,6 +169,7 @@ public class SoftApStoreDataTest extends WifiBaseTest {
     public void cleanup() {
         TEST_BLOCKEDLIST.clear();
         TEST_ALLOWEDLIST.clear();
+        mSession.finishMocking();
     }
 
     /**
@@ -463,16 +475,9 @@ public class SoftApStoreDataTest extends WifiBaseTest {
      */
     @Test
     public void deserializeSoftApWithNoAutoShutdownTag() throws Exception {
-        MockitoSession session = ExtendedMockito.mockitoSession()
-                .mockStatic(WifiConfigStore.class, withSettings().lenient())
-                .strictness(Strictness.LENIENT)
-                .startMocking();
-        WifiOemMigrationHook.SettingsMigrationData migrationData = mock(
-                WifiOemMigrationHook.SettingsMigrationData.class);
-        when(WifiOemMigrationHook.loadFromSettings(any())).thenReturn(migrationData);
 
         // Toggle on when migrating.
-        when(migrationData.isSoftApTimeoutEnabled()).thenReturn(true);
+        when(mOemMigrationData.isSoftApTimeoutEnabled()).thenReturn(true);
         deserializeData(
                 TEST_SOFTAP_CONFIG_XML_STRING_WITH_ALL_CONFIG_EXCEPT_AUTO_SHUTDOWN.getBytes());
         ArgumentCaptor<SoftApConfiguration> softapConfigCaptor =
@@ -484,16 +489,14 @@ public class SoftApStoreDataTest extends WifiBaseTest {
         assertTrue(softApConfig.isAutoShutdownEnabled());
 
         // Toggle off when migrating.
-        when(migrationData.isSoftApTimeoutEnabled()).thenReturn(false);
+        when(mOemMigrationData.isSoftApTimeoutEnabled()).thenReturn(false);
         deserializeData(
                 TEST_SOFTAP_CONFIG_XML_STRING_WITH_ALL_CONFIG_EXCEPT_AUTO_SHUTDOWN.getBytes());
-        verify(mDataSource).fromDeserialized(softapConfigCaptor.capture());
+        verify(mDataSource, times(2)).fromDeserialized(softapConfigCaptor.capture());
         softApConfig = softapConfigCaptor.getValue();
         assertNotNull(softApConfig);
         assertEquals(softApConfig.getSsid(), TEST_SSID);
         assertFalse(softApConfig.isAutoShutdownEnabled());
-
-        session.finishMocking();
     }
 
 }
diff --git a/tests/wifitests/src/com/android/server/wifi/WifiServiceImplTest.java b/tests/wifitests/src/com/android/server/wifi/WifiServiceImplTest.java
index a289171b4..7601850eb 100644
--- a/tests/wifitests/src/com/android/server/wifi/WifiServiceImplTest.java
+++ b/tests/wifitests/src/com/android/server/wifi/WifiServiceImplTest.java
@@ -5580,4 +5580,29 @@ public class WifiServiceImplTest extends WifiBaseTest {
         mLooper.stopAutoDispatchAndIgnoreExceptions();
         verify(mWakeupController).isEnabled();
     }
+
+    @Test
+    public void testSetScanAlwaysAvailableWithNetworkSettingsPermission() {
+        doNothing().when(mContext)
+                .enforceCallingOrSelfPermission(eq(android.Manifest.permission.NETWORK_SETTINGS),
+                        eq("WifiService"));
+        mWifiServiceImpl.setScanAlwaysAvailable(true);
+        verify(mSettingsStore).handleWifiScanAlwaysAvailableToggled(true);
+        verify(mActiveModeWarden).scanAlwaysModeChanged();
+
+        mWifiServiceImpl.setScanAlwaysAvailable(false);
+        verify(mSettingsStore).handleWifiScanAlwaysAvailableToggled(false);
+        verify(mActiveModeWarden, times(2)).scanAlwaysModeChanged();
+    }
+
+    @Test(expected = SecurityException.class)
+    public void testSetScanAlwaysAvailableWithNoNetworkSettingsPermission() {
+        doThrow(new SecurityException()).when(mContext)
+                .enforceCallingOrSelfPermission(eq(android.Manifest.permission.NETWORK_SETTINGS),
+                        eq("WifiService"));
+
+        mWifiServiceImpl.setScanAlwaysAvailable(true);
+        verify(mSettingsStore, never()).handleWifiScanAlwaysAvailableToggled(anyBoolean());
+        verify(mActiveModeWarden, never()).scanAlwaysModeChanged();
+    }
 }