diff options
author | Sunil Ravi <sunilravi@google.com> | 2019-10-15 22:53:46 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2019-10-15 22:53:46 +0000 |
commit | 1ea39a4b59ec4425f9fd8b268be6ec89baabc11a (patch) | |
tree | bcba2d39553d3eaf9343cf15137bba77bccb0298 | |
parent | 0655b2b84a2e134015757d0c5a8a57367283c416 (diff) | |
parent | d396b0aba9a8157a3367dc683937087dd9f14da1 (diff) |
Merge "Revert "[WPA2-Enterprise] Avoid disabling PMF, allow using global value (capable)"" into qt-qpr1-dev
-rw-r--r-- | service/java/com/android/server/wifi/SupplicantStaNetworkHal.java | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java b/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java index 9255fc231..dd56b5f57 100644 --- a/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java +++ b/service/java/com/android/server/wifi/SupplicantStaNetworkHal.java @@ -339,19 +339,11 @@ public class SupplicantStaNetworkHal { Log.e(TAG, config.SSID + ": failed to set hiddenSSID: " + config.hiddenSSID); return false; } - // The logic below is skipping WPA2-Enterprise explicit setting of PMF to disabled - // in order to allow connection to networks with PMF required. Skipping means that - // wpa_supplicant will use the global setting (optional/capable). - // TODO(b/130755779): A permanent fix should convert requirePMF to a tri-state variablbe - boolean wpa2EnterpriseSkipPmf = !config.requirePMF - && (config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.WPA_EAP) - || config.allowedKeyManagement.get(WifiConfiguration.KeyMgmt.IEEE8021X)); + /** RequirePMF */ - if (!wpa2EnterpriseSkipPmf) { - if (!setRequirePmf(config.requirePMF)) { - Log.e(TAG, config.SSID + ": failed to set requirePMF: " + config.requirePMF); - return false; - } + if (!setRequirePmf(config.requirePMF)) { + Log.e(TAG, config.SSID + ": failed to set requirePMF: " + config.requirePMF); + return false; } /** Key Management Scheme */ if (config.allowedKeyManagement.cardinality() != 0) { |