summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-25shinano-common: wpa_supplicant: Add support for starting HIDL HAL lazilyRoshan Pius
Bug: 72394251 Test: Able to start supplicant from framework using ISupplicant.getService() Change-Id: I19b8434e7241b9028e7dc86316ec9d5512affcca Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-25shinano-common: wpa_supplicant: Move control sockets to /data/vendorJeff Vander Stoep
Treble compliance. Bug: 70228425 Bug: 70393317 Test: complete wifi test in b/70393317 Test: verify sockets exist in /data/vendor/wifi/wpa/sockets Change-Id: I0bfc3a351419f0a03498e79664949f353369bf1b Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-25shinano-common: wpa_supplicant: Deprecate entropy.binJeff Vander Stoep
Wpa_supplicant's random pool is not necessary on Android. Randomness is already provided by the entropymixer service which ensures sufficient entropy is maintained across reboots. Commit b410eb1913 'Initialize /dev/urandom earlier in boot' seeds /dev/urandom with that entropy before either wpa_supplicant or hostapd are run. Bug: 34980020 Test: Use wifi and wifi tethering on Taimen Change-Id: Iaa2a8a42e4e3fd941c5be0f8fa691245cdb429e9 Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-25shinano: Update timekeep service init rcSpiritCroc
Bring it in line with hardware/sony/timekeep/vendor/etc/init/timekeep.rc Change-Id: I58a716741113b6e5afebc877a6205f8e5d63a476
2019-10-25sepolicy: address timekeep denials [2/2]Vladimir Oltean
* Relabel all /sys/class/rtc files from sysfs to sysfs_rtc so that timekeep has restricted access permission. Change-Id: I583e407fcbf0127698319f68a8f69c969e1a1b49 Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
2019-10-25shinano-common: move bluetooth impl from msm8974-common115ek
* rhine also uses msm8974-common but has got problems with bluetooth impl so we move it to shinano-only Change-Id: I49302f246a2aa9f5b1c83883a661807396b21010
2019-10-25shinano-common: Fix init compilation for PieMichael Bestas
* Add import_kernel_cmdline locally to avoid build errors from weird headers dependency chain * Rework on bacons implementation Change-Id: I9a0c9c5d0691340f24808348e679ed2a11ac12d5
2019-10-25shinano-common: rootdir: Set sys.usb.ffs.aio_compatJerry Zhang
The kernel does not support aio with ffs. Set the property so adb/mtp know to use the compatible functions, and the same while in recovery. Bug: 37916658 Test: Use adb / use adb in recovery Change-Id: I540b979ee0890aa8e9b20ec7d4332c4193952c46
2019-10-25shinano: Add HVDCP service for QC2.0Andrew Dodd
This is used to enabled HVDCP (Quick Charge 2.0) negotiation Without this service, HVDCP chargers will treat the device as a non-HVDCP-capable one. Signed-off-by: Humberto Borba <humberos@gmail.com> Change-Id: Ic6921af66e86eed3e41c523a5543530c409fda18 (cherry picked from commit 1996c89092a98db01981378a18906f59e6d6f32c)
2019-10-25shinano: vendor: Move device specific system configs into /vendor/etcMax Weffers
Change-Id: I5779e67d305fa7720460f836ad30249147049ea3
2019-10-25msm8974: camera: Update media_profiles for new camrecorder modesxkeita
- Enable 4k UHD - Based on Sony .291 parameters - Force 720p@120fps and 1080p@60fps - Updated values from LA.BF64.1.2.3_rb1.13 Change-Id: I070f44e261c553e25376d70e3e3c4a866a853a9f
2019-10-25shinano-common: increase vmalloc to 300mbSteven Lay
Was removed somewhere so add it back. Also present on stock. Change-Id: Ie77ab4ef535de81d976b7652f190f7fbcffeb5fb
2019-10-25shinano: Use the new generated shimMax Weffers
EDIT: Bring in line with upstream Change-Id: Ic4435dd9a225dcc01ff73a0d9ec7078213249ea0
2019-10-25shinano: add missing socket flag to wpa_supplicantMax Weffers
This fixes WiFi Display on Z3 and Z3C. Change-Id: I9d6c3fe215d0c9de6b1fa38b68d0cf6cc5a2229b
2019-10-25shinano: Set res_info graphics node ownershipOle Birketvedt
* Fixes MHL Change-Id: Ie97ec60eda7024cf859d98c0ed71f3e762c57975
2019-10-25shinano: media: Create media_profiles_V1_0.xmlPawin Vongmasa
media_profiles_V1_0.xml is created from media_profiles.xml by replacing the dtd schema inside media_profiles.xml with an external reference to /system/etc/media_profiles_V1_0.dtd. Test: Compiles Bug: 36430270 From: Pawin Vongmasa <pawin@google.com> Date: Wed May 03 22:42:57 2017 -0700 Remove the property media.settings.xml. This CL also removes media_profiles.xml as it should be replaced by media_profiles_V1_0.xml. Bug: 36430270 Merged-In: I4299abfde44ced36560736520d0be592894d00a7 Change-Id: I4299abfde44ced36560736520d0be592894d00a7 Merged-In: I2bdd38bc8e85cdb64c4729a6ebc843f5031c127c Change-Id: I2bdd38bc8e85cdb64c4729a6ebc843f5031c127c Signed-off-by: Chippa-a <vusal1372@gmail.com> Signed-off-by: Adrian DC <radian.dc@gmail.com>
2019-10-25shinano: Move NFC treble service from commonSpiritCroc
Change-Id: I915f6cee8ba8356eb2ea888f42f22eacd0ae3a0b
2019-10-25shinano-common: rootdir: Add system and graphics group to chargerArian
2019-10-25shinano-common: fstab: Update usb OTG mount argsnailyk-fr
* Vold now use 'usb' instead of 'usbdisk' for OTG storage. Change-Id: I794a3296786cebb27942b175be3b6a9b49a11d70 Signed-off-by: nailyk-fr <jenkins@nailyk.fr>
2019-10-25shinano-common: Stop feedback loop in calls and enable ancCraig Tatlor
Change-Id: Ie60eae35dcc9c53c6a0064594689631802190a75
2019-10-25shinano: Init: Adjust torch permissions for cam server.nailyk-fr
* The cameraserver has been separated from the media- server with Android N. Hence, camera-related files need to be ownerd by the "camera" group. Chown the flash sysfs to account for this. Otherwise, flash will not work and prevent saving pictures if flash is used. Change-Id: I86c19e555683740db74665c0d0986462c2ef4697 Signed-off-by: nailyk-fr <nailyk_git@nailyk.fr>
2019-10-25shinano-common: Use wpa_supplicant for p2pCraig Tatlor
Change-Id: I61cebaf778545f0953b96b14b50874d61e062b97
2019-10-25shinano: sepolicy: move rw_dir_file definition to msm8974SpiritCroc
Change-Id: Ife08e9c41024331ca190ff6612ae8be5764a4ceb
2019-10-07shi-m-ano-common: Transition to TARGET_LD_SHIM_LIBSPaul Keith
* Limits security exposure from shims * As a bonus, we no longer need noatsecure to make LD_SHIM_LIBS persist through services Change-Id: I877192422062f3e59c81a7130ad1a2b4be5d1647
2019-10-07audio: audiod is deprecated removemcgi5sr2
* remove the audiod from qcom.rc init file Change-Id: I770b757eaa4c6688a30dafbaa9055a78371da0ae
2019-10-07shinano-common: init: Remove deprecated loc_servicenailyk
Change-Id: I5504c2b631e6826454e174662146dc03632b8d87 Signed-off-by: nailyk <nailyk_git@nailyk.fr>
2019-10-07shinano-common: fstab: Replace zramstreams flagnailyk
* zramstream do not exist anymore in system/core/fs_mgr . Use max_comp_streams instead. Change-Id: Ic84c7b5b59eeaedcf8290c351b094bec0e83e372 Signed-off-by: nailyk <nailyk_git@nailyk.fr>
2019-10-07Remove duplicate sepolicy definitionSpiritCroc
Already defined in device/aicp/sepolicy
2019-10-07shinano-common: early-mount systemArian
2019-10-07shinano-common: init: Correct taimport pathnailyk
Change-Id: I40784085c259de7bb7b1ed01408df87704065a6c Signed-off-by: nailyk <nailyk_git@nailyk.fr> Signed-off-by: Arian <arian.kulmer@web.de>
2019-10-07shinano-common: init: Remove old 'tad' usernailyk
Change-Id: I6ac02c26a39e14660b0e397abccda0680e3a53da Signed-off-by: nailyk <nailyk_git@nailyk.fr> Signed-off-by: Arian <arian.kulmer@web.de>
2019-10-07shinano: Move shell scripts to system/vendor.Alexander Diewald
* Scripts use the /system/vendor/bin/sh shebang now. * Move shell scripts from system/etc to vendor/system/bin. * Adjust init files. Change-Id: Ib0b9eb59305425b415e2681e7943f9ebfa6480d4 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com> Signed-off-by: Arian <arian.kulmer@web.de>
2019-10-07shinano:init: Fix compilation dependencies with O-MR1Max Weffers
Change-Id: I9a0221d16bee9bbdf99d01d658d6d81ab990f45c
2019-10-07shinano:rename camera blob to camera.vendor.qcomMax Weffers
Change-Id: If1180961ccdb10c1fd63fd2fac9276148047ab47
2019-10-07shinano: bt: fix rfkill prop nameMax Weffers
Change-Id: If00adbc448f08e0690963390ad392f28a321104e
2019-10-07shinano: sepolicy: Allow WIFI service to read the FW files.Alexander Diewald
... The policy file was missing from commit https://github.com/omnirom/android_device_sony_shinano-common/commit/c9d825a67a3074f100a9c8486a1acdedccdbbb78 Change-Id: I530e10c1a4e41d718cf2f80f3fb91e07579c63b5 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: init: Change gpsone locationnailyk
* E/failed to change mode for /data/misc/location/gpsone_d/gpsone_loc_api_q, error = No such file or directory Change-Id: Ib324233c35bcefbb139fd1613f773b290a97b10b Signed-off-by: nailyk <nailyk_git@nailyk.fr>
2019-10-07shinano: sepolicy: label the dumpstate service.Alexander Diewald
Change-Id: Id6dd04a1c7c5fa5ce6d0158ace578c614c0e1639 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: sepolicy: Fix UIM denials.Alexander Diewald
* Grand access to qseecomd. * Grant access to bluetooth properties. Change-Id: Iacd41d8c313e1137c66e76da2ee2c4db7b3f4883 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: sepolicy: seclabel the netmgrd service.Alexander Diewald
Change-Id: Idea087c18e632e9d6a43ddb4b8275a9b1510d224 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: sepolicy: Allow mlog_qmi to access its own socket.Alexander Diewald
I mlog_qmi_servic: type=1400 audit(0.0:37): avc: denied { create } for scontext=u:r:mlog_qmi:s0 tcontext=u:r:mlog_qmi:s0 tclass=socket permissive=1 Change-Id: Ic659f526a436afd4509dea0a3780aa38f78b4875 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: move sec_configs to vendor/etcMax Weffers
Change-Id: If43560ba59f25a84cf7f76eeba1de203d0e6dc70
2019-10-07shinano-common: Implement dumpstate as a serviceKeita
Change-Id: I77f72b9541b8adcc152fe64e45fd4528cff60f4f
2019-10-07shinano: fix led light permissionsMax Weffers
Change-Id: Iab7abd2d5e43ce4cd855f8612cb7b2ebbe6b762a
2019-10-07shinano-common: Remove CMHW VibratorHW implementationKeita
* Replaced with vibrator service Change-Id: I9aa2d3875d9cc230ec4296f5b05e0ceb5d67cb54
2019-10-07shinano-common: Define kernel zImage nameAdrianDC
* Automated detection removed in following commit: https://review.lineageos.org/#/c/192397/ Change-Id: I613c1756f52d78e5af9033a810a86968a0f3623e
2019-10-07shinano: move shims to vendorMax Weffers
Change-Id: Iee818f5a42056206e9dfd5fcc6f1c52ce3b69df3
2019-10-07shinano: move audio configs and sensor init to vendorMax Weffers
Change-Id: Id5c596337788c329e274c5fb7db6eefa7fbb87d1
2019-10-07shinano: Allow init to access qseecom.Alexander Diewald
Change-Id: I553837282f0a785162b7799b65a3a6b2d406599f Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: sepolicy: Fix wifi related denials.Alexander Diewald
* Label FW path (for the communication with the kernel). * Allow the HAL (Treble) service to read the FW files. Change-Id: I50c43882bf1837e87cc4609de74caf4ed7aa78c5 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: init: Adjust vendor service path.Alexander Diewald
* In order to be compliant with the proprietary file locations, adjust the path to the binaries in the init files. The blob binaries have been moved from "/system/bin" to "/system/vendor/bin" * The idea behind the move is to profit from qcom's sepolicy file labelling. Change-Id: I78b96730638258ffd54640f7951ceebc7f503fc4 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: Resolve mlog_qmi related denials.Alexander Diewald
* Create socket perms for the own socket. * Allow access to qseecom. Change-Id: Ifbd5f08f1d9bbbadc3ba94ad79d1e8f7f5286635 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: Define SEpolicy for adsprpcd.Alexander Diewald
* Define the ioctls and grant access to the socket. * Allow access to qseecom socket. * Label adsprpcd service appropriately. Change-Id: I4a0ccd322b16c30e7f10dccc1278ed17507d56e2 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: Fix the loc_launcher path in init.Alexander Diewald
Change-Id: I7a4e366f1e06a569035b1ab3fc2acb7c91057a4f Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano-common: Update kernel command lineMax Weffers
Change-Id: Ic57cef209a187c355feb6a509f3d9fdcfb39cdf8
2019-10-07shinano-common: Update ZRAM size to .291 valueMax Weffers
Change-Id: I0d20764367926d22cf230feb6cd36a628bf90e58
2019-10-07shinano: use 64-bit binder APIMax Weffers
Change-Id: Iac19da048794e0e802142f765827b51e05fb3d62
2019-10-07shinano: move BT/FM (Broadcom) Config from shinano.mk to boardconfigMax Weffers
Change-Id: Idbc1b1a8501647a4b525beacd7f1455a74473f35
2019-10-07shinano-common: build: Add compass permissionnailyk-fr
Change-Id: I3156a524132d9f1459874998aa0d4eeff2e562ca Signed-off-by: nailyk-fr <nailyk_git@nailyk.fr>
2019-10-07shinano: Allow reading the BT firmware.Alexander Diewald
Change-Id: Ie7d708e2457928de0fe2e75054bda0dc3d66afa6 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: init: Set correct permission to sony camera infoMax Weffers
Change-Id: Ibb373dac77f75c4962768ceed432b8f7fe175460
2019-10-07shinano: Rework qcom.power initKeita Espinoza
- Boot phone in interactive mode instead of performance - Add TWRP config Squashed with: shinano-common: init: Add back init.recovery * Add back init.recovery to copy file with the real name instead of copy/rename at the same operation. * Import init.qcom.power from init.recovery to allow mitigation on recovery. * Create bootdevice symlink as lot of zip use it. Rework qcom.power init change ID: Change-Id: I647c09e430bc3904ff526ed662191e7d3b833e0b
2019-10-07shinano-common: sepolicy: Allow self mlog socketnailyk-fr
Change-Id: Ia33c2b403922198847da9773c0cf1c02e2c62597
2019-10-07Shinano-common: init: Rework credmgr init scriptnailyk-fr
* Next to the AIDs remove credmgrd init script need some reworks. Root perm at startup is needed for chmod/chown. Change-Id: I9373820c8d0d2fc68e25d671ffbf638fead75316
2019-10-07shinano-common: init: Get rid of oem usersnailyk-fr
* Camera can work without sony specific users. Remove them. Change-Id: Idb359fa33532c1fa2b8f042362bb027f76ec31e4
2019-10-07shinano-common: init: Rework users for mediaservernailyk-fr
Change-Id: Ie2ed042cfc5e97a71e0485fc048580b9f04cf694
2019-10-07shinano: use libsensor shims for cameraMax Weffers
Change-Id: Iee2115a8143b501f0cf265a650351c291e8006f2
2019-10-07shianno-common: usb: rootdir: Enable FunctionFSLuK1337
Change-Id: I12ff6e794e6993940284e6dfb48b718c40fdd3b1
2019-10-07shinano: Add Timekeep.Alexander Diewald
Adds the init lines required to launch timekeep. They will be moved to msm8974-common in future along with other qcom/msm8974-specific init statements. Change-Id: If21402553dbeaf77e40885dae58e9f376fe85798 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07shinano: Import changes for oreo driver and new fm repoMax Weffers
Change-Id: Ib587c34352d86550253e3f9f49c7a3ed7c25ff78
2019-10-07shinano: Add shims for camera startMax Weffers
Change-Id: I1fee8c6ff28e2011d85cc6fa18c01560af12c8dc
2019-10-07SEPolicy: Add ioctl whitelist for UIM.Alexander Diewald
Adds a list of ioctls, which are emitted by the UIM service. This service setups the broadcom BT/FM driver. Change-Id: Ib37674796a5e2d677a4bb3f596110f906f290b74 Signed-off-by: Alexander Diewald <Diewi@diewald-net.com>
2019-10-07Fix mm-qcam missing symbolnailyk-fr
Change-Id: I2d8304da9ca128e59df8e324330842ad46638e04
2019-10-07shinano-common: init: Change idd pathnailyk-fr
Change-Id: Ifa282ce22563f513cbd632084346e6f6bd2af059
2019-10-07shinano: Import hci attach.teMax Weffers
Change-Id: Ie6d0fdba3a2c06e5d2852a41c0c84ca1f65f7b07
2019-10-07shinano-common: init: Use obscur oreo UID/GID 2/2nailyk-fr
* Correct some sed mistakes. Change-Id: I9f08615c0e622740fdc7ab80b25855dc03c87a74
2019-10-07shinano-common: sepolicy: Remove ioctl refsnailyk-fr
* A new way exist for ioctl management. Remove all old refs. Change-Id: I52f9c0e8f115ea26e22a93566c24cbd8a7b3a58f
2019-10-07shinano-common: init: Replace on post-fsklemmm
* Init class on post-fs has been deprecated. Use on post-fs-data instead. * Don't create /cache/credmgr.log (it prevented initcredmgr from starting) Change-Id: Icf275a51de665cfeb28e9f860a64a38bf4226b6a
2019-10-07shinano-common: init: Use obscur oreo UID/GIDnailyk-fr
* With oreo all the AIDs process change. According to https://source.android.com/devices/tech/config/filesystem#using-an-oem-specific-aid user firendly names cannot be used anymore. Use oem_<uid> name instead. See msm8974-common related change for reference. Change-Id: I18294c5ba716a6c2ba038b9f624f5ae65f799e1f
2019-10-07shinano-common: force to load nfc_nci.pn54x.default instead of nfc_nci.defaultMax Weffers
Change-Id: I55ac94b9b9c0319cfa5dceeab8580472aee2534e
2019-10-07shinano-common: Add missing BT permissionMax Weffers
Change-Id: I01cd402147cf099344761217ddc51957c78a1e06
2019-10-07shinano-common: fix missing Bluetooth-Labels in ueventdMax Weffers
Change-Id: I4c1d6b7201a09561240f193daab23e4ba8d39e8a
2019-10-07shinano-common: Set ro.rfkilldisabled = 1 for bluetoothMax Weffers
Change-Id: I5ac186378f9009fde1be1b9db6f2d4e35a0a2798
2019-10-07shinano: rootdir: init: set wifi user for bcmdhd firmware pathMax Weffers
Change-Id: I4382b2e151cfa98a75a4be60c71d19a01145dc79
2019-10-07Revert "shinano-common: build: Our kernel is missing CLOCK_BOOTTIME_ALARM ↵Arian
(alarmtimer)" This reverts commit d9806a58d08ec872d814e451d7f87db14c252ee2.
2019-10-07shinano-common: init: Add system group to netmgrd processAbhinav Kannan
To allow netmgrd to acquire wakelocks correctly we need to ensure that it belongs to system group Bug: 24546055 Change-Id: I6231c7d1eb57a12da9be4f081e085e6f1d43b797
2019-10-07shinano: sepolicy: remove vibration dev typeMax Weffers
Change-Id: I413e7dc177b0f47742c9ac4ab032cc61a490d573
2019-10-07shinano-common: Replace QCOM group identifiers with oem_XXXXintervigilium
* config.fs doesn't give the ability to add AIDs to Android init such that they can can actually be used in init scripts. * Replace instances of qcom_diag, rfs, rfs_shared with the appropriate IDs (2950, 3012, 3013) Change-Id: Ided896c4ee051a9bc19fd61ae6e03624f2d54cf3
2019-10-07shinano-common: rootdir: replace net_bt_admin and net_bt_stack group with ↵Arian
bluetooth group
2019-10-07shinano: init: rename charger service pathMax Weffers
Change-Id: Ie7c0ecaf48622c8d0bd47591d819e608c7d40fb8
2019-10-07shinano: bluetooth: add the libbt-vendor packageMax Weffers
Change-Id: I7360723cd0b47b4bebf380f8e668141442e41c0f
2019-10-07shinano: init: Add libbase as LOCAL_STATIC_LIBRARIEMax Weffers
Change-Id: Iff005484769df6cf8d5618c2149396c409ca53e9
2019-10-07shinano: codec: disable media_codecs_ffmpegMax Weffers
Change-Id: If346e75fcfeb857c06c1756fdaf610383d6c85dc
2019-10-07shinano: move wpa supplicant paths to vendor/bin/hwtomascus
Change-Id: Iab1ab0ba085d3eb59f50d97079531ab77bf58ad2
2019-10-07shinano: disable ANT+ for nowtomascus
Change-Id: I20806ab335a62b5b76c74d5dd0e9abb5d025fb47
2019-10-07sony-common: update debugfs mount as AOSPDavid
https://android.googlesource.com/platform/system/core/+/android-6.0.1_r68/rootdir/init.rc#21 why this .... Debugfs exists as a simple way for kernel developers to make information available to user space also it is not enabled in android-6.0.1_r66 tag and not more in N but for development purposes it is needed here ..... Change-Id: Ic332aeb073edd09b38de756e89b2d98582bc5c79 Signed-off-by: David Viteri <davidteri91@gmail.com> Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-07shinano-common: move common sepolicy to msm8974-commonNikhil Punathil
Change-Id: I270a673ac8c13dd192799e2513ec377919653458 Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-07shinano-common: move some more common shims to msm8974-commonNikhil Punathil
Change-Id: I7fc609323254b5e164440444293fa4f23aad929b Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-07shinano-common: Move common shims to msm8974-commonNikhil Punathil
Change-Id: Id79c5db191011fbb93a5ad6c4a9b58653bf79ba2 Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>
2019-10-07shinano-common: Import media_profiles.xml from commonOndrej Hlavac
Change-Id: Icb72a78ce2f8b39d39ffad1ee5409247d997636b Signed-off-by: Nikhil Punathil <nikhilpe@gmail.com>