aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2019-06-23 06:57:53 +0200
committerMartin Roth <martinroth@google.com>2019-10-27 17:52:05 +0000
commitede8dd0b9c0dcf1a2f1478e5cb4e035c148b9ed1 (patch)
tree5e508448b1b823ae1025e56b48a495325b7d3b80
parent0edf6a59f8b5ad5dd6911078f349357fd36625ab (diff)
src/{device,drivers}: Use 'include <stdlib.h>' when appropriate
Also, including <types.h>, is supposed to provide stdint and stddef. Change-Id: I99918a5a77e759bc7d4192d2c3fd6ad493c70248 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33681 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/device/device_util.c1
-rw-r--r--src/device/oprom/realmode/x86.c1
-rw-r--r--src/drivers/i2c/tpm/cr50.c3
-rw-r--r--src/drivers/i2c/tpm/tis_atmel.c3
-rw-r--r--src/drivers/smmstore/store.c2
-rw-r--r--src/drivers/spi/flashconsole.c2
-rw-r--r--src/drivers/spi/spi-generic.c2
-rw-r--r--src/drivers/spi/spi_flash.c2
8 files changed, 13 insertions, 3 deletions
diff --git a/src/device/device_util.c b/src/device/device_util.c
index df66f5c620..d8a84316c0 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -16,6 +16,7 @@
#include <device/path.h>
#include <device/pci_def.h>
#include <device/resource.h>
+#include <stdlib.h>
#include <string.h>
/**
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c
index 8ba0241ea4..1026ddb7ff 100644
--- a/src/device/oprom/realmode/x86.c
+++ b/src/device/oprom/realmode/x86.c
@@ -21,6 +21,7 @@
#include <device/pci_ids.h>
#include <pc80/i8259.h>
#include <pc80/i8254.h>
+#include <stdlib.h>
#include <string.h>
#include <vbe.h>
diff --git a/src/drivers/i2c/tpm/cr50.c b/src/drivers/i2c/tpm/cr50.c
index 3c70b7e6e3..6714bd4a03 100644
--- a/src/drivers/i2c/tpm/cr50.c
+++ b/src/drivers/i2c/tpm/cr50.c
@@ -29,7 +29,6 @@
#include <arch/early_variables.h>
#include <commonlib/endian.h>
-#include <stdint.h>
#include <string.h>
#include <types.h>
#include <delay.h>
@@ -38,6 +37,8 @@
#include <endian.h>
#include <timer.h>
#include <security/tpm/tis.h>
+#include <stdlib.h>
+
#include "tpm.h"
#define CR50_MAX_BUFSIZE 63
diff --git a/src/drivers/i2c/tpm/tis_atmel.c b/src/drivers/i2c/tpm/tis_atmel.c
index bfc25c4100..42df292615 100644
--- a/src/drivers/i2c/tpm/tis_atmel.c
+++ b/src/drivers/i2c/tpm/tis_atmel.c
@@ -13,7 +13,6 @@
*/
#include <arch/early_variables.h>
-#include <stdint.h>
#include <assert.h>
#include <commonlib/endian.h>
#include <console/console.h>
@@ -22,7 +21,9 @@
#include <endian.h>
#include <lib.h>
#include <security/tpm/tis.h>
+#include <stdlib.h>
#include <timer.h>
+#include <types.h>
#define RECV_TIMEOUT (1 * 1000) /* 1 second */
#define XMIT_TIMEOUT (1 * 1000) /* 1 second */
diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c
index 3922746eea..dc4a0cf75b 100644
--- a/src/drivers/smmstore/store.c
+++ b/src/drivers/smmstore/store.c
@@ -18,6 +18,8 @@
#include <commonlib/region.h>
#include <console/console.h>
#include <smmstore.h>
+#include <stdlib.h>
+#include <types.h>
/*
* The region format is still not finalized, but so far it looks like this:
diff --git a/src/drivers/spi/flashconsole.c b/src/drivers/spi/flashconsole.c
index 2a0d2358b9..8874812449 100644
--- a/src/drivers/spi/flashconsole.c
+++ b/src/drivers/spi/flashconsole.c
@@ -17,6 +17,8 @@
#include <fmap.h>
#include <console/console.h>
#include <console/flash.h>
+#include <stdlib.h>
+#include <types.h>
#define LINE_BUFFER_SIZE 128
#define READ_BUFFER_SIZE 0x100
diff --git a/src/drivers/spi/spi-generic.c b/src/drivers/spi/spi-generic.c
index 28402182dd..05bfb82bf8 100644
--- a/src/drivers/spi/spi-generic.c
+++ b/src/drivers/spi/spi-generic.c
@@ -14,6 +14,8 @@
#include <assert.h>
#include <spi-generic.h>
+#include <stddef.h>
+#include <stdlib.h>
#include <string.h>
int spi_claim_bus(const struct spi_slave *slave)
diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c
index 88867fd54c..7b5266a280 100644
--- a/src/drivers/spi/spi_flash.c
+++ b/src/drivers/spi/spi_flash.c
@@ -18,11 +18,11 @@
#include <boot/coreboot_tables.h>
#include <console/console.h>
#include <cpu/x86/smm.h>
-#include <stdlib.h>
#include <string.h>
#include <spi-generic.h>
#include <spi_flash.h>
#include <timer.h>
+#include <types.h>
#include "spi_flash_internal.h"