aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-12-29 07:48:09 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-01-20 09:25:08 +0000
commitcee844c9575840df3ae7134414c6124e17b0d54b (patch)
tree89c6c9ca93f2106bd3bf5a11c66a58cec5be8c53
parent780e02d1a54598f60f290e7eaba3c0456006ecce (diff)
mainboards: Drop GNVS cmap and cmbp
Functionality depends of CMAP and CMBP references inside board specific ASL implementation. Only roda/rk9 and roda/rk886ex has that. Change-Id: I4da8292375cb589d67dc68496b1e81971bc2a61f Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49274 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/apple/macbook21/acpi_tables.c12
-rw-r--r--src/mainboard/asrock/g41c-gs/acpi_tables.c1
-rw-r--r--src/mainboard/asus/p5qc/acpi_tables.c1
-rw-r--r--src/mainboard/asus/p5ql-em/acpi_tables.c1
-rw-r--r--src/mainboard/asus/p5qpl-am/acpi_tables.c1
-rw-r--r--src/mainboard/emulation/qemu-q35/acpi_tables.c10
-rw-r--r--src/mainboard/foxconn/g41s-k/acpi_tables.c2
-rw-r--r--src/mainboard/getac/p470/acpi_tables.c9
-rw-r--r--src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c1
-rw-r--r--src/mainboard/ibase/mb899/acpi_tables.c12
-rw-r--r--src/mainboard/intel/dg41wv/acpi_tables.c1
-rw-r--r--src/mainboard/intel/dg43gt/acpi_tables.c1
-rw-r--r--src/mainboard/kontron/986lcd-m/acpi_tables.c12
-rw-r--r--src/mainboard/lenovo/t400/acpi_tables.c5
-rw-r--r--src/mainboard/lenovo/t60/acpi_tables.c4
-rw-r--r--src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c1
-rw-r--r--src/mainboard/lenovo/x200/acpi_tables.c5
-rw-r--r--src/mainboard/lenovo/x60/acpi_tables.c4
18 files changed, 0 insertions, 83 deletions
diff --git a/src/mainboard/apple/macbook21/acpi_tables.c b/src/mainboard/apple/macbook21/acpi_tables.c
deleted file mode 100644
index cc64c30104..0000000000
--- a/src/mainboard/apple/macbook21/acpi_tables.c
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
-}
diff --git a/src/mainboard/asrock/g41c-gs/acpi_tables.c b/src/mainboard/asrock/g41c-gs/acpi_tables.c
index 99bf06a989..566cad75bb 100644
--- a/src/mainboard/asrock/g41c-gs/acpi_tables.c
+++ b/src/mainboard/asrock/g41c-gs/acpi_tables.c
@@ -6,5 +6,4 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/asus/p5qc/acpi_tables.c b/src/mainboard/asus/p5qc/acpi_tables.c
index cd511d92a7..1ac09572f1 100644
--- a/src/mainboard/asus/p5qc/acpi_tables.c
+++ b/src/mainboard/asus/p5qc/acpi_tables.c
@@ -7,5 +7,4 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/asus/p5ql-em/acpi_tables.c b/src/mainboard/asus/p5ql-em/acpi_tables.c
index cd511d92a7..1ac09572f1 100644
--- a/src/mainboard/asus/p5ql-em/acpi_tables.c
+++ b/src/mainboard/asus/p5ql-em/acpi_tables.c
@@ -7,5 +7,4 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/asus/p5qpl-am/acpi_tables.c b/src/mainboard/asus/p5qpl-am/acpi_tables.c
index 99bf06a989..566cad75bb 100644
--- a/src/mainboard/asus/p5qpl-am/acpi_tables.c
+++ b/src/mainboard/asus/p5qpl-am/acpi_tables.c
@@ -6,5 +6,4 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 6c9ad84c09..08ddf57223 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -2,7 +2,6 @@
#include <types.h>
#include <acpi/acpi.h>
-#include <acpi/acpi_gnvs.h>
#include <arch/ioapic.h>
#include <arch/smp/mpspec.h>
#include <device/device.h>
@@ -11,15 +10,6 @@
#include "../qemu-i440fx/fw_cfg.h"
#include "../qemu-i440fx/acpi.h"
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
-
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-}
void mainboard_fill_fadt(acpi_fadt_t *fadt)
{
diff --git a/src/mainboard/foxconn/g41s-k/acpi_tables.c b/src/mainboard/foxconn/g41s-k/acpi_tables.c
index 3728539686..1a2a9bef07 100644
--- a/src/mainboard/foxconn/g41s-k/acpi_tables.c
+++ b/src/mainboard/foxconn/g41s-k/acpi_tables.c
@@ -6,8 +6,6 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
- gnvs->cmap = 1; /* COM 1 port */
- gnvs->cmap = 1; /* COM 2 port */
gnvs->lptp = 0; /* LPT port */
gnvs->fdcp = 0; /* Floppy Disk Controller */
}
diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c
index 69d1896f68..2de388a74b 100644
--- a/src/mainboard/getac/p470/acpi_tables.c
+++ b/src/mainboard/getac/p470/acpi_tables.c
@@ -3,19 +3,10 @@
#include <string.h>
#include <console/console.h>
#include <acpi/acpi.h>
-#include <acpi/acpi_gnvs.h>
#include <device/device.h>
-#include <soc/nvs.h>
#include "mainboard.h"
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
- /* Enable COM port(s) */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x00;
-}
-
static long acpi_create_ecdt(acpi_ecdt_t * ecdt)
{
/* Attention: Make sure these match the values from
diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c b/src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c
index 45be5eef73..33386c55cd 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c
@@ -9,5 +9,4 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs)
gnvs->lptp = 0; /* LPT port */
gnvs->fdcp = 0; /* Floppy Disk Controller */
gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/ibase/mb899/acpi_tables.c b/src/mainboard/ibase/mb899/acpi_tables.c
deleted file mode 100644
index cc64c30104..0000000000
--- a/src/mainboard/ibase/mb899/acpi_tables.c
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
-}
diff --git a/src/mainboard/intel/dg41wv/acpi_tables.c b/src/mainboard/intel/dg41wv/acpi_tables.c
index 99bf06a989..566cad75bb 100644
--- a/src/mainboard/intel/dg41wv/acpi_tables.c
+++ b/src/mainboard/intel/dg41wv/acpi_tables.c
@@ -6,5 +6,4 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/intel/dg43gt/acpi_tables.c b/src/mainboard/intel/dg43gt/acpi_tables.c
index cd511d92a7..1ac09572f1 100644
--- a/src/mainboard/intel/dg43gt/acpi_tables.c
+++ b/src/mainboard/intel/dg43gt/acpi_tables.c
@@ -7,5 +7,4 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
gnvs->osys = 2002; /* At least WINXP SP2 (HPET fix) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/kontron/986lcd-m/acpi_tables.c b/src/mainboard/kontron/986lcd-m/acpi_tables.c
deleted file mode 100644
index cc64c30104..0000000000
--- a/src/mainboard/kontron/986lcd-m/acpi_tables.c
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_gnvs.h>
-#include <soc/nvs.h>
-
-void mainboard_fill_gnvs(struct global_nvs *gnvs)
-{
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
-}
diff --git a/src/mainboard/lenovo/t400/acpi_tables.c b/src/mainboard/lenovo/t400/acpi_tables.c
index 61b5dac928..9e0ae85adc 100644
--- a/src/mainboard/lenovo/t400/acpi_tables.c
+++ b/src/mainboard/lenovo/t400/acpi_tables.c
@@ -9,11 +9,6 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
-
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
/* Temperature at which OS will shutdown */
gnvs->tcrt = 100;
/* Temperature at which OS will throttle CPU */
diff --git a/src/mainboard/lenovo/t60/acpi_tables.c b/src/mainboard/lenovo/t60/acpi_tables.c
index d48f1ec807..8f4f83b826 100644
--- a/src/mainboard/lenovo/t60/acpi_tables.c
+++ b/src/mainboard/lenovo/t60/acpi_tables.c
@@ -5,10 +5,6 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
/* Temperature at which OS will shutdown */
gnvs->tcrt = 100;
/* Temperature at which OS will throttle CPU */
diff --git a/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c b/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
index 99bf06a989..566cad75bb 100644
--- a/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
+++ b/src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c
@@ -6,5 +6,4 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
gnvs->pwrs = 1; /* Power state (AC = 1) */
- gnvs->cmap = 0x01; /* Enable COM 1 port */
}
diff --git a/src/mainboard/lenovo/x200/acpi_tables.c b/src/mainboard/lenovo/x200/acpi_tables.c
index 61b5dac928..9e0ae85adc 100644
--- a/src/mainboard/lenovo/x200/acpi_tables.c
+++ b/src/mainboard/lenovo/x200/acpi_tables.c
@@ -9,11 +9,6 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
-
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
/* Temperature at which OS will shutdown */
gnvs->tcrt = 100;
/* Temperature at which OS will throttle CPU */
diff --git a/src/mainboard/lenovo/x60/acpi_tables.c b/src/mainboard/lenovo/x60/acpi_tables.c
index d48f1ec807..8f4f83b826 100644
--- a/src/mainboard/lenovo/x60/acpi_tables.c
+++ b/src/mainboard/lenovo/x60/acpi_tables.c
@@ -5,10 +5,6 @@
void mainboard_fill_gnvs(struct global_nvs *gnvs)
{
- /* Enable both COM ports */
- gnvs->cmap = 0x01;
- gnvs->cmbp = 0x01;
-
/* Temperature at which OS will shutdown */
gnvs->tcrt = 100;
/* Temperature at which OS will throttle CPU */