aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-07-07 01:22:57 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-07-08 22:11:31 +0000
commitba045653dc652695efd859363d805ea370adab39 (patch)
tree32f0d57a12dce9c20ca7f7c6c1747bc4d76064bf
parent9511ce7d7feac6afd07d282274d09d3fcf76e8ae (diff)
sb/intel/i82801{gx,ix,jx}/acpi: Align cosmetics
This reduces the differences between ACPI for these three southbridges. Change-Id: If49bad776ebc98cab439f8ea6942471520c476a3 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43155 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Frans Hendriks <fhendriks@eltan.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/southbridge/intel/i82801gx/acpi/audio.asl2
-rw-r--r--src/southbridge/intel/i82801gx/acpi/lpc.asl4
-rw-r--r--src/southbridge/intel/i82801gx/acpi/usb.asl2
-rw-r--r--src/southbridge/intel/i82801ix/acpi/audio.asl2
-rw-r--r--src/southbridge/intel/i82801ix/acpi/globalnvs.asl1
-rw-r--r--src/southbridge/intel/i82801ix/acpi/lpc.asl4
-rw-r--r--src/southbridge/intel/i82801ix/acpi/usb.asl2
-rw-r--r--src/southbridge/intel/i82801jx/acpi/audio.asl2
-rw-r--r--src/southbridge/intel/i82801jx/acpi/globalnvs.asl1
-rw-r--r--src/southbridge/intel/i82801jx/acpi/lpc.asl4
-rw-r--r--src/southbridge/intel/i82801jx/acpi/usb.asl2
11 files changed, 12 insertions, 14 deletions
diff --git a/src/southbridge/intel/i82801gx/acpi/audio.asl b/src/southbridge/intel/i82801gx/acpi/audio.asl
index 19cfcab22b..b9c256c644 100644
--- a/src/southbridge/intel/i82801gx/acpi/audio.asl
+++ b/src/southbridge/intel/i82801gx/acpi/audio.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801G HDA */
+/* Intel ICH HDA */
// Intel High Definition Audio (Azalia) 0:1b.0
diff --git a/src/southbridge/intel/i82801gx/acpi/lpc.asl b/src/southbridge/intel/i82801gx/acpi/lpc.asl
index 0b0e9874f0..137f2bae21 100644
--- a/src/southbridge/intel/i82801gx/acpi/lpc.asl
+++ b/src/southbridge/intel/i82801gx/acpi/lpc.asl
@@ -156,8 +156,8 @@ Device (LPCB)
IO (Decode16, 0x92, 0x92, 0x1, 0x01) // CPU Reserved
IO (Decode16, 0xb2, 0xb2, 0x1, 0x02) // SWSMI
IO (Decode16, 0x800, 0x800, 0x1, 0x10) // ACPI I/O trap
- IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH7-M ACPI
- IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH7-M GPIO
+ IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH ACPI
+ IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH GPIO
})
}
diff --git a/src/southbridge/intel/i82801gx/acpi/usb.asl b/src/southbridge/intel/i82801gx/acpi/usb.asl
index 6c095f2723..16db17595d 100644
--- a/src/southbridge/intel/i82801gx/acpi/usb.asl
+++ b/src/southbridge/intel/i82801gx/acpi/usb.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801G USB support */
+/* Intel ICH USB support */
// USB Controller 0:1d.0
diff --git a/src/southbridge/intel/i82801ix/acpi/audio.asl b/src/southbridge/intel/i82801ix/acpi/audio.asl
index 7dc2564483..b9c256c644 100644
--- a/src/southbridge/intel/i82801ix/acpi/audio.asl
+++ b/src/southbridge/intel/i82801ix/acpi/audio.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801I HDA */
+/* Intel ICH HDA */
// Intel High Definition Audio (Azalia) 0:1b.0
diff --git a/src/southbridge/intel/i82801ix/acpi/globalnvs.asl b/src/southbridge/intel/i82801ix/acpi/globalnvs.asl
index 3b6115feb5..0a0f25511b 100644
--- a/src/southbridge/intel/i82801ix/acpi/globalnvs.asl
+++ b/src/southbridge/intel/i82801ix/acpi/globalnvs.asl
@@ -10,7 +10,6 @@ Name(\PICM, 0) // IOAPIC/8259
* we have to fix it up in coreboot's ACPI creation phase.
*/
-
External(NVSA)
OperationRegion (GNVS, SystemMemory, NVSA, 0x100)
Field (GNVS, ByteAcc, NoLock, Preserve)
diff --git a/src/southbridge/intel/i82801ix/acpi/lpc.asl b/src/southbridge/intel/i82801ix/acpi/lpc.asl
index 6fc2a84719..137f2bae21 100644
--- a/src/southbridge/intel/i82801ix/acpi/lpc.asl
+++ b/src/southbridge/intel/i82801ix/acpi/lpc.asl
@@ -156,8 +156,8 @@ Device (LPCB)
IO (Decode16, 0x92, 0x92, 0x1, 0x01) // CPU Reserved
IO (Decode16, 0xb2, 0xb2, 0x1, 0x02) // SWSMI
IO (Decode16, 0x800, 0x800, 0x1, 0x10) // ACPI I/O trap
- IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH9 ACPI
- IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH9 GPIO
+ IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH ACPI
+ IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH GPIO
})
}
diff --git a/src/southbridge/intel/i82801ix/acpi/usb.asl b/src/southbridge/intel/i82801ix/acpi/usb.asl
index 1f44b4a1c7..55929afb1a 100644
--- a/src/southbridge/intel/i82801ix/acpi/usb.asl
+++ b/src/southbridge/intel/i82801ix/acpi/usb.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801I USB support */
+/* Intel ICH USB support */
// USB Controller 0:1d.0
diff --git a/src/southbridge/intel/i82801jx/acpi/audio.asl b/src/southbridge/intel/i82801jx/acpi/audio.asl
index fca6474cb4..b9c256c644 100644
--- a/src/southbridge/intel/i82801jx/acpi/audio.asl
+++ b/src/southbridge/intel/i82801jx/acpi/audio.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801L HDA */
+/* Intel ICH HDA */
// Intel High Definition Audio (Azalia) 0:1b.0
diff --git a/src/southbridge/intel/i82801jx/acpi/globalnvs.asl b/src/southbridge/intel/i82801jx/acpi/globalnvs.asl
index 3b6115feb5..0a0f25511b 100644
--- a/src/southbridge/intel/i82801jx/acpi/globalnvs.asl
+++ b/src/southbridge/intel/i82801jx/acpi/globalnvs.asl
@@ -10,7 +10,6 @@ Name(\PICM, 0) // IOAPIC/8259
* we have to fix it up in coreboot's ACPI creation phase.
*/
-
External(NVSA)
OperationRegion (GNVS, SystemMemory, NVSA, 0x100)
Field (GNVS, ByteAcc, NoLock, Preserve)
diff --git a/src/southbridge/intel/i82801jx/acpi/lpc.asl b/src/southbridge/intel/i82801jx/acpi/lpc.asl
index 20d9aaf018..137f2bae21 100644
--- a/src/southbridge/intel/i82801jx/acpi/lpc.asl
+++ b/src/southbridge/intel/i82801jx/acpi/lpc.asl
@@ -156,8 +156,8 @@ Device (LPCB)
IO (Decode16, 0x92, 0x92, 0x1, 0x01) // CPU Reserved
IO (Decode16, 0xb2, 0xb2, 0x1, 0x02) // SWSMI
IO (Decode16, 0x800, 0x800, 0x1, 0x10) // ACPI I/O trap
- IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH10 ACPI
- IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH10 GPIO
+ IO (Decode16, DEFAULT_PMBASE, DEFAULT_PMBASE, 0x1, 0x80) // ICH ACPI
+ IO (Decode16, DEFAULT_GPIOBASE, DEFAULT_GPIOBASE, 0x1, 0x40) // ICH GPIO
})
}
diff --git a/src/southbridge/intel/i82801jx/acpi/usb.asl b/src/southbridge/intel/i82801jx/acpi/usb.asl
index 9950f726fb..55929afb1a 100644
--- a/src/southbridge/intel/i82801jx/acpi/usb.asl
+++ b/src/southbridge/intel/i82801jx/acpi/usb.asl
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-/* Intel i82801J USB support */
+/* Intel ICH USB support */
// USB Controller 0:1d.0