aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2024-05-24 13:58:34 +0200
committerNico Huber <nico.h@gmx.de>2024-05-25 14:42:57 +0000
commit824d9303f22b8adc91752464d5f2ac166683e588 (patch)
treecaa424f8efaad2c47974ab9ec6de36301eec2a7b
parent69bc2cc7dedb5647f9e8a3fa6513c46ee09c57a0 (diff)
acpi: introduce and use ACPI_MADT_PCAT_COMPAT define
The multiple APIC flags table from the ACPI specification version 6.4 was used as a reference. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I36f67ca21465bc8753bb36896ee05669de6de333 Reviewed-on: https://review.coreboot.org/c/coreboot/+/82640 Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Elyes Haouas <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/acpi/acpi_apic.c2
-rw-r--r--src/include/acpi/acpi.h3
2 files changed, 4 insertions, 1 deletions
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c
index 2b3402a589..9098811932 100644
--- a/src/acpi/acpi_apic.c
+++ b/src/acpi/acpi_apic.c
@@ -234,7 +234,7 @@ unsigned long acpi_arch_fill_madt(acpi_madt_t *madt, unsigned long current)
madt->lapic_addr = cpu_get_lapic_addr();
if (CONFIG(ACPI_HAVE_PCAT_8259))
- madt->flags |= 1;
+ madt->flags |= ACPI_MADT_PCAT_COMPAT;
if (CONFIG(ACPI_COMMON_MADT_LAPIC))
current = acpi_create_madt_lapics_with_nmis(current);
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index d6c30c1b5f..0e5b4b280f 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -458,6 +458,9 @@ typedef struct acpi_madt {
u32 flags; /* Multiple APIC flags */
} __packed acpi_madt_t;
+/* MADT Feature Flags */
+#define ACPI_MADT_PCAT_COMPAT (1 << 0)
+
/*
* LPIT (Low Power Idle Table)
* Conforms to "Intel Low Power S0 Idle" specification, rev 002 from July 2017.