diff options
| author | Tim Crawford <tcrawford@system76.com> | 2024-04-05 11:46:57 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-05-06 10:41:16 +0000 |
| commit | 6cd9f1a24c4746a11f0d3ac14abfe360baeba1a1 (patch) | |
| tree | 5bdfe43dafa0271968cfe39f21639a2285415ce1 | |
| parent | 40504489446af6dd98cb86adffc46f9a941d710d (diff) | |
mb/system76: Exclude ramtop from CMOS checksum
Use the default position for ramtop and exclude it from the checksum.
Fixes invalid checksum after caching ramtop causing things like
disabling CSME to not work.
Fixes: 10d2af04e754 ("mb/system76: Add space for ramtop in CMOS layout")
Change-Id: If30df1e6f2735cf767856e42dfede3d17fe494eb
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81641
Reviewed-by: Jeremy Soller <jeremy@system76.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/system76/addw1/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/adl/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/bonw14/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/cml-u/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/gaze15/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/oryp5/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/oryp6/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/rpl/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/tgl-h/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/tgl-u/cmos.layout | 7 | ||||
| -rw-r--r-- | src/mainboard/system76/whl-u/cmos.layout | 7 |
12 files changed, 60 insertions, 24 deletions
diff --git a/src/mainboard/system76/addw1/cmos.layout b/src/mainboard/system76/addw1/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/addw1/cmos.layout +++ b/src/mainboard/system76/addw1/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/adl/cmos.layout b/src/mainboard/system76/adl/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/adl/cmos.layout +++ b/src/mainboard/system76/adl/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/bonw14/cmos.layout b/src/mainboard/system76/bonw14/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/bonw14/cmos.layout +++ b/src/mainboard/system76/bonw14/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/cml-u/cmos.layout b/src/mainboard/system76/cml-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/cml-u/cmos.layout +++ b/src/mainboard/system76/cml-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/gaze15/cmos.layout b/src/mainboard/system76/gaze15/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/gaze15/cmos.layout +++ b/src/mainboard/system76/gaze15/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/kbl-u/cmos.layout b/src/mainboard/system76/kbl-u/cmos.layout index 4e9a300ebf..7aec087ea3 100644 --- a/src/mainboard/system76/kbl-u/cmos.layout +++ b/src/mainboard/system76/kbl-u/cmos.layout @@ -12,7 +12,10 @@ entries 400 8 r 0 century 412 4 e 6 debug_level -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -32,4 +35,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/oryp5/cmos.layout b/src/mainboard/system76/oryp5/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/oryp5/cmos.layout +++ b/src/mainboard/system76/oryp5/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/oryp6/cmos.layout b/src/mainboard/system76/oryp6/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/oryp6/cmos.layout +++ b/src/mainboard/system76/oryp6/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/rpl/cmos.layout b/src/mainboard/system76/rpl/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/rpl/cmos.layout +++ b/src/mainboard/system76/rpl/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/tgl-h/cmos.layout b/src/mainboard/system76/tgl-h/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/tgl-h/cmos.layout +++ b/src/mainboard/system76/tgl-h/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/tgl-u/cmos.layout b/src/mainboard/system76/tgl-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/tgl-u/cmos.layout +++ b/src/mainboard/system76/tgl-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/whl-u/cmos.layout b/src/mainboard/system76/whl-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/whl-u/cmos.layout +++ b/src/mainboard/system76/whl-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 |