aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@amd.corp-partner.google.com>2022-09-23 13:24:39 -0500
committerFelix Held <felix-coreboot@felixheld.de>2022-09-28 15:09:29 +0000
commit52a22fa7e68ba92c28f8ef4d53d6c30f0d23c48c (patch)
tree711e74fb06d8300309712aa54b9ac91395a2515f
parentbbf2706fb40461efa3efbefd28ea8a3badf730cd (diff)
mb/google/octopus: rename baseboard GPIO table getter for clarity
Rename variant_base_gpio_table() to baseboard_gpio_table(), since the GPIO table comes from the baseboard, and is overridden by a separate table from the variant. Drop the __weak qualifier as this function is not overridden. Change-Id: I17db734784ce96cdf5e0486dc2ad057d73bfb15f Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67804 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
-rw-r--r--src/mainboard/google/octopus/mainboard.c2
-rw-r--r--src/mainboard/google/octopus/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h2
3 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c
index a614763bda..92b107479d 100644
--- a/src/mainboard/google/octopus/mainboard.c
+++ b/src/mainboard/google/octopus/mainboard.c
@@ -98,7 +98,7 @@ static void mainboard_init(void *chip_info)
boardid = board_id();
printk(BIOS_INFO, "Board ID: %d\n", boardid);
- base_pads = variant_base_gpio_table(&base_num);
+ base_pads = baseboard_gpio_table(&base_num);
override_pads = variant_override_gpio_table(&override_num);
gpio_modification_by_ssfc((struct pad_config *)override_pads,
override_num);
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c
index 76f74a560b..2238a9ffda 100644
--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c
+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c
@@ -275,7 +275,7 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPIO_210, DN_20K),
};
-const struct pad_config *__weak variant_base_gpio_table(size_t *num)
+const struct pad_config *baseboard_gpio_table(size_t *num)
{
*num = ARRAY_SIZE(gpio_table);
return gpio_table;
diff --git a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h
index bbc5d567e7..a1ee5d02ea 100644
--- a/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h
@@ -10,7 +10,7 @@
/* The next set of functions return the gpio table and fill in the number of
* entries for each table. */
const struct pad_config *mainboard_early_bootblock_gpio_table(size_t *num);
-const struct pad_config *variant_base_gpio_table(size_t *num);
+const struct pad_config *baseboard_gpio_table(size_t *num);
const struct pad_config *variant_override_gpio_table(size_t *num);
const struct pad_config *variant_early_gpio_table(size_t *num);
const struct pad_config *variant_early_override_gpio_table(size_t *num);