diff options
author | Nicholas Chin <nic.c3.14@gmail.com> | 2024-03-21 11:27:50 -0600 |
---|---|---|
committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-03-23 15:58:34 +0000 |
commit | 4ff23a22462fa2637be45a771fd4a22fa7e3d4ad (patch) | |
tree | ec263f1e2d6ddd2b1f28310a16189e17377d4f75 | |
parent | d2d7933b488b846448c7dc7daf9bd14acee2e1ef (diff) |
util/lint: Fix license header regex
A trailing "|" at the end of the regex added a zero length alternative
match, causing all files to match and be filtered out. This was causing
`make lint-stable` to ignore all missing license headers, preventing the
pre-commit git hook and Jenkins from detecting these. Also, a missing
"|" separator between cmos.default and .apcb would cause those files to
be unintentionally scanned.
Change-Id: I70cc3a5adf7edee059883cd3cbe02029776b02ef
Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81422
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
-rwxr-xr-x | util/lint/lint-000-license-headers | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 68bdae7bad..56addac710 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -67,8 +67,8 @@ _shipped$|\ \.spd|\ config|\ cmos\.layout|\ -cmos\.default\ -\.apcb$|\ +cmos\.default|\ +\.apcb$\ " #space separated list of directories to test |