From e16971ac64dc36375e5d606cd51950f2807c5bdb Mon Sep 17 00:00:00 2001
From: Nico Huber <nico.h@gmx.de>
Date: Wed, 27 May 2020 18:08:56 +0200
Subject: util/supermicro: Always include commonlib/bsd/compiler.h
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We rely on `compiler.h` for definitions like `__packed`. Without it,
`smcbiosinfo.c` simply declared a global struct with that name, but
nothing was packed.

Found-by: reproducibility test

Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41784
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
 util/supermicro/Makefile.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'util')

diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.inc
index 1aa5bcb437..316cb48864 100644
--- a/util/supermicro/Makefile.inc
+++ b/util/supermicro/Makefile.inc
@@ -1,9 +1,11 @@
+TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
+
 SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo
 
 $(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c
 	printf "    HOSTCC     Creating SMCBIOSINFO tool\n"
 	mkdir -p $(objutil)/supermicro
-	$(HOSTCC) $< -o $@
+	$(HOSTCC) $(TOOLCPPFLAGS) $< -o $@
 
 ifeq ($(CONFIG_VENDOR_SUPERMICRO),y)
 ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),)
-- 
cgit v1.2.3