From ca80196ae21fcd5e305e9f0e4d12fdb3a78ab7be Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 15 Dec 2016 14:53:23 +0100 Subject: util/broadcom: Check for successful file access Change-Id: I5c77b3c5ea3fbc249a8c564a521c2c3c45e1c560 Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1323510 Reviewed-on: https://review.coreboot.org/17877 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- util/broadcom/secimage/io.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'util') diff --git a/util/broadcom/secimage/io.c b/util/broadcom/secimage/io.c index d71065c9c4..f5be50afc7 100644 --- a/util/broadcom/secimage/io.c +++ b/util/broadcom/secimage/io.c @@ -73,6 +73,11 @@ int DataRead(char *filename, uint8_t *buf, int *length) return -1; } len = FileSizeGet(file); + if (len < 0) { + printf("Unable to seek in file: %s\n", filename); + fclose(file); + return -1; + } if (len < *length) *length = len; else -- cgit v1.2.3