From be25f96c2d22cf348b0c47f941bea07f497c2bb8 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Fri, 21 Oct 2022 20:11:10 +0200 Subject: ifdtool: Cleanup IFDv1 detection Change https://review.coreboot.org/c/coreboot/+/54305 "util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset" made the '-p' argument mandatory for IFDv2 platforms. Drop the IFDv2 platform CHIPSET_C620_SERIES_LEWISBURG from IFDv1 detection. Change-Id: If29f8718b7aa696cdc07deef4c98be9a68c66f10 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/68680 Reviewed-by: Arthur Heymans Reviewed-by: Lean Sheng Tan Tested-by: build bot (Jenkins) --- util/ifdtool/ifdtool.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'util') diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 1ddb6b7fe1..4048699242 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -203,7 +203,6 @@ static enum ich_chipset ifd1_guess_chipset(char *image, int size) uint32_t iccriba = (fdb->flmap2 >> 16) & 0xff; uint32_t msl = (fdb->flmap2 >> 8) & 0xff; uint32_t isl = (fdb->flmap1 >> 24); - uint32_t nm = (fdb->flmap1 >> 8) & 0x7; /* Rest for IFD1 chipset type */ if (iccriba == 0x00) { @@ -226,8 +225,6 @@ static enum ich_chipset ifd1_guess_chipset(char *image, int size) return CHIPSET_8_SERIES_LYNX_POINT; printf("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n"); return CHIPSET_9_SERIES_WILDCAT_POINT; - } else if (nm == 6) { - return CHIPSET_C620_SERIES_LEWISBURG; } return CHIPSET_PCH_UNKNOWN; } -- cgit v1.2.3