From 621ed4c06c8c8761e083c550c0edf3c9c66793c9 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 17 Jun 2021 21:13:22 +0530 Subject: util/ifdtool: Use ICH Strap Length (ISL) to identify APL chipset Use offset FLMAP1 bit 24:31, called ISL (ICH Strap Lenth) to uniquely identify the chipsets without any additional logic. +---------+-----------+ | Chipset | PSL Value | +---------+-----------+ | APL | 0x13 | +---------+-----------+ BUG=b:153888802 TEST=Able to dump FD contains correctly without specifying platform quirks on APL (IFDv1) Platform. > ifdtool -d coreboot.rom PCH Revision: Apollo Lake: N3xxx, J3xxx Change-Id: I02bcc6b1ca61c4ee59582f1b310ed0fba0ef1d9a Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/55617 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Angel Pons --- util/ifdtool/ifdtool.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'util') diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 65ac655fe7..923f77f60d 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -190,6 +190,8 @@ static enum ich_chipset ifd1_guess_chipset(char *image, int size) return CHIPSET_ICH10; else if (isl <= 16) return CHIPSET_5_SERIES_IBEX_PEAK; + else if (isl == 0x13) + return CHIPSET_N_J_SERIES_APOLLO_LAKE; printf("Peculiar firmware descriptor, assuming Ibex Peak compatibility.\n"); return CHIPSET_5_SERIES_IBEX_PEAK; } else if (iccriba < 0x31 && (fdb->flmap2 & 0xff) < 0x30) { -- cgit v1.2.3