From 5ad6ec55f84076982c3342d4c7695aa918ac663b Mon Sep 17 00:00:00 2001 From: Mathias Krause Date: Wed, 5 Nov 2014 21:27:01 +0100 Subject: inteltool: Fix message in case of multiple LPC controllers If we find multiple LPC controllers, we want to tell the user that we'll ignore all but the first. However, we use 'dev' in the message (the current device found) instead of 'sb' (the one we want to use). Fix the message by using 'sb' and break the loop right away in this case. It's sufficient to tell the user once which LPC controller we'll use. Change-Id: Ibd27e40525fabe8c63b112691ad49fd994c70a48 Signed-off-by: Mathias Krause Reviewed-on: http://review.coreboot.org/7342 Reviewed-by: Edward O'Callaghan Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- util/inteltool/inteltool.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'util') diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 79f0f3c361..2d785477bb 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -339,13 +339,14 @@ int main(int argc, char *argv[]) pci_fill_info(dev, PCI_FILL_CLASS); /* The ISA/LPC bridge can be 0x1f, 0x07, or 0x04 so we probe. */ if (dev->device_class == 0x0601) { /* ISA/LPC bridge */ - if (sb == NULL) + if (sb == NULL) { sb = dev; - else + } else { fprintf(stderr, "Multiple devices with class ID" " 0x0601, using %02x%02x:%02x.%02x\n", - dev->domain, dev->bus, dev->dev, - dev->func); + sb->domain, sb->bus, sb->dev, sb->func); + break; + } } } -- cgit v1.2.3